-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fixing licensing after server NP cutover #59275
Merged
jgowdyelastic
merged 1 commit into
elastic:master
from
jgowdyelastic:fixing-licensing-after-server-cutover-2
Mar 4, 2020
Merged
[ML] Fixing licensing after server NP cutover #59275
jgowdyelastic
merged 1 commit into
elastic:master
from
jgowdyelastic:fixing-licensing-after-server-cutover-2
Mar 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
:ml
non-issue
Indicates to automation that a pull request should not appear in the release notes
release_note:skip
Skip the PR/issue when compiling release notes
review
v7.7.0
v8.0.0
labels
Mar 4, 2020
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
requested review from
peteharverson,
walterra,
darnautov and
alvarezmelissa87
March 4, 2020 08:35
peteharverson
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
walterra
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededTo update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Mar 4, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Mar 4, 2020
2 tasks
This was referenced Jun 25, 2020
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of #58853 which had to be reverted due to issues with licensing in functional tests.
Reenables the license checking for server and client sides after server side cutover (#58680)
A shared common
mlLicense
class has been added which listens to the licensing updates from the licensing plugin.The server and client then have specialised derived classes which add on checks specific to their needs
Server side
Basic enabled endpoints:
/api/ml/fields_service/time_field_range
/api/ml/file_data_visualizer/analyze_file
/api/ml/file_data_visualizer/import
/api/ml/_has_privileges
/api/ml/ml_capabilities
/api/ml/ml_node_count
/api/ml/info
/api/ml/data_visualizer/get_field_stats/{indexPatternTitle}
/api/ml/data_visualizer/get_overall_stats/{indexPatternTitle}
Client side:
hasLicenseExpired
andisFullLicense
general functions which are used in a few places throughout our UI.Also fixes the management plugin which was being disabled due to its licensing check.
Checklist
Delete any items that are not applicable to this PR.
For maintainers