Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding indices_options to datafeed #59119

Merged
merged 3 commits into from
Mar 3, 2020
Merged

[ML] Adding indices_options to datafeed #59119

merged 3 commits into from
Mar 3, 2020

Conversation

jgowdyelastic
Copy link
Member

Adds support for datafeed property added in elastic/elasticsearch#52793

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 3, 2020 09:25
@jgowdyelastic jgowdyelastic self-assigned this Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pheyos
pheyos approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

peteharverson
peteharverson approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 4ef594c into elastic:master Mar 3, 2020
@jgowdyelastic jgowdyelastic deleted the adding-indices_options-to-datafeed branch March 3, 2020 11:59
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 3, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 3, 2020
@jgowdyelastic
[ML] Adding indices_options to datafeed (elastic#59119)
4beeda6 
* [ML] Adding indices_options to datafeed

* adding extra checks to the schema

* updating expand_wildcards
jgowdyelastic added a commit that referenced this pull request Mar 3, 2020
@jgowdyelastic
[ML] Adding indices_options to datafeed (#59119) (#59132)
4e0852a 
* [ML] Adding indices_options to datafeed

* adding extra checks to the schema

* updating expand_wildcards
@droberts195 droberts195 mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov left review comments

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @pheyos @darnautov @peteharverson