Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Wholesale moves client to newest-platform #58945

Merged
merged 38 commits into from
Mar 17, 2020
Merged

[Reporting] Wholesale moves client to newest-platform #58945

Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ea2d736
Move over to new plugin space, working implementation
Feb 27, 2020
83b2b96
Fixing tests for report_listing snapshots
Feb 27, 2020
5fd3a22
WIP: Fixing react-component tests
Feb 28, 2020
af0f877
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Feb 28, 2020
fe429b9
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Feb 28, 2020
c02b023
Fixing report_info_button tests
Feb 28, 2020
ede19d4
Fixing download linksies
Feb 28, 2020
1a9d6b1
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 2, 2020
e1f4a31
WIP: Final working implementation
Mar 4, 2020
0799652
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 4, 2020
bae7445
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 6, 2020
6322228
Fixing attachAction API + API URLs
Mar 6, 2020
ca80be2
Let the past die. Kill it if you have to. That’s the only way to beco…
Mar 6, 2020
e4d4be7
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 9, 2020
ed82044
Fixing stream-client for new platform APIs
Mar 9, 2020
de45fd9
Fixing types and tests
Mar 9, 2020
257d9c6
Fix broken mock
Mar 9, 2020
9c96e79
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 10, 2020
7dee2d0
Adds back in warnings to report info button
Mar 10, 2020
a03734e
kibana.json line-breaks on required plugins
Mar 10, 2020
1f07d5b
Fixing broked snapshots
Mar 10, 2020
1ef2a1f
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 10, 2020
d0f6c76
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 11, 2020
15a2fbf
Fix license checks in client-side components
Mar 12, 2020
ff293ad
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 12, 2020
3008ad7
Adding back in warnings to report_listing component
Mar 13, 2020
5f2bb0c
Fix danglig unused import
Mar 13, 2020
5d0f89e
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 13, 2020
d3d668c
Adds license checks for basic to our csv panel action
Mar 13, 2020
61e86ab
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 13, 2020
a10e111
Fixes issues from prior fork
Mar 13, 2020
f20576f
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 13, 2020
ce27fa1
Move relative pathing to absolute
Mar 13, 2020
6ad3dac
Merge remote-tracking branch 'upstream/master' into reporting/client-…
Mar 16, 2020
210d627
Fix POST URL copying as we've moved from static methods
Mar 16, 2020
b002fd5
Fix layoutId props
Mar 16, 2020
9c2ecb7
Fixes types for layoutId
Mar 16, 2020
a603278
Merge branch 'master' into reporting/client-np-migration
elasticmachine Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/canvas/public/components/workpad_header/workpad_export/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import { connect } from 'react-redux';
import { compose, withProps } from 'recompose';
import * as jobCompletionNotifications from '../../../../../reporting/public/lib/job_completion_notifications';
import { jobCompletionNotifications } from '../../../../../../../plugins/reporting/public';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought: this looks like a loose end from #47283 and I'm wondering why the Reporting notifications need to be explicitly imported here. Maybe Canvas doesn't register with whatever global notifications that works for the "classical" applications?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is an interesting one... I wanted to dive in deeper to this but didn't want to get too distracted from getting this to just work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-canvas folks ping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is like this. I'll have to dig into what this should look like. Probably not a blocker for this PR, though, I would think

// @ts-ignore Untyped local
import { getWorkpad, getPages } from '../../../state/selectors/workpad';
// @ts-ignore Untyped local
Expand Down
16 changes: 1 addition & 15 deletions x-pack/legacy/plugins/reporting/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { resolve } from 'path';
import { PLUGIN_ID, UI_SETTINGS_CUSTOM_PDF_LOGO } from './common/constants';
import { config as reportingConfig } from './config';
import { legacyInit } from './server/legacy';
import { ReportingConfigOptions, ReportingPluginSpecOptions } from './types';
import { ReportingPluginSpecOptions } from './types';

const kbToBase64Length = (kb: number) => {
return Math.floor((kb * 1024 * 8) / 6);
Expand All @@ -25,20 +25,6 @@ export const reporting = (kibana: any) => {
config: reportingConfig,

uiExports: {
shareContextMenuExtensions: [
'plugins/reporting/share_context_menu/register_csv_reporting',
'plugins/reporting/share_context_menu/register_reporting',
],
embeddableActions: ['plugins/reporting/panel_actions/get_csv_panel_action'],
home: ['plugins/reporting/register_feature'],
managementSections: ['plugins/reporting/views/management'],
tsullivan marked this conversation as resolved.
Show resolved Hide resolved
injectDefaultVars(server: Legacy.Server, options?: ReportingConfigOptions) {
const config = server.config();
return {
reportingPollConfig: options ? options.poll : {},
enablePanelActionDownload: config.get('xpack.reporting.csv.enablePanelActionDownload'),
};
},
uiSettingDefaults: {
[UI_SETTINGS_CUSTOM_PDF_LOGO]: {
name: i18n.translate('xpack.reporting.pdfFooterImageLabel', {
Expand Down
8 changes: 0 additions & 8 deletions x-pack/legacy/plugins/reporting/public/components/report_info_button.test.mocks.ts
View file
Open in desktop

This file was deleted.

77 changes: 0 additions & 77 deletions x-pack/legacy/plugins/reporting/public/components/report_listing.test.tsx
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions x-pack/legacy/plugins/reporting/public/constants/job_statuses.tsx
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions x-pack/legacy/plugins/reporting/public/lib/download_report.ts
View file
Open in desktop

This file was deleted.

89 changes: 0 additions & 89 deletions x-pack/legacy/plugins/reporting/public/lib/job_queue_client.ts
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions x-pack/legacy/plugins/reporting/public/lib/reporting_client.ts
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions x-pack/legacy/plugins/reporting/public/register_feature.ts
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions x-pack/legacy/plugins/reporting/public/views/management/index.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions x-pack/legacy/plugins/reporting/public/views/management/jobs.html
View file
Open in desktop

This file was deleted.

59 changes: 0 additions & 59 deletions x-pack/legacy/plugins/reporting/public/views/management/jobs.js
View file
Open in desktop

This file was deleted.

Loading