-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more permissive validation in request mock #58557
Merged
joshdover
merged 3 commits into
elastic:master
from
joshdover:np/request-mock-validation
Feb 26, 2020
Merged
Use more permissive validation in request mock #58557
joshdover
merged 3 commits into
elastic:master
from
joshdover:np/request-mock-validation
Feb 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Feature:New Platform
release_note:skip
Skip the PR/issue when compiling release notes
v7.7.0
labels
Feb 25, 2020
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
reviewed
Feb 26, 2020
joshdover
force-pushed
the
np/request-mock-validation
branch
from
February 26, 2020 17:42
e8d0844
to
0de7e33
Compare
mshustov
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering how many ppl will define validation in tests at all 😄 probably schema.any would be enough
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
Feb 26, 2020
joshdover
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:New Platform
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #51919 we started allowing request input fields to be of any shape, not just objects. However, we never updated the KibanaRequest mock to allow this.
This PR changes the default validation for the mock to
schema.any()
but allows the consumer to specify custom validation for testing.Checklist
Delete any items that are not applicable to this PR.
For maintainers