Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Ensure inventory view buckets never drop below 60 seconds #58503

Merged
merged 10 commits into from
Feb 27, 2020
Merged

[Metrics UI] Ensure inventory view buckets never drop below 60 seconds #58503

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
31601cb
[Metrics UI] Ensure inventory view buckets never drop below 60 seconds
simianhacker Feb 25, 2020
30c9c2d
Fixing tests
simianhacker Feb 25, 2020
17a09e9
Merge branch 'master' of github.com:elastic/kibana into issue-58494
simianhacker Feb 26, 2020
76ce0d2
Fixing tests... again
simianhacker Feb 26, 2020
309c313
Merge branch 'master' of github.com:elastic/kibana into issue-58494
simianhacker Feb 26, 2020
0096e3f
Merge branch 'master' into issue-58494
elasticmachine Feb 26, 2020
13347c1
Fixing tests... rounding issue?
simianhacker Feb 26, 2020
b21849e
Trying to fix the tests... again
simianhacker Feb 26, 2020
a7464d8
Merge branch 'master' of github.com:elastic/kibana into issue-58494
simianhacker Feb 26, 2020
7bdf2d7
updating test for custom metric
simianhacker Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions x-pack/plugins/infra/server/lib/snapshot/create_timerange_with_interval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const createTimeRangeWithInterval = async (
): Promise<InfraTimerangeInput> => {
const aggregations = getMetricsAggregations(options);
const modules = await aggregationsToModules(framework, requestContext, aggregations, options);
const interval =
const interval = Math.max(
(await calculateMetricInterval(
framework,
requestContext,
Expand All @@ -32,7 +32,9 @@ export const createTimeRangeWithInterval = async (
},
modules,
options.nodeType
)) || 60000;
)) || 60,
60
);
return {
interval: `${interval}s`,
from: options.timerange.to - interval * 5000, // We need at least 5 buckets worth of data
Expand Down