Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add Homebrew start + stop instructions for Kibana #58495

Merged
merged 5 commits into from
Feb 26, 2020
Merged

[DOCS] Add Homebrew start + stop instructions for Kibana #58495

merged 5 commits into from
Feb 26, 2020

Conversation

justinjunodev
Copy link
Contributor

@justinjunodev justinjunodev commented Feb 25, 2020 •
edited by gchaps
Loading

Summary

As mentioned in #58413 , the current documentation does not include instructions for starting and stopping Kibana with Homebrew.

This information is provided for all of the previous installation types in the setup guide and would be useful to include them here. Not only to follow suit, but to hopefully help other developers using this formulae get started with Kibana.

This is my first contribution to Elastic, so if anyone on the team would like to make and/or request additional edits, please do so. Thanks for time, consideration, and support! ♥️

Checklist

For maintainers

[skip ci]

Closes #58413

@justinjunodev justinjunodev changed the title add brew start and stop instructions to docs [DOCS] Add Homebrew start + stop instructions for Kibana Feb 25, 2020
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 25, 2020 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@justinjunodev
Copy link
Contributor Author

Agreement has been signed, if I need to do anything else to help the process run more smoothly, let me know. Thanks! 🤓

@KOTungseth KOTungseth added the release_note:skip Skip the PR/issue when compiling release notes label Feb 25, 2020
KOTungseth
KOTungseth approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much for making this change :)

@KOTungseth
Copy link
Contributor

@elasticmachine merge upstream

@timroes
Copy link
Contributor

timroes commented Feb 25, 2020

Jenkins, test this

@gchaps
Copy link
Contributor

gchaps commented Feb 25, 2020

run elasticsearch-ci/docs

@spalger
Copy link
Contributor

spalger commented Feb 26, 2020

@elasticmachine merge upstream

@gchaps
Copy link
Contributor

gchaps commented Feb 26, 2020

run elasticsearch-ci/docs

gchaps
gchaps reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinjunodev Assuming you want this content to appear on the Start and Stop page (instead of on its own page), I left some comments on how you can achieve this.

docs/setup/start-stop.asciidoc Show resolved Hide resolved
docs/setup/start-stop.asciidoc Show resolved Hide resolved
@justinjunodev
Copy link
Contributor Author

Thanks @gchaps, these should be resolved now. I haven't done anything with asciidocs before, so good catch.

@gchaps
Copy link
Contributor

gchaps commented Feb 26, 2020

run elasticsearch-ci/docs

@gchaps gchaps merged commit 4b8b9a4 into elastic:master Feb 26, 2020
@gchaps gchaps mentioned this pull request Feb 26, 2020
Merged
gchaps pushed a commit to gchaps/kibana that referenced this pull request Feb 26, 2020
@justinjunodev @elasticmachine @gchaps
[DOCS] Add Homebrew start + stop instructions for Kibana (elastic#58495)
db4bbb3 
* add brew start and stop instructions to docs

* add float to start-stop doc

* Update start-stop.asciidoc

Co-authored-by: Elastic Machine <[email protected]>
gchaps added a commit that referenced this pull request Feb 26, 2020
@gchaps @justinjunodev @elasticmachine
[DOCS] Add Homebrew start + stop instructions for Kibana (#58495) (#5…
ebb04c7 
…8609)

* add brew start and stop instructions to docs

* add float to start-stop doc

* Update start-stop.asciidoc

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Justin Juno <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@gchaps
Copy link
Contributor

gchaps commented Feb 26, 2020

@justinjunodev Thanks for helping out. Check out:

https://www.elastic.co/guide/en/kibana/master/start-stop.html
https://www.elastic.co/guide/en/kibana/7.x/start-stop.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@KOTungseth KOTungseth KOTungseth approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Operations Team label for Operations Team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Add Homebrew Start & Stop Instructions
8 participants
@justinjunodev @kibanamachine @elasticmachine @KOTungseth @timroes @gchaps @spalger @tylersmalley