Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Improve duration chart #58404
[Uptime] Improve duration chart #58404
Changes from all commits
76dea0c
7db5295
b0bd131
251941b
448bcd8
03e130e
646570e
be5cbe9
0170326
b50c13b
a582794
9076614
95bcf79
c59c7c9
1c4f888
e38f108
0ddf071
e188a9e
ca7782f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinkambic using hooks redux becomes much cleaner and simple. At least the connect part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ was just thinking that to myself. I have never used the hooks before; does this mean...
...is effectively
mapStateToProps
? And we could use multiple selectors if needed to get the state we want, instead of doing it in a function we'd pass toconnect
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you can use as many selectors as you like.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.