Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Fix license check. #58343

Merged
merged 2 commits into from
Feb 24, 2020
Merged

[ML] Transforms: Fix license check. #58343

merged 2 commits into from
Feb 24, 2020

Conversation

walterra
Copy link
Contributor

Summary

Fixes an error where the transforms page would load blank with an expired license. Fixes the issue by adding a type guard. With an expired license, the page now renders again correctly the error message.

Checklist

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience release_note:fix :ml v8.0.0 Feature:Transforms ML transforms v7.7.0 labels Feb 24, 2020
@walterra walterra requested a review from a team as a code owner February 24, 2020 14:01
@walterra walterra self-assigned this Feb 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@walterra
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit b88b991 into elastic:master Feb 24, 2020
@walterra walterra deleted the ml-fix-license-check branch February 24, 2020 17:44
@walterra walterra mentioned this pull request Feb 24, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Feb 24, 2020
@walterra
[ML] Fix transforms license check. (elastic#58343)
063830e 
Fixes an error where the transforms page would load blank with an expired license. Fixes the issue by adding a type guard. With an expired license, the page now renders again correctly the error message.
walterra added a commit that referenced this pull request Feb 24, 2020
@walterra
[ML] Fix transforms license check. (#58343) (#58381)
7ada510 
Fixes an error where the transforms page would load blank with an expired license. Fixes the issue by adding a type guard. With an expired license, the page now renders again correctly the error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml release_note:fix v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson