Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Case] Comments to case view #58315

Merged
merged 66 commits into from
Mar 2, 2020
Merged

[SIEM] [Case] Comments to case view #58315

merged 66 commits into from
Mar 2, 2020

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Feb 23, 2020 •
edited
Loading

This PR:

  1. comments now in the case view
  2. add a comment (waiting on API update to show in list without page refresh)
  3. edit a comment
  4. New style for markdown component
  5. New component for FormattedRelativePreferenceLabel
  6. version and no update string checking added to the update_comment api
  7. took updating description logic out of case_view and into user_action_tree
  8. Translation update of "Case" to "Cases"
  9. Update style of create case
  10. Add cancel button to create case
  11. loading states for updating fields
  12. update Tags and titles button styling

post_comment

update_comment

create

title

tags

Issues remaining on Case View:

stephmilovic and others added 30 commits February 18, 2020 10:28
@stephmilovic
init commit, enable case by default and snake to camel on the FE
0984382
@stephmilovic
fix sorting
36a8cbc
@stephmilovic
add a couple tests
a2576ea
@stephmilovic
mock timezone
3414641
@stephmilovic
full_name to fullName and tests for case view
7d2818a
@stephmilovic
update case
9de2163
@stephmilovic
trying to fix time test
9bf863a
@stephmilovic
attempt to fix test once more
87933b5
@stephmilovic
comment out bad test
4247111
@stephmilovic
comment out bad test
6764017
@stephmilovic
remove snapshot tests
4d5b84d
@stephmilovic
fix
b938feb
@stephmilovic
rm thing
fb158d1
@stephmilovic
simplify
a51c776
@elasticmachine
Merge branch 'master' into case-cleanups
1147b7d
@stephmilovic
comments to case view
932a210
@stephmilovic
fix up
c589dce
@stephmilovic
Merge branch 'master' into case-cleanups
473322d
@stephmilovic
Merge branch 'master' into comments-to-case-view
3da9bda
@stephmilovic
add comment work
5f6fed5
@stephmilovic
remove window.alert
e28d322
@stephmilovic
suggested changes
0d68fde
@stephmilovic
more fixes
388d77d
@stephmilovic
better types
fb92e30
@stephmilovic
something fishy
9df35a6
@stephmilovic
couple quick cleanups, lodash arg order incorrect on set
b76038e
@stephmilovic
get changes from case-cleanups
c2f680a
@stephmilovic
merge master, convertArrayToCamelCase
bba7d6d
@stephmilovic
fix merge conflict
d672967
@stephmilovic
md editor looking better and posting
80961e0
XavierM
XavierM reviewed Feb 27, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the form isValid, I think that I have an idea, I will push some code somewhere to show you.
check this commit

Also when I tested the creation of case the spinner was not on top of the form and I was able to modify the fields during the saving.

@stephmilovic
Copy link
Contributor Author

Also when I tested the creation of case the spinner was not on top of the form and I was able to modify the fields during the saving.

This is resolved @XavierM

stephmilovic
stephmilovic commented Feb 28, 2020
View reviewed changes
x-pack/legacy/plugins/siem/public/pages/case/components/user_action_tree/index.tsx
data-test-subj={`user-action-avatar`}
className="userAction__circle"
name={avatarName}
<UserAction data-test-subj="user-action-description" gutterSize={'none'}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierM LGTM 🚀

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@mistic
Copy link
Member

mistic commented Mar 2, 2020

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 90b3678 into elastic:master Mar 2, 2020
@stephmilovic stephmilovic mentioned this pull request Mar 2, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 2, 2020
@stephmilovic
[SIEM] [Case] Comments to case view (elastic#58315)
403427c
@stephmilovic stephmilovic deleted the comments-to-case-view branch March 2, 2020 23:23
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 3, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
5184196 
* master: (26 commits)
  [Endpoint] Alert Details Overview (elastic#58412)
  Service map language icons (elastic#58633)
  [SIEM] [Case] Comments to case view (elastic#58315)
  Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775)
  [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627)
  Dashboard a11y tests (elastic#58122)
  Downgrade "setting up plugin" log to debug (elastic#58776)
  [CI] Pipeline refactoring (elastic#56447)
  [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511)
  put params into short url instead of behind it (elastic#58846)
  show timepicker in timelion and tsvb (elastic#58857)
  improve graph missing workspace error message (elastic#58876)
  [Maps] direct Discover "visualize" to open Maps application (elastic#58549)
  Disallow duplicate percentiles (elastic#57444) (elastic#58299)
  removing references to visTypes uiExports (elastic#58337)
  [SIEM] Default the Timeline events filter to show All events (elastic#58953)
  [Remote clusters] Add indexManagement as required plugin (elastic#58915)
  [DOCS] Rework of main get started page (elastic#58260)
  [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348)
  [Endpoint] add resolver middleware (elastic#58288)
  ...
stephmilovic added a commit that referenced this pull request Mar 3, 2020
@stephmilovic
[7.x] [SIEM] [Case] Comments to case view (#58315) (#59098)
5c8e98a
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 3, 2020
@gmmorris
Merge branch 'alerting/fix-flaky-instance-test' of github.com:gmmorri…
9e9eece 
…s/kibana into alerting/fix-flaky-instance-test

* 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana:
  [Endpoint] Alert Details Overview (elastic#58412)
  Service map language icons (elastic#58633)
  [SIEM] [Case] Comments to case view (elastic#58315)
  Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775)
  [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@MichaelMarcialis MichaelMarcialis Awaiting requested review from MichaelMarcialis

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephmilovic @elasticmachine @mistic @kibanamachine @XavierM