Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to standard ESS trial links #58309

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Switch to standard ESS trial links #58309

merged 2 commits into from
Feb 26, 2020

Conversation

nrichers
Copy link

@nrichers nrichers commented Feb 22, 2020 •
edited by KOTungseth
Loading

Summary

This PR switches trial sign-up links over to the standard attribute we're introducing that should provide some metrics for how effective these links are.

Details for the attribute are in elastic/docs#1737, if you want to know more.

@gchaps @KOTungseth if you could review this PR, I would be grateful. I'd also appreciate any pointers you have for getting these changes into all the right branches.

[skip ci]

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@kibanamachine
Copy link
Contributor

💔 Build Failed

Test Failures

Kibana Pipeline / kibana-intake-agent / Jest Tests.packages/kbn-plugin-generator/sao_template.plugin generator sao integration skips files when answering no

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/58250

Stack Trace

Error: expect(received).toBe(expected) // Object.is equality

Expected: "/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-optimizer/target/.bootstrap-cache"
Received: "/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-plugin-generator/sao_template/template/common/index.ts"
    at jest.requireMock.readFile.mockImplementation (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-optimizer/src/optimizer/cache_keys.test.ts:60:20)
    at finalReturnValue (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:480:41)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:489:13
    at mockConstructor (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:182:19)
    at go$readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/graceful-fs/graceful-fs.js:110:14)
    at Object.readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/graceful-fs/graceful-fs.js:107:12)
    at Promise (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/universalify/index.js:13:12)
    at new Promise (<anonymous>)
    at Object.readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/universalify/index.js:7:14)
    at Promise.all.paths.map.relative (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:47:17)
    at Array.map (<anonymous>)
    at Majo.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:45:29)
    at Generator.next (<anonymous>)
    at c (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:10:99)
Kibana Pipeline / kibana-intake-agent / Jest Tests.packages/kbn-plugin-generator/sao_template.plugin generator sao integration includes app when answering yes

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/58251

Stack Trace

Error: expect(received).toBe(expected) // Object.is equality

Expected: "/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-optimizer/target/.bootstrap-cache"
Received: "/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-plugin-generator/sao_template/template/common/index.ts"
    at jest.requireMock.readFile.mockImplementation (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-optimizer/src/optimizer/cache_keys.test.ts:60:20)
    at finalReturnValue (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:480:41)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:489:13
    at mockConstructor (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:182:19)
    at go$readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/graceful-fs/graceful-fs.js:110:14)
    at Object.readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/graceful-fs/graceful-fs.js:107:12)
    at Promise (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/universalify/index.js:13:12)
    at new Promise (<anonymous>)
    at Object.readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/universalify/index.js:7:14)
    at Promise.all.paths.map.relative (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:47:17)
    at Array.map (<anonymous>)
    at Majo.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:45:29)
    at Generator.next (<anonymous>)
    at c (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:10:99)
Kibana Pipeline / kibana-intake-agent / Jest Tests.packages/kbn-plugin-generator/sao_template.plugin generator sao integration includes server api when answering yes

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/58252

Stack Trace

Error: expect(received).toBe(expected) // Object.is equality

Expected: "/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-optimizer/target/.bootstrap-cache"
Received: "/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-plugin-generator/sao_template/template/common/index.ts"
    at jest.requireMock.readFile.mockImplementation (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/packages/kbn-optimizer/src/optimizer/cache_keys.test.ts:60:20)
    at finalReturnValue (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:480:41)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:489:13
    at mockConstructor (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-mock/build/index.js:182:19)
    at go$readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/graceful-fs/graceful-fs.js:110:14)
    at Object.readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/graceful-fs/graceful-fs.js:107:12)
    at Promise (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/universalify/index.js:13:12)
    at new Promise (<anonymous>)
    at Object.readFile (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/universalify/index.js:7:14)
    at Promise.all.paths.map.relative (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:47:17)
    at Array.map (<anonymous>)
    at Majo.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:45:29)
    at Generator.next (<anonymous>)
    at c (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/majo/dist/majo.common.js:10:99)

and 9 more failures, only showing the first 3.

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timroes timroes mentioned this pull request Feb 24, 2020
Closed
KOTungseth
KOTungseth approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KOTungseth
Copy link
Contributor

@elasticmachine merge upstream

@KOTungseth KOTungseth added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 labels Feb 24, 2020
@nrichers nrichers merged commit e48483d into elastic:master Feb 26, 2020
This was referenced Feb 26, 2020
Merged
Merged
nrichers pushed a commit to nrichers/kibana that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (elastic#58309)
f78daa5 
Co-authored-by: Elastic Machine <[email protected]>
@nrichers nrichers mentioned this pull request Feb 26, 2020
Merged
nrichers pushed a commit to nrichers/kibana that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (elastic#58309)
5237514 
Co-authored-by: Elastic Machine <[email protected]>
@nrichers nrichers mentioned this pull request Feb 26, 2020
Merged
nrichers pushed a commit to nrichers/kibana that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (elastic#58309)
b93d8ed 
Co-authored-by: Elastic Machine <[email protected]>
@nrichers nrichers mentioned this pull request Feb 26, 2020
Merged
nrichers pushed a commit to nrichers/kibana that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (elastic#58309)
23069ab 
Co-authored-by: Elastic Machine <[email protected]>
nrichers pushed a commit to nrichers/kibana that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (elastic#58309)
0de53ca 
Co-authored-by: Elastic Machine <[email protected]>
@nrichers nrichers mentioned this pull request Feb 26, 2020
Merged
nrichers pushed a commit that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (#58309) (#58659)
b59bd97 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
nrichers pushed a commit that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (#58309) (#58660)
e49bb16 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
nrichers pushed a commit that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (#58309) (#58661)
d745aa4 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
nrichers pushed a commit that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (#58309) (#58663)
346c0cc 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
nrichers pushed a commit that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (#58309) (#58664)
bfebf79 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
nrichers pushed a commit that referenced this pull request Feb 26, 2020
@elasticmachine
Switch to standard ESS trial attribute (#58309) (#58666)
391ef0b 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOTungseth KOTungseth KOTungseth approved these changes

@gchaps gchaps Awaiting requested review from gchaps

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.5.0 v7.6.0 v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrichers @elasticmachine @kibanamachine @KOTungseth