[Bug fix] Update nav link when it belongs to the same plugin #58008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-lapata
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
approved these changes
Feb 19, 2020
maryia-lapata
changed the title
flash1293
reviewed
Feb 20, 2020
src/plugins/kibana_utils/public/state_management/url/kbn_url_tracker.ts
Outdated
Show resolved
Hide resolved
flash1293
reviewed
Feb 20, 2020
src/plugins/kibana_utils/public/state_management/url/kbn_url_tracker.ts
Outdated
Show resolved
Hide resolved
flash1293
reviewed
Feb 20, 2020
flash1293
reviewed
Feb 20, 2020
src/plugins/kibana_utils/public/state_management/url/kbn_url_tracker.ts
Outdated
Show resolved
Hide resolved
maryia-lapata
changed the title
maryia-lapata
changed the title
Dosant
reviewed
Feb 21, 2020
| @@ -58,6 +58,12 @@ export function createKbnUrlTracker({ | |||
| toastNotifications, | |||
| history, | |||
| storage, | |||
| shouldTrackUrlUpdate = pathname => { | |||
| const currentAppName = defaultSubUrl.slice(2); // cut hash and slash symbols | |||
There was a problem hiding this comment.
Makes me realize that kbn_url_tracker works only for current Kibana's url format and hash router. Will need to revisit when / if someone wants to use it in np app with browser router
There was a problem hiding this comment.
That's true, I didn't want to introduce too many degrees on freedom on this helper just yet to keep the complexity low. Let's generalize once there are use cases for this
flash1293
approved these changes
Feb 21, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
maryia-lapata
added a commit
to maryia-lapata/kibana
that referenced
this pull request
Feb 24, 2020
…#58008) * Update nav link when it belongs to the same plugin * Move the plugin name check to history listener * Add isUrlBelongsToApp function * Code review comments * Update unit tests Co-authored-by: Elastic Machine <[email protected]>
maryia-lapata
added a commit
that referenced
this pull request
Feb 24, 2020
…#58326) * Update nav link when it belongs to the same plugin * Move the plugin name check to history listener * Add isUrlBelongsToApp function * Code review comments * Update unit tests Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57573
When a user navigates to dashboard, there is a verification if a default index pattern exists; if it doesn't, the app is redirected to management. But dashboard's KbnUrlTracker has been already created and the dashboard app has been mounted, which means that dashboard has subscribed on history url changes. Meanwhile the app is going to management -> the url is changed and dashboard's history listener is invoked with management url, which is led to the original issue. And only after that the app scope is destroyed and the dashboard unsubscribes to history changes.
To fix the issue I added a condition, whether a url belongs to the current app, to the history listener. This condition can be customized by
shouldTrackUrlUpdatecustom implementation.