Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace heart script with smiley face script. #57755

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

cjcenizal
Copy link
Contributor

The original heart script was under copyright so we need to replace it with something else. @kertal @jloleysens WDYT? :) I think this is an improvement in some ways because we're showcasing how to access an API (Math) and the code is easier to understand.

image

@cjcenizal cjcenizal added Feature:Dev Tools painless painless Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Feb 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal cjcenizal mentioned this pull request Feb 15, 2020
13 tasks
@kibanamachine
Copy link
Contributor

💔 Build Failed


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management home

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 12 times on tracked branches: https://github.com/elastic/kibana/issues/57377

[00:00:00]       │
[00:00:00]         └-: Advanced Settings
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: security feature controls
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook
[00:00:00]               │ info [empty_kibana] Loading "mappings.json"
[00:00:00]               │ info [empty_kibana] Loading "data.json.gz"
[00:00:00]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_1/E70vN9RsRtaLRM051B89mA] deleting index
[00:00:00]               │ info [empty_kibana] Deleted existing index [".kibana_1"]
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:00]               │ info [empty_kibana] Created index ".kibana"
[00:00:00]               │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:00]               │ info [empty_kibana] Indexed 2 docs into ".kibana"
[00:00:45]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana/8doV2Kv0QSypdgUOdKzuSw] update_mapping [_doc]
[00:00:48]               │ info Creating index .kibana_2.
[00:00:48]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:48]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:48]               │ info Reindexing .kibana to .kibana_1
[00:00:48]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:48]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:48]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1], mappings [_doc]
[00:00:48]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] updating number_of_replicas to [0] for indices [.tasks]
[00:00:48]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] 806 finished with response BulkByScrollResponse[took=56.7ms,timed_out=false,sliceId=null,updated=0,created=4,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:49]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana/8doV2Kv0QSypdgUOdKzuSw] deleting index
[00:00:49]               │ info Migrating .kibana_1 saved objects to .kibana_2
[00:00:49]               │ debg Migrating saved objects config:6.0.0-alpha1, space:default, maps-telemetry:maps-telemetry, config:8.0.0-SNAPSHOT
[00:00:49]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2/nsPhf0pmSTuexH_ssmvgaQ] update_mapping [_doc]
[00:00:49]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2/nsPhf0pmSTuexH_ssmvgaQ] update_mapping [_doc]
[00:00:49]               │ info Pointing alias .kibana to .kibana_2.
[00:00:49]               │ info Finished in 1009ms.
[00:00:49]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:49]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2/nsPhf0pmSTuexH_ssmvgaQ] update_mapping [_doc]
[00:02:48]             └-: no advanced_settings privileges
[00:02:48]               └-> "before all" hook
[00:02:48]               └-> "before all" hook
[00:02:48]                 │ debg creating role no_advanced_settings_privileges_role
[00:02:48]                 │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] added role [no_advanced_settings_privileges_role]
[00:02:48]                 │ debg created role no_advanced_settings_privileges_role
[00:02:48]                 │ debg creating user no_advanced_settings_privileges_user
[00:02:48]                 │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] added user [no_advanced_settings_privileges_user]
[00:02:48]                 │ debg created user no_advanced_settings_privileges_user
[00:02:48]                 │ debg navigating to login url: http://localhost:6131/login
[00:02:48]                 │ debg Navigate to: http://localhost:6131/login
[00:02:48]                 │ proc [kibana]   log   [19:46:54.357] [info][authentication][plugins][security] Authentication attempt failed: [security_exception] unable to authenticate user [global_advanced_settings_read_user] for REST request [/_security/_authenticate], with { header={ WWW-Authenticate="Basic realm=\"security\" charset=\"UTF-8\"" } }
[00:02:49]                 │ debg ... sleep(700) start
[00:02:49]                 │ERROR browser[SEVERE] http://localhost:6131/ - Failed to load resource: the server responded with a status of 401 (Unauthorized)
[00:02:49]                 │ debg ... sleep(700) end
[00:02:49]                 │ debg returned from get, calling refresh
[00:02:49]                 │ debg browser[INFO] http://localhost:6131/login?next=%2F 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:49]                 │
[00:02:49]                 │ debg browser[INFO] http://localhost:6131/bundles/app/login/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:49]                 │ debg currentUrl = http://localhost:6131/login?next=%2F
[00:02:49]                 │          appUrl = http://localhost:6131/login
[00:02:49]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:54]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-15T19:46:59Z
[00:02:54]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:02:54]                 │
[00:02:54]                 │      "
[00:02:54]                 │ debg browser[INFO] http://localhost:6131/bundles/commons.bundle.js 2:7721729 "use this to figure out whether we should register" false
[00:02:54]                 │ debg ... sleep(501) start
[00:02:55]                 │ debg ... sleep(501) end
[00:02:55]                 │ debg in navigateTo url = http://localhost:6131/login?next=%2F#/
[00:02:55]                 │ debg TestSubjects.exists(statusPageContainer)
[00:02:55]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:02:57]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:02:58]                 │ debg TestSubjects.setValue(loginUsername, no_advanced_settings_privileges_user)
[00:02:58]                 │ debg TestSubjects.click(loginUsername)
[00:02:58]                 │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:02:58]                 │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:02:58]                 │ debg TestSubjects.setValue(loginPassword, no_advanced_settings_privileges_user-password)
[00:02:58]                 │ debg TestSubjects.click(loginPassword)
[00:02:58]                 │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:02:58]                 │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:02:59]                 │ debg TestSubjects.click(loginSubmit)
[00:02:59]                 │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:02:59]                 │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:02:59]                 │ debg Waiting up to 20000ms for logout button visible...
[00:02:59]                 │ debg TestSubjects.exists(userMenuButton)
[00:02:59]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:03:02]                 │ debg browser[INFO] http://localhost:6131/app/kibana#/ 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:02]                 │
[00:03:02]                 │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:02]                 │ debg --- retry.tryForTime error: [data-test-subj="userMenuButton"] is not displayed
[00:03:03]                 │ debg TestSubjects.exists(userMenuButton)
[00:03:03]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:03:06]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-15T19:47:10Z
[00:03:06]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:03:06]                 │
[00:03:06]                 │      "
[00:03:06]                 │ debg browser[INFO] http://localhost:6131/bundles/commons.bundle.js 2:7721729 "use this to figure out whether we should register" false
[00:03:06]                 │ debg TestSubjects.exists(userMenu)
[00:03:06]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:03:08]                 │ debg --- retry.tryForTime error: [data-test-subj="userMenu"] is not displayed
[00:03:09]                 │ debg TestSubjects.click(userMenuButton)
[00:03:09]                 │ debg Find.clickByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:03:09]                 │ debg Find.findByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:03:09]                 │ debg Waiting up to 20000ms for user menu opened...
[00:03:09]                 │ debg TestSubjects.exists(userMenu)
[00:03:09]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:03:09]                 │ debg TestSubjects.exists(userMenu > logoutLink)
[00:03:09]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"] [data-test-subj="logoutLink"]') with timeout=2500
[00:03:09]               └-> shows Management navlink
[00:03:09]                 └-> "before each" hook: global before each
[00:03:09]                 │ debg TestSubjects.find(navDrawer)
[00:03:09]                 │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:03:09]                 └- ✓ pass  (31ms) "Advanced Settings security feature controls no advanced_settings privileges shows Management navlink"
[00:03:09]               └-> does not allow navigation to advanced settings; redirects to management home
[00:03:09]                 └-> "before each" hook: global before each
[00:03:09]                 │ debg navigateToActualUrl http://localhost:6131/app/kibana#management/kibana/settings
[00:03:09]                 │ debg browser[INFO] http://localhost:6131/app/kibana?_t=1581796034965#management/kibana/settings 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:09]                 │
[00:03:09]                 │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:09]                 │ debg TestSubjects.exists(managementHome)
[00:03:09]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="managementHome"]') with timeout=10000
[00:03:13]                 │ debg --- retry.tryForTime error: [data-test-subj="managementHome"] is not displayed
[00:03:19]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-15T19:47:19Z
[00:03:19]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:03:19]                 │
[00:03:19]                 │      "
[00:03:19]                 │ debg browser[INFO] http://localhost:6131/bundles/commons.bundle.js 2:7721729 "use this to figure out whether we should register" false
[00:03:19]                 │ debg browser[INFO] http://localhost:6131/app/kibana#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:03:19]                 │
[00:03:19]                 │ debg browser[INFO] http://localhost:6131/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:03:19]                 │ debg browser[INFO] http://localhost:6131/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-15T19:47:25Z
[00:03:19]                 │        Adding connection to http://localhost:6131/elasticsearch
[00:03:19]                 │
[00:03:19]                 │      "
[00:03:19]                 │ debg --- retry.tryForTime failed again with the same message...
[00:03:20]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings_ redirects to management home.png"
[00:03:20]                 │ debg browser[INFO] http://localhost:6131/bundles/commons.bundle.js 2:7721729 "use this to figure out whether we should register" false
[00:03:21]                 │ info Current URL is: http://localhost:6131/app/kibana#/management?_g=()
[00:03:21]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings_ redirects to management home.html
[00:03:22]                 └- ✖ fail: "Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management home"
[00:03:22]                 │

Stack Trace

Error: expected testSubject(managementHome) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/index_patterns/feature_controls/index_patterns_spaces·ts.Index Patterns feature controls spaces space with Index Patterns disabled redirects to Kibana home

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/57601

[00:00:00]       │
[00:20:52]         └-: Index Patterns
[00:20:52]           └-> "before all" hook
[00:20:52]           └-: feature controls
[00:20:52]             └-> "before all" hook
[00:22:57]             └-: spaces
[00:22:57]               └-> "before all" hook
[00:22:57]               └-> "before all" hook
[00:22:57]                 │ info [logstash_functional] Loading "mappings.json"
[00:22:57]                 │ info [logstash_functional] Loading "data.json.gz"
[00:22:57]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:22:57]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:22:57]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:24:21]               └-: space with Index Patterns disabled
[00:24:21]                 └-> "before all" hook
[00:24:21]                 └-> "before all" hook
[00:24:21]                   │ info [empty_kibana] Loading "mappings.json"
[00:24:21]                   │ info [empty_kibana] Loading "data.json.gz"
[00:24:21]                   │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2/0dI2i6XtT1iyzVmi_ohfCw] deleting index
[00:24:21]                   │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_1/fL0tIb8DTUGCjH3425mslQ] deleting index
[00:24:21]                   │ info [empty_kibana] Deleted existing index [".kibana_2",".kibana_1"]
[00:24:21]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:24:21]                   │ info [empty_kibana] Created index ".kibana"
[00:24:21]                   │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:24:21]                   │ info [empty_kibana] Indexed 2 docs into ".kibana"
[00:24:22]                   │ info Creating index .kibana_2.
[00:24:22]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:24:22]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] updating number_of_replicas to [0] for indices [.kibana_2]
[00:24:23]                   │ info Reindexing .kibana to .kibana_1
[00:24:23]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:24:23]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] updating number_of_replicas to [0] for indices [.kibana_1]
[00:24:23]                   │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] 27237 finished with response BulkByScrollResponse[took=39.2ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:24:23]                   │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana/KeVwhBnuS1qsTCoIgJP8CA] deleting index
[00:24:23]                   │ info Migrating .kibana_1 saved objects to .kibana_2
[00:24:23]                   │ debg Migrating saved objects config:6.0.0-alpha1, space:default
[00:24:23]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2/DXdF3hEPQuOUhiGtWJMJgw] update_mapping [_doc]
[00:24:23]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2/DXdF3hEPQuOUhiGtWJMJgw] update_mapping [_doc]
[00:24:23]                   │ info Pointing alias .kibana to .kibana_2.
[00:24:23]                   │ info Finished in 660ms.
[00:24:23]                   │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:24:24]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1581793274569309707] [.kibana_2/DXdF3hEPQuOUhiGtWJMJgw] update_mapping [_doc]
[00:24:25]                   │ debg creating space
[00:24:26]                   │ debg created space
[00:24:26]                 └-> redirects to Kibana home
[00:24:26]                   └-> "before each" hook: global before each
[00:24:26]                   │ debg navigateToActualUrl http://localhost:6131/s/custom_space/app/kibana#management/kibana/index_patterns
[00:24:27]                   │ debg browser[INFO] http://localhost:6131/s/custom_space/app/kibana?_t=1581797665397#management/kibana/index_patterns 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:24:27]                   │
[00:24:27]                   │ debg browser[INFO] http://localhost:6131/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:24:27]                   │ debg TestSubjects.exists(homeApp)
[00:24:27]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="homeApp"]') with timeout=10000
[00:24:30]                   │ debg --- retry.tryForTime error: [data-test-subj="homeApp"] is not displayed
[00:24:36]                   │ debg browser[INFO] http://localhost:6131/s/custom_space/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-15T20:14:34Z
[00:24:36]                   │        Adding connection to http://localhost:6131/s/custom_space/elasticsearch
[00:24:36]                   │
[00:24:36]                   │      "
[00:24:36]                   │ debg browser[INFO] http://localhost:6131/bundles/commons.bundle.js 2:7721729 "use this to figure out whether we should register" false
[00:24:36]                   │ debg --- retry.tryForTime failed again with the same message...
[00:24:37]                   │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Index Patterns feature controls spaces space with Index Patterns disabled redirects to Kibana home.png"
[00:24:37]                   │ info Current URL is: http://localhost:6131/s/custom_space/app/kibana#/home
[00:24:38]                   │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Index Patterns feature controls spaces space with Index Patterns disabled redirects to Kibana home.html
[00:24:38]                   └- ✖ fail: "Index Patterns feature controls spaces space with Index Patterns disabled redirects to Kibana home"
[00:24:38]                   │

Stack Trace

Error: expected testSubject(homeApp) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)

Kibana Pipeline / kibana-oss-agent / Firefox UI Functional Tests.test/functional/apps/visualize/_tsvb_chart·ts.visualize app visual builder "before each" hook for "should verify gauge label and count display"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/57623

[00:00:00]       │
[00:26:53]         └-: visualize app
[00:26:53]           └-> "before all" hook
[00:26:53]           └-> "before all" hook
[00:26:53]             │ debg Starting visualize before method
[00:26:53]             │ info [logstash_functional] Loading "mappings.json"
[00:26:53]             │ info [logstash_functional] Loading "data.json.gz"
[00:26:53]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:26:53]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:26:53]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:26:53]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:26:53]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:26:53]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:26:53]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:26:53]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:26:53]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:27:03]             │ info [logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:27:03]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:27:03]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:27:03]             │ info [long_window_logstash] Loading "mappings.json"
[00:27:03]             │ info [long_window_logstash] Loading "data.json.gz"
[00:27:03]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [long-window-logstash-0] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:27:03]             │ info [long_window_logstash] Created index "long-window-logstash-0"
[00:27:03]             │ debg [long_window_logstash] "long-window-logstash-0" settings {"index":{"analysis":{"analyzer":{"makelogs_url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:27:13]             │ info progress: 12944
[00:27:14]             │ info [long_window_logstash] Indexed 14005 docs into "long-window-logstash-0"
[00:27:15]             │ info [visualize] Loading "mappings.json"
[00:27:15]             │ info [visualize] Loading "data.json"
[00:27:15]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:27:15]             │ info [visualize] Created index ".kibana"
[00:27:15]             │ debg [visualize] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:27:15]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana/Qd-c17ARRQSgaqjOowvXTA] update_mapping [_doc]
[00:27:15]             │ info [visualize] Indexed 7 docs into ".kibana"
[00:27:16]             │ info Creating index .kibana_2.
[00:27:16]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:27:16]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] updating number_of_replicas to [0] for indices [.kibana_2]
[00:27:16]             │ info Reindexing .kibana to .kibana_1
[00:27:16]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:27:16]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] updating number_of_replicas to [0] for indices [.kibana_1]
[00:27:16]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] 18438 finished with response BulkByScrollResponse[took=32.7ms,timed_out=false,sliceId=null,updated=0,created=7,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:27:16]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana/Qd-c17ARRQSgaqjOowvXTA] deleting index
[00:27:16]             │ info Migrating .kibana_1 saved objects to .kibana_2
[00:27:16]             │ debg Migrating saved objects index-pattern:logstash-*, index-pattern:logstash*, index-pattern:long-window-logstash-*, visualization:Shared-Item-Visualization-AreaChart, visualization:68305470-87bc-11e9-a991-3b492a7c3e09, visualization:64983230-87bf-11e9-a991-3b492a7c3e09, visualization:5d2de430-87c0-11e9-a991-3b492a7c3e09
[00:27:16]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana_2/EGxqBNHoRbS7cIvvwutP6g] update_mapping [_doc]
[00:27:16]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana_2/EGxqBNHoRbS7cIvvwutP6g] update_mapping [_doc]
[00:27:16]             │ info Pointing alias .kibana to .kibana_2.
[00:27:16]             │ info Finished in 463ms.
[00:27:16]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:27:17]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana_2/EGxqBNHoRbS7cIvvwutP6g] update_mapping [_doc]
[00:27:18]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*","format:bytes:defaultPattern":"0,0.[000]b"}
[00:27:18]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xl-1581793413035538363] [.kibana_2/EGxqBNHoRbS7cIvvwutP6g] update_mapping [_doc]
[00:35:29]           └-: 
[00:35:29]             └-> "before all" hook
[00:35:29]             └-: visual builder
[00:35:29]               └-> "before all" hook

Stack Trace

Error: retry.tryForTime timeout: Error: retry.try timeout: TimeoutError: Timeout loading page after 300000ms
    at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:550:15)
    at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:563:13)
    at Executor.execute (node_modules/selenium-webdriver/lib/http.js:489:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

and 4 more failures, only showing the first 3.

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, 😄, we can change it to a ASCII art Mona Lisa at a later stage

@cjcenizal
Copy link
Contributor Author

You mean to say you don’t think this masterpiece belongs in the Louvre??

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes! Although, I think a pair of sunnies could also be a Painless flavour win 😎

@kertal
Copy link
Member

kertal commented Feb 18, 2020

You mean to say you don’t think this masterpiece belongs in the Louvre??

Au contraire, au contraire!

new-mona taken adapted version of https://commons.wikimedia.org/wiki/File:Crowd_looking_at_the_Mona_Lisa_at_the_Louvre.jpg

@cjcenizal cjcenizal merged commit 9ac62cc into elastic:app/painless Feb 19, 2020
@cjcenizal cjcenizal deleted the painless/smile-script branch February 19, 2020 01:56
cjcenizal added a commit that referenced this pull request Mar 23, 2020
* Create Painless Playground app (#54578)

* Replace heart script with smiley face script. (#57755)

* Rename Painless Playground -> Painless Lab. (#57545)

* Fix i18n namespace.

* Improve smiley face proportions.
- Add def keyword to Painless spec.
- Temporarily fix broken highlighting.
- Add small padding to main controls.

* [Painless Lab] Minor Fixes (#58135)

* Code restructure, improve types, add plugin id, introduced hook

Moved the code execution hook to a custom hook outside of main,
also chaining off promise to avoid lower level handling of
sequencing.

* Re-instated formatting code

To improve DX the execution error response from the painless API
was massaged to a more reader friendly state, only giving non-repeating
information.

Currently it is hard to determine the line and character information from
the painless endpoint. If the user wishes to see this raw information it
will be available in the API response flyout.

* Remove leading new line in default script

* Remove registration of feature flag

* Fix types

* Restore previous auto-submit request behaviour

* Remove use of null and remove old comment

Stick with "undefined" as the designation for something not existing.

* [Painless Lab] NP migration (#59794)

* Fix sample document editor.

* [Painless Lab] Fix float -> integer coercion bug (#60201)

* Clarify data and persistence flow. Fix floating point precision bug.
* Send a string to API and ES client instead of an object.

* Rename helpers lib to format. Add tests for formatRequestPayload.

* Add query parameter to score context (#60414)

* Fix typo and i18n

* Make state init lazy

Otherwise we are needlessly reading and JSON.parse'ing on every
state update

* Support the query parameter in requests to Painless

* Fix borked i18n

* Fix i18n

* Another i18n issue

* [Painless] Minor state update model refactor (#60532)

* Fix typo and i18n

* Make state init lazy

Otherwise we are needlessly reading and JSON.parse'ing on every
state update

* Support the query parameter in requests to Painless

* WiP on state refactor

* Some cleanup after manual testing

* Fix types and i18n

* Fix i18n in context_tab

* i18n

* [Painless] Language Service (#60612)

* Added language service

* Use the correct monaco instance and add wordwise operations

* Remove plugin context initializer for now

* [Painless] Replace hard-coded links (#60603)

* Replace hard-coded links

Also remove all props from Main component

* Pass the new links object to the request flyout too

* Link directly to painless execute API's contexts

* Remove responsive stacking from tabs with icons in them.

* Resize Painless Lab bottom bar to accommodate nav drawer width (#60833)

* Validate Painless Lab index field (#60841)

* Make JSON format of parameters field more prominent. Set default parameters to provide an example to users.
* Set default document to provide an example to users.
* Simplify context's updateState interface.
* Refactor store and context file organization.
  - Remove common directory, move constants and types files to root.
  - Move initialState into context file, where it's being used.
* Add validation for index input.
* Create context directory.

* Fix bottom bar z-index.

* Position flyout help link so it's bottom-aligned with the title and farther from the close button.

Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Jean-Louis Leysens <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Alison Goryachev <[email protected]>
@cjcenizal cjcenizal added the Feature:Painless Lab Dev tool for learning Painless label Mar 23, 2020
cjcenizal added a commit that referenced this pull request Mar 24, 2020
* Create Painless Playground app (#54578)

* Replace heart script with smiley face script. (#57755)

* Rename Painless Playground -> Painless Lab. (#57545)

* Fix i18n namespace.

* Improve smiley face proportions.
- Add def keyword to Painless spec.
- Temporarily fix broken highlighting.
- Add small padding to main controls.

* [Painless Lab] Minor Fixes (#58135)

* Code restructure, improve types, add plugin id, introduced hook

Moved the code execution hook to a custom hook outside of main,
also chaining off promise to avoid lower level handling of
sequencing.

* Re-instated formatting code

To improve DX the execution error response from the painless API
was massaged to a more reader friendly state, only giving non-repeating
information.

Currently it is hard to determine the line and character information from
the painless endpoint. If the user wishes to see this raw information it
will be available in the API response flyout.

* Remove leading new line in default script

* Remove registration of feature flag

* Fix types

* Restore previous auto-submit request behaviour

* Remove use of null and remove old comment

Stick with "undefined" as the designation for something not existing.

* [Painless Lab] NP migration (#59794)

* Fix sample document editor.

* [Painless Lab] Fix float -> integer coercion bug (#60201)

* Clarify data and persistence flow. Fix floating point precision bug.
* Send a string to API and ES client instead of an object.

* Rename helpers lib to format. Add tests for formatRequestPayload.

* Add query parameter to score context (#60414)

* Fix typo and i18n

* Make state init lazy

Otherwise we are needlessly reading and JSON.parse'ing on every
state update

* Support the query parameter in requests to Painless

* Fix borked i18n

* Fix i18n

* Another i18n issue

* [Painless] Minor state update model refactor (#60532)

* Fix typo and i18n

* Make state init lazy

Otherwise we are needlessly reading and JSON.parse'ing on every
state update

* Support the query parameter in requests to Painless

* WiP on state refactor

* Some cleanup after manual testing

* Fix types and i18n

* Fix i18n in context_tab

* i18n

* [Painless] Language Service (#60612)

* Added language service

* Use the correct monaco instance and add wordwise operations

* Remove plugin context initializer for now

* [Painless] Replace hard-coded links (#60603)

* Replace hard-coded links

Also remove all props from Main component

* Pass the new links object to the request flyout too

* Link directly to painless execute API's contexts

* Remove responsive stacking from tabs with icons in them.

* Resize Painless Lab bottom bar to accommodate nav drawer width (#60833)

* Validate Painless Lab index field (#60841)

* Make JSON format of parameters field more prominent. Set default parameters to provide an example to users.
* Set default document to provide an example to users.
* Simplify context's updateState interface.
* Refactor store and context file organization.
  - Remove common directory, move constants and types files to root.
  - Move initialState into context file, where it's being used.
* Add validation for index input.
* Create context directory.

* Fix bottom bar z-index.

* Position flyout help link so it's bottom-aligned with the title and farther from the close button.

Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Jean-Louis Leysens <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Alison Goryachev <[email protected]>

Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Jean-Louis Leysens <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Alison Goryachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dev Tools Feature:Painless Lab Dev tool for learning Painless painless painless release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants