Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix/filter group autocomplete #57686

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fix #57669

Added incremental prop for EuiFieldSearch in Filtergroup, when user type something, it immediately reflects.

@shahzad31 shahzad31 self-assigned this Feb 14, 2020
@shahzad31 shahzad31 added v7.6.0 v8.0.0 v7.7.0 release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability and removed v7.6.0 labels Feb 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic
Copy link
Contributor

LGTM!

I tested this by running the branch and ensuring that incremental typing worked for the items available in the filter groups.

@katrin-freihofner
Copy link
Contributor

Great! Thank you.

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/endpoint/policy_list·ts.endpoint Endpoint Policy List shows policy count total

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:31:45]         └-: endpoint
[00:31:45]           └-> "before all" hook
[00:32:40]           └-: Endpoint Policy List
[00:32:40]             └-> "before all" hook
[00:32:40]             └-> "before all" hook
[00:32:40]               │ debg navigateToActualUrl http://localhost:6171/app/endpoint/policy
[00:32:40]               │ debg browser[INFO] http://localhost:6171/app/endpoint/policy?_t=1582029677451 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:32:40]               │
[00:32:40]               │ debg browser[INFO] http://localhost:6171/bundles/app/core/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:32:40]               │ debg currentUrl = http://localhost:6171/app/endpoint/policy
[00:32:40]               │          appUrl = http://localhost:6171/app/endpoint/policy
[00:32:40]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:32:44]             └-> loads the Policy List Page
[00:32:44]               └-> "before each" hook: global before each
[00:32:44]                 │ debg browser[INFO] http://localhost:6171/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-18T12:41:20Z
[00:32:44]                 │        Adding connection to http://localhost:6171/elasticsearch
[00:32:44]                 │
[00:32:44]                 │      "
[00:32:44]               │ debg TestSubjects.exists(policyListPage)
[00:32:44]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="policyListPage"]') with timeout=120000
[00:32:45]               └- ✓ pass  (836ms) "endpoint Endpoint Policy List loads the Policy List Page"
[00:32:45]             └-> displays page title
[00:32:45]               └-> "before each" hook: global before each
[00:32:45]               │ debg TestSubjects.getVisibleText(policyViewTitle)
[00:32:45]               │ debg TestSubjects.find(policyViewTitle)
[00:32:45]               │ debg Find.findByCssSelector('[data-test-subj="policyViewTitle"]') with timeout=10000
[00:32:45]               └- ✓ pass  (39ms) "endpoint Endpoint Policy List displays page title"
[00:32:45]             └-> shows policy count total
[00:32:45]               └-> "before each" hook: global before each
[00:32:45]               │ debg TestSubjects.getVisibleText(policyTotalCount)
[00:32:45]               │ debg TestSubjects.find(policyTotalCount)
[00:32:45]               │ debg Find.findByCssSelector('[data-test-subj="policyTotalCount"]') with timeout=10000
[00:32:45]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/endpoint Endpoint Policy List shows policy count total.png"
[00:32:45]               │ info Current URL is: http://localhost:6171/app/endpoint/policy
[00:32:45]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/endpoint Endpoint Policy List shows policy count total.html
[00:32:45]               └- ✖ fail: "endpoint Endpoint Policy List shows policy count total"
[00:32:45]               │

Stack Trace

Error: expected '100 Policies' to equal '0 Policies'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Context.it (test/functional/apps/endpoint/policy_list.ts:28:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. approved this time!

@shahzad31 shahzad31 merged commit 326a162 into elastic:master Feb 18, 2020
@shahzad31 shahzad31 deleted the fix/filter-group-autocomplete branch February 18, 2020 15:54
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Mar 6, 2020
* added autocomplete

* snaps

Co-authored-by: Elastic Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Mar 6, 2020
* added autocomplete

* snaps

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime UI] overview page: filter dropdown should support autocomplete
5 participants