-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip flaky alert details page instances test #57675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.7.0
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
labels
Feb 14, 2020
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededTo update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Feb 14, 2020
mikecote
added a commit
that referenced
this pull request
Feb 14, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Feb 14, 2020
This reverts commit c965a9e.
spalger
pushed a commit
that referenced
this pull request
Feb 19, 2020
* Revert "Skip flaky test (#57675)" This reverts commit c965a9e. * Revert "disable firefox smoke tests so we can fix flakiness out of band" This reverts commit fe38642. * Revert "skip flaky tests (#57643)" This reverts commit b220454. * Revert "skip flaky suite (#50018)" This reverts commit b058dc2. * Revert "skip settings tests (#57608)" This reverts commit 64625b2. * Revert "skip failing suite (#44631)" This reverts commit 8aa718d. * Revert "skip flaky suite (#44631)" This reverts commit 6e4efdf. * Revert "skip flaky test (#57377)" This reverts commit 59672ab. * Revert "Skip save query tests (#57589)" This reverts commit 431a1e9. * remove hard coded timeouts * Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band"" This reverts commit 271f881. * Revert "remove hard coded timeouts" This reverts commit 8b843d0. * wait for managementHome to exist, don't bail early if it's missing * Revert "skip flaky suite (#45244)" This reverts commit 0cee1a4. * extend timeouts for common existsOrFail() calls Co-authored-by: Elastic Machine <[email protected]>
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 19, 2020
* Revert "Skip flaky test (elastic#57675)" This reverts commit c965a9e. * Revert "disable firefox smoke tests so we can fix flakiness out of band" This reverts commit fe38642. * Revert "skip flaky tests (elastic#57643)" This reverts commit b220454. * Revert "skip flaky suite (elastic#50018)" This reverts commit b058dc2. * Revert "skip settings tests (elastic#57608)" This reverts commit 64625b2. * Revert "skip failing suite (elastic#44631)" This reverts commit 8aa718d. * Revert "skip flaky suite (elastic#44631)" This reverts commit 6e4efdf. * Revert "skip flaky test (elastic#57377)" This reverts commit 59672ab. * Revert "Skip save query tests (elastic#57589)" This reverts commit 431a1e9. * remove hard coded timeouts * Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band"" This reverts commit 271f881. * Revert "remove hard coded timeouts" This reverts commit 8b843d0. * wait for managementHome to exist, don't bail early if it's missing * Revert "skip flaky suite (elastic#45244)" This reverts commit 0cee1a4. * extend timeouts for common existsOrFail() calls Co-authored-by: Elastic Machine <[email protected]>
spalger
pushed a commit
that referenced
this pull request
Feb 19, 2020
* Revert "Skip flaky test (#57675)" This reverts commit c965a9e. * Revert "disable firefox smoke tests so we can fix flakiness out of band" This reverts commit fe38642. * Revert "skip flaky tests (#57643)" This reverts commit b220454. * Revert "skip flaky suite (#50018)" This reverts commit b058dc2. * Revert "skip settings tests (#57608)" This reverts commit 64625b2. * Revert "skip failing suite (#44631)" This reverts commit 8aa718d. * Revert "skip flaky suite (#44631)" This reverts commit 6e4efdf. * Revert "skip flaky test (#57377)" This reverts commit 59672ab. * Revert "Skip save query tests (#57589)" This reverts commit 431a1e9. * remove hard coded timeouts * Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band"" This reverts commit 271f881. * Revert "remove hard coded timeouts" This reverts commit 8b843d0. * wait for managementHome to exist, don't bail early if it's missing * Revert "skip flaky suite (#45244)" This reverts commit 0cee1a4. * extend timeouts for common existsOrFail() calls Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Alerting
release_note:skip
Skip the PR/issue when compiling release notes
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v7.7.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skips a test that causes #57426 for now until proper fix comes in.