Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM]Fixes UI titles for histograms #57535

Merged
merged 2 commits into from
Feb 16, 2020

Conversation

benskelker
Copy link
Contributor

@benskelker benskelker commented Feb 13, 2020

Summary

The UI strings for histograms with the word count need to be fixed. Changes:

  • Signals count > Signal count
  • External alerts count > External alert count
  • Events count > Event count

Resolves: #57270

Overview page

From:
Screenshot 2020-02-13 at 10 06 33

To:
Screenshot 2020-02-13 at 10 22 08

Hosts/Network pages

From:
Screenshot 2020-02-13 at 10 23 32

To:
Screenshot 2020-02-13 at 10 24 12

Checklist

Delete any items that are not applicable to this PR.

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately

@benskelker benskelker added the release_note:skip Skip the PR/issue when compiling release notes label Feb 13, 2020
@benskelker
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @benskelker!

@benskelker benskelker merged commit 67087e3 into elastic:master Feb 16, 2020
@benskelker benskelker deleted the fix_siem_histogram_titles branch February 16, 2020 08:40
benskelker added a commit to benskelker/kibana that referenced this pull request Feb 16, 2020
Co-authored-by: Elastic Machine <[email protected]>
benskelker added a commit to benskelker/kibana that referenced this pull request Feb 16, 2020
Co-authored-by: Elastic Machine <[email protected]>
benskelker added a commit that referenced this pull request Feb 16, 2020
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
benskelker added a commit that referenced this pull request Feb 16, 2020
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 17, 2020
…re/files-and-filetree

* 'master' of github.com:elastic/kibana: (139 commits)
  Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (elastic#57563)
  [Upgrade Assistant] Fix filter deprecations search filter (elastic#57541)
  [ML] New Platform server shim: update indices routes (elastic#57685)
  Bump redux dependencies (elastic#53348)
  [Index management] Client-side NP ready (elastic#57295)
  change id of x-pack event_log plugin to eventLog (elastic#57612)
  [eventLog] get kibana.index name from config instead of hard-coding it (elastic#57607)
  revert
  allow using any path to generate
  fixes ui titles (elastic#57535)
  Fix login redirect for expired sessions (elastic#57157)
  Expose Vis on the contract as it requires visTypes (elastic#56968)
  [SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present
  [Remote clusters] Migrate client-side code out of legacy (elastic#57365)
  Fix failed test reporter for SIEM Cypress use (elastic#57240)
  skip flaky suite (elastic#45244)
  update chromedriver to 80.0.1 (elastic#57602)
  change slack action to only report on whitelisted host name (elastic#57582)
  [kbn/optimizer] throw errors into stream on invalid completion (elastic#57735)
  moving visualize/utils to new platform (elastic#56650)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.6.1 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIEM - UI text corrections
4 participants