Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] adds ability to fetch Alert and Alert Instance state (#56625) #57174

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Feb 9, 2020

Backports the following commits to 7.x:

Enables access to the Alert State, which allows us to see which current Alert Instances are active.

This includes:

1. Addition of a `get` api on Task Manager
2. Typing and validation on Serialisation & Deserialisation of the State of an Alert's underlying Task
3. Addition of the `getAlertState` api on AlertsClient
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup job tsvb integration create rollup tsvb

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/57065

[00:00:00]       │
[00:27:07]         └-: rollup job
[00:27:07]           └-> "before all" hook
[00:28:24]           └-: tsvb integration
[00:28:24]             └-> "before all" hook
[00:28:24]             └-> "before all" hook
[00:28:24]               │ info [visualize/default] Loading "mappings.json"
[00:28:24]               │ info [visualize/default] Loading "data.json"
[00:28:24]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_2/pMrc-SFyQB2KyGYYYSO1mA] deleting index
[00:28:24]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_1/ed17tNrfQzKa7eJfGGhzgA] deleting index
[00:28:24]               │ info [visualize/default] Deleted existing index [".kibana_2",".kibana_1"]
[00:28:24]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [doc]
[00:28:24]               │ info [visualize/default] Created index ".kibana"
[00:28:24]               │ debg [visualize/default] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:28:24]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [metricbeat-7] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:28:24]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [metricbeat-7/slw-hvzcSq2TKQ63uqb5kQ] create_mapping [_doc]
[00:28:24]               │ info [visualize/default] Indexed 8 docs into ".kibana"
[00:28:24]               │ info [visualize/default] Indexed 1 docs into "metricbeat-7"
[00:28:25]               │ info Creating index .kibana_2.
[00:28:25]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:28:25]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] updating number_of_replicas to [0] for indices [.kibana_2]
[00:28:25]               │ info Reindexing .kibana to .kibana_1
[00:28:25]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:28:25]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] updating number_of_replicas to [0] for indices [.kibana_1]
[00:28:25]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] 67861 finished with response BulkByScrollResponse[took=89.3ms,timed_out=false,sliceId=null,updated=0,created=8,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:28:26]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana/fUwJ7baWSVaNjTocZV-u_Q] deleting index
[00:28:26]               │ info Migrating .kibana_1 saved objects to .kibana_2
[00:28:26]               │ debg Migrating saved objects space:default, index-pattern:metricbeat-*, custom-space:index-pattern:metricbeat-*, index-pattern:logstash-*, custom_space:index-pattern:logstash-*, visualization:i-exist, custom_space:visualization:i-exist, query:okjpgs
[00:28:26]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_2/XpcE5zaaTXS5uKFtezLZFA] update_mapping [_doc]
[00:28:26]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_2/XpcE5zaaTXS5uKFtezLZFA] update_mapping [_doc]
[00:28:26]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_2/XpcE5zaaTXS5uKFtezLZFA] update_mapping [_doc]
[00:28:26]               │ info Pointing alias .kibana to .kibana_2.
[00:28:26]               │ info Finished in 769ms.
[00:28:26]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:28:26]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_2/XpcE5zaaTXS5uKFtezLZFA] update_mapping [_doc]
[00:28:27]             └-> create rollup tsvb
[00:28:27]               └-> "before each" hook: global before each
[00:28:27]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [rollup-source-data] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:28:27]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [rollup-source-data/zxn9m0_ORViNIH4S1oulSg] create_mapping [_doc]
[00:28:27]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [rollup-target-data] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:28:27]               │ debg navigating to visualize url: http://localhost:6121/app/kibana#/visualize
[00:28:27]               │ debg Navigate to: http://localhost:6121/app/kibana#/visualize
[00:28:27]               │ info [o.e.x.r.j.RollupJobTask] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] Rollup job [tsvb-test-rollup-job-1581291744614] created.
[00:28:27]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [rollup-target-data/et36NNgWSbajyfI4ZWyxTA] update_mapping [_doc]
[00:28:28]               │ debg ... sleep(700) start
[00:28:28]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1581293454721#/visualize 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:28:28]               │
[00:28:28]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:28:28]               │ debg ... sleep(700) end
[00:28:28]               │ debg returned from get, calling refresh
[00:28:28]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1581293454721#/visualize 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:28:28]               │
[00:28:28]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:28:28]               │ debg currentUrl = http://localhost:6121/app/kibana#/visualize
[00:28:28]               │          appUrl = http://localhost:6121/app/kibana#/visualize
[00:28:28]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:28:32]               │ debg TestSubjects.find(kibanaChrome)
[00:28:32]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:28:32]               │ debg browser[INFO] http://localhost:6121/built_assets/dlls/vendors_3.bundle.dll.js 488:139970 "INFO: 2020-02-10T00:10:57Z
[00:28:32]               │        Adding connection to http://localhost:6121/elasticsearch
[00:28:32]               │
[00:28:32]               │      "
[00:28:32]               │ debg ... sleep(501) start
[00:28:32]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-tests-xl-1581290035617951166] [.kibana_2/XpcE5zaaTXS5uKFtezLZFA] update_mapping [_doc]
[00:28:33]               │ debg ... sleep(501) end
[00:28:33]               │ debg in navigateTo url = http://localhost:6121/app/kibana#/visualize?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:28:33]               │ debg TestSubjects.exists(statusPageContainer)
[00:28:33]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:28:35]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:28:36]               │ debg TestSubjects.exists(newItemButton)
[00:28:36]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="newItemButton"]') with timeout=2500
[00:28:36]               │ debg TestSubjects.click(newItemButton)
[00:28:36]               │ debg Find.clickByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:28:36]               │ debg Find.findByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:28:36]               │ debg TestSubjects.find(visNewDialogTypes)
[00:28:36]               │ debg Find.findByCssSelector('[data-test-subj="visNewDialogTypes"]') with timeout=10000
[00:28:36]               │ debg TestSubjects.click(visType-metrics)
[00:28:36]               │ debg Find.clickByCssSelector('[data-test-subj="visType-metrics"]') with timeout=10000
[00:28:36]               │ debg Find.findByCssSelector('[data-test-subj="visType-metrics"]') with timeout=10000
[00:28:36]               │ debg isGlobalLoadingIndicatorVisible
[00:28:36]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:28:36]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:28:38]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:28:38]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:28:38]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:28:38]               │ debg TestSubjects.exists(tvbVisEditor)
[00:28:38]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="tvbVisEditor"]') with timeout=10000
[00:28:38]               │ debg openQuickSelectTimeMenu
[00:28:38]               │ debg TestSubjects.exists(superDatePickerQuickMenu)
[00:28:38]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerQuickMenu"]') with timeout=2500
[00:28:41]               │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerQuickMenu"] is not displayed
[00:28:42]               │ debg opening quick select menu
[00:28:42]               │ debg TestSubjects.click(superDatePickerToggleQuickMenuButton)
[00:28:42]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:28:42]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:28:42]               │ debg TestSubjects.click(superDatePickerCommonlyUsed_Last_24 hours)
[00:28:42]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_Last_24 hours"]') with timeout=10000
[00:28:42]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_Last_24 hours"]') with timeout=10000
[00:28:42]               │ debg TestSubjects.find(metricTsvbTypeBtn)
[00:28:42]               │ debg Find.findByCssSelector('[data-test-subj="metricTsvbTypeBtn"]') with timeout=10000
[00:28:42]               │ debg TestSubjects.exists(tsvbMetricValue)
[00:28:42]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="tsvbMetricValue"]') with timeout=10000
[00:28:43]               │ debg TestSubjects.click(metricEditorPanelOptionsBtn)
[00:28:43]               │ debg Find.clickByCssSelector('[data-test-subj="metricEditorPanelOptionsBtn"]') with timeout=10000
[00:28:43]               │ debg Find.findByCssSelector('[data-test-subj="metricEditorPanelOptionsBtn"]') with timeout=10000
[00:28:43]               │ debg isGlobalLoadingIndicatorVisible
[00:28:43]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:28:43]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:28:44]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:28:45]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:28:45]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:28:45]               │ debg TestSubjects.find(metricsIndexPatternInput)
[00:28:45]               │ debg Find.findByCssSelector('[data-test-subj="metricsIndexPatternInput"]') with timeout=10000
[00:28:45]               │ debg isGlobalLoadingIndicatorVisible
[00:28:45]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:28:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:28:47]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:28:47]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:28:47]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:28:47]               │ debg TestSubjects.find(metricsIndexPatternInterval)
[00:28:47]               │ debg Find.findByCssSelector('[data-test-subj="metricsIndexPatternInterval"]') with timeout=10000
[00:28:47]               │ debg isGlobalLoadingIndicatorVisible
[00:28:47]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:28:47]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:28:49]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:28:49]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:28:49]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:28:49]               │ debg TestSubjects.find(metricsDropLastBucket-no)
[00:28:49]               │ debg Find.findByCssSelector('[data-test-subj="metricsDropLastBucket-no"]') with timeout=10000
[00:28:49]               │ debg isGlobalLoadingIndicatorVisible
[00:28:49]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:28:49]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:28:51]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:28:52]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:28:52]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:28:52]               │ debg ... sleep(3000) start
[00:28:55]               │ debg ... sleep(3000) end
[00:28:55]               │ debg Waiting up to 20000ms for rendering count to stabilize...
[00:28:55]               │ debg TestSubjects.find(visualizationLoader)
[00:28:55]               │ debg Find.findByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:28:55]               │ debg -- firstCount=7
[00:28:55]               │ debg ... sleep(1000) start
[00:28:56]               │ debg ... sleep(1000) end
[00:28:56]               │ debg TestSubjects.find(visualizationLoader)
[00:28:56]               │ debg Find.findByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:28:56]               │ debg -- secondCount=7
[00:28:56]               │ debg Find.findByCssSelector('.tvbVisMetric__value--primary') with timeout=10000
[00:28:56]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/rollup job tsvb integration create rollup tsvb.png"
[00:28:56]               │ info Current URL is: http://localhost:6121/app/kibana#/visualize/create?type=metrics&_g=(refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(filters:!(),linked:!f,query:(language:kuery,query:%27%27),uiState:(),vis:(aggs:!(),params:(axis_formatter:number,axis_position:left,axis_scale:normal,background_color_rules:!((id:d6bef620-4b99-11ea-8ebe-0fd253c953d9)),default_index_pattern:%27metricbeat-*%27,default_timefield:%27@timestamp%27,drop_last_bucket:0,id:%2761ca57f0-469d-11e7-af02-69e470af7417%27,index_pattern:rollup-target-data,interval:%271d%27,isModelInvalid:!f,series:!((axis_position:right,chart_type:line,color:%2368BC00,fill:0.5,formatter:number,id:%2761ca57f1-469d-11e7-af02-69e470af7417%27,line_width:1,metrics:!((id:%2761ca57f2-469d-11e7-af02-69e470af7417%27,type:count)),point_size:1,separate_axis:0,split_mode:everything,stacked:none)),show_grid:1,show_legend:1,time_field:%27%27,type:metric),title:%27%27,type:metrics))
[00:28:56]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/rollup job tsvb integration create rollup tsvb.html
[00:28:56]               └- ✖ fail: "rollup job tsvb integration create rollup tsvb"
[00:28:56]               │

Stack Trace

{ Error: expected '0' to sort of equal '3'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/functional/apps/rollup_job/tsvb.js:90:27)
    at process._tickCallback (internal/process/next_tick.js:68:7) actual: '0', expected: '3', showDiff: true }

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gmmorris gmmorris merged commit f666b58 into elastic:7.x Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants