-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the token used by project-assigner workflows #57127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexh97
added
review
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
Feb 7, 2020
jbudz
approved these changes
Feb 10, 2020
@elasticmachine merge upstream |
@elasticmachine merge upstream |
alexh97
changed the title
Adding a test workflow to further debug permissions errors with project-assigner
Changing the token used by project-assigner workflows
Feb 26, 2020
tylersmalley
approved these changes
Feb 26, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Feb 26, 2020
kibanamachine
added
the
backport missing
Added to PRs automatically when the are determined to be missing a backport.
label
Feb 27, 2020
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
Added to PRs automatically when the are determined to be missing a backport.
label
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
review
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the course of my investigation of the permissions errors we're seeing with the
project-assigner
andpr-project-assigner
workflows, I came across a GitHub marketplace action that is similar to our project-assigner action. The author describes the need to configure a personal access token for repositories that one doesn't have admin privileges for in order to use that action. As it turns out, about 50% of our developers don't have admin rights to thekibana
repo.The infra team has set up a new token for us to try with a wider set of permissions. This PR uses the new token and also updates the workflow to the latest version of the action, which has fixes for the async functions.