Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the token used by project-assigner workflows #57127

Merged
merged 12 commits into from
Feb 26, 2020

Conversation

alexh97
Copy link

@alexh97 alexh97 commented Feb 7, 2020

Summary

In the course of my investigation of the permissions errors we're seeing with the project-assigner and pr-project-assigner workflows, I came across a GitHub marketplace action that is similar to our project-assigner action. The author describes the need to configure a personal access token for repositories that one doesn't have admin privileges for in order to use that action. As it turns out, about 50% of our developers don't have admin rights to the kibana repo.

The infra team has set up a new token for us to try with a wider set of permissions. This PR uses the new token and also updates the workflow to the latest version of the action, which has fixes for the async functions.

@alexh97 alexh97 added review v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 7, 2020
@alexh97 alexh97 requested a review from a team February 7, 2020 16:51
@alexh97 alexh97 self-assigned this Feb 7, 2020
@alexh97
Copy link
Author

alexh97 commented Feb 10, 2020

@elasticmachine merge upstream

@alexh97
Copy link
Author

alexh97 commented Feb 11, 2020

@elasticmachine merge upstream

@alexh97 alexh97 changed the title Adding a test workflow to further debug permissions errors with project-assigner Changing the token used by project-assigner workflows Feb 26, 2020
@alexh97 alexh97 requested a review from tylersmalley February 26, 2020 19:11
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexh97 alexh97 merged commit a25ba4e into elastic:master Feb 26, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 27, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 57127 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Feb 28, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes review v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants