-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate vega and graph configs to new platform #57011
Conversation
Jenkins, test this |
💔 Build FailedTest FailuresKibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running 'yarn test:browser' should exit 0Standard Out
Stack Trace
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 👍, tested locally in chrome and starting Kibana with
yarn start --vis_type_vega.enableExternalUrls=true
✅ works
yarn start --vega.enableExternalUrls=true
✅ works and found the expected output in the server startup logs:
log [16:16:42.561] [warning][config][deprecation] "vega.enableExternalUrls" is deprecated and has been replaced by "vis_type_vega.enableExternalUrls"
deprecations: ({ renameFromRoot }) => [ | ||
renameFromRoot('vega.enableExternalUrls', 'vis_type_vega.enableExternalUrls'), | ||
renameFromRoot('vega.enabled', 'vis_type_vega.enabled'), | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice ❤️, so for now it doesn't break
I have no idea why this is failing - the logs report an error within
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Depends on #56763
This PR gets rid of injected vars usage for Graph and vega config keys.
It also renames
vega.*
tovis_type_vega.*
to be consistent with other visualization types. If the old config prefix is used, a warning is shown.