Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Fix for IE11 floating tools with open history viewer #56961

Merged
merged 1 commit into from
Feb 6, 2020
Merged

[Console] Fix for IE11 floating tools with open history viewer #56961

merged 1 commit into from
Feb 6, 2020

Conversation

jloleysens
Copy link
Contributor

Summary

IE11 does not know about unset https://caniuse.com/#feat=css-unset-value.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@jloleysens jloleysens added Feature:Console Dev Tools Console Feature Feature:Dev Tools v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens jloleysens added the IE11 label Feb 6, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth self-requested a review February 6, 2020 13:58
alisonelizabeth
alisonelizabeth approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@jloleysens jloleysens merged commit a81918c into elastic:master Feb 6, 2020
@jloleysens
Copy link
Contributor Author

Backported:

7.x: #56946
7.6: #56948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
Feature:Console Dev Tools Console Feature Feature:Dev Tools IE11 release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jloleysens @elasticmachine @kibanamachine @alisonelizabeth @cjcenizal