Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix issue with Kibana Icon in Uptime App #56837

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Feb 5, 2020

Summary

Fix #56722

Fix an issue where donut chart was removing all g elements from page, now it will only remove from donut chart.

Testing

  1. Make sure donut chart is working
  2. Donut chart is properly updating
  3. Kibana icon is working on uptime app

Checklist

@shahzad31 shahzad31 added release_note:fix v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Feb 5, 2020
@shahzad31 shahzad31 self-assigned this Feb 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

It's a cosmetic fix, so not sure, if needs to be pushed to 7.6.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I ran this and master and observed the change described in the PR summary and issue.

@justinkambic
Copy link
Contributor

It's a cosmetic fix, so not sure, if needs to be pushed to 7.6.

Let's only backport this to 7.7

@shahzad31 shahzad31 merged commit bb6dac4 into elastic:master Feb 6, 2020
@shahzad31 shahzad31 deleted the fix/kibana-icon-being-removed-from-uptime branch February 6, 2020 17:23
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Kibana icon not visible on Uptime page after uptime data fetched from the server
4 participants