Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScopedHistory to AppMountParams #56705

Merged
merged 8 commits into from
Feb 26, 2020
Merged

Add ScopedHistory to AppMountParams #56705

merged 8 commits into from
Feb 26, 2020

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Feb 3, 2020 •
edited
Loading

Summary

Fixes #53692

This adds a new history property to the AppMountParameters interface and deprecates the appBasePath property. Applications should use this provided history instance with their router in order to provide interop correctly with Core's top-level router.

This history instance also includes a createSubHistory function for applications that have "sub-apps" such as Management and Dev Tools.

There will need to be some modifications to existing utilities to work correctly with this code. For example, sync state will need to use this provided history instance and use relative URLs rather than absolute URLs. In my brief experiments, it seemed this will actually simplify sync state's implementation quite a bit.

TODO:

  • Test in IE11

Dev Docs

Kibana Platform applications should use the provided history instance to integrate routing rather than setting up their own using appBasePath (which is now deprecated).

Before

core.application.register({
  id: 'myApp',
  mount({ appBasePath, element }) {
    ReactDOM.render(
      <BrowserRouter basename={appBasePath}>
        <App />
      </BrowserRouter>,
      element
    );
    return () => ReactDOM.unmountComponentAtNode(element);
  }
});

After

core.application.register({
  id: 'myApp',
  mount({ element, history }) {
    ReactDOM.render(
      <BrowserRouter history={history}>
        <App />
      </BrowserRouter>,
      element
    );
    return () => ReactDOM.unmountComponentAtNode(element);
  }
});

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.7.0 labels Feb 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover
Copy link
Contributor Author

@Dosant I'm still working on this, but maybe you can verify that it fixed the issue you were seeing. You can test by loading 2 test plugins that are set up to use this:

node scripts/kibana --dev --plugin-path test/plugin_functional/plugins/core_plugin_a --plugin-path test/plugin_functional/plugins/core_plugin_b

@Dosant
Copy link
Contributor

Dosant commented Feb 4, 2020 •
edited
Loading

@joshdover, I tried using my sample plugin, where I originally discovered the issue.
After pulling your branch, the only change I did in my plugin is changing createBrowserHistory() to using platform's scoped history.

Dosant@85e8ca1

The original issue is gone. I see, that app reacts on updates triggered by navigation in chrome.

But I hoped, that all other app setup would work the same, which is not the case at the moment :(

some things I noticed:

  1. I got into states with weird urls like:

http://localhost:5601/app/state-containers-example-browser-history/app/state-containers-example-browser-history#?_g=(text:'')&_todo-1=(todos:!((completed:!f,id:0,text:'Learning%20state%20containers')))

  1. The urls I am putting into href, which I am composing using history are not always correct

  2. Also when trying to navigate using <Link/> I am having exceptions:

react-dom.development.js:475 Uncaught TypeError: Cannot read property 'verifyActive' of undefined
    at push (scoped_history.ts:91)
    at navigate (react-router-dom.js:191)
    at onClick (react-router-dom.js:149)

Apparently because of lost this context.

(somewhere in react-router)

var method = replace ? history.replace : history.push;
        method(location);

To play with this demo plugin I am using, just start kibana with --run-examples flag

@pgayvallet
Copy link
Contributor

Apparently because of lost this context.

this should easily be fixed with arrow functions or bind though, this one doesn't sound so scary

@joshdover joshdover force-pushed the np/history-wrapper branch 2 times, most recently from 48ba07c to 1fa27c8 Compare February 6, 2020 23:00
@elasticmachine
Copy link
Contributor

💔 Build Failed

Test Failures

Kibana Pipeline / kibana-oss-agent / Plugin Functional Tests.test/plugin_functional/test_suites/core_plugins/applications·ts.core plugins ui applications navigates to its own pages

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:05]         └-: core plugins
[00:01:05]           └-> "before all" hook
[00:01:05]           └-: ui applications
[00:01:05]             └-> "before all" hook
[00:01:05]             └-> "before all" hook
[00:01:05]               │ debg navigating to foo url: http://localhost:6121/app/foo
[00:01:05]               │ debg Navigate to: http://localhost:6121/app/foo
[00:01:06]               │ debg ... sleep(700) start
[00:01:06]               │ debg browser[INFO] http://localhost:6121/app/foo?_t=1581031709706 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:06]               │
[00:01:06]               │ debg browser[INFO] http://localhost:6121/bundles/app/core/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:06]               │ debg ... sleep(700) end
[00:01:06]               │ debg returned from get, calling refresh
[00:01:06]               │ debg browser[INFO] http://localhost:6121/app/foo?_t=1581031709706 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:06]               │
[00:01:06]               │ debg browser[INFO] http://localhost:6121/bundles/app/core/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:06]               │ debg currentUrl = http://localhost:6121/app/foo
[00:01:06]               │          appUrl = http://localhost:6121/app/foo
[00:01:06]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:08]               │ debg browser[INFO] http://localhost:6121/bundles/plugin/testbed.bundle.js 197:24 "Testbed plugin set up. uiProp: 'Accessible from client'"
[00:01:08]               │ debg browser[INFO] webpack://%5Bname%5D/./node_modules/elasticsearch-browser/elasticsearch.js? 31638:15 "INFO: 2020-02-06T23:28:32Z
[00:01:08]               │        Adding connection to http://localhost:6121/elasticsearch
[00:01:08]               │
[00:01:08]               │      "
[00:01:08]               │ debg browser[WARNING] http://localhost:6121/bundles/commons.bundle.js 2857:20 "App [rendering] is using deprecated mount context. Use core.getStartServices() instead."
[00:01:08]               │ debg browser[WARNING] http://localhost:6121/bundles/commons.bundle.js 2857:20 "App [custom-app-route] is using deprecated mount context. Use core.getStartServices() instead."
[00:01:08]               │ debg browser[WARNING] http://localhost:6121/bundles/commons.bundle.js 2857:20 "App [chromeless] is using deprecated mount context. Use core.getStartServices() instead."
[00:01:08]               │ debg browser[WARNING] http://localhost:6121/bundles/commons.bundle.js 2857:20 "App [appleave1] is using deprecated mount context. Use core.getStartServices() instead."
[00:01:08]               │ debg browser[WARNING] http://localhost:6121/bundles/commons.bundle.js 2857:20 "App [appleave2] is using deprecated mount context. Use core.getStartServices() instead."
[00:01:08]               │ debg browser[WARNING] http://localhost:6121/bundles/commons.bundle.js 2857:20 "App [foo] is using deprecated mount context. Use core.getStartServices() instead."
[00:01:08]               │ debg browser[WARNING] http://localhost:6121/bundles/commons.bundle.js 2857:20 "App [bar] is using deprecated mount context. Use core.getStartServices() instead."
[00:01:08]               │ debg browser[DEBUG] http://localhost:6121/bundles/commons.bundle.js 2248:16 "Reporting user-agent."
[00:01:08]               │ debg browser[INFO] http://localhost:6121/bundles/plugin/testbed.bundle.js 220:14 "Testbed plugin started"
[00:01:08]               │ debg ... sleep(501) start
[00:01:09]               │ debg ... sleep(501) end
[00:01:09]               │ debg in navigateTo url = http://localhost:6121/app/foo
[00:01:09]               │ debg TestSubjects.exists(statusPageContainer)
[00:01:09]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:01:11]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:01:12]             └-> starts on home page
[00:01:12]               └-> "before each" hook: global before each
[00:01:12]               │ debg TestSubjects.exists(fooAppHome)
[00:01:12]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="fooAppHome"]') with timeout=120000
[00:01:12]               └- ✓ pass  (38ms) "core plugins ui applications starts on home page"
[00:01:12]             └-> navigates to its own pages
[00:01:12]               └-> "before each" hook: global before each
[00:01:12]               │ debg TestSubjects.click(fooNavPageA)
[00:01:12]               │ debg Find.clickByCssSelector('[data-test-subj="fooNavPageA"]') with timeout=10000
[00:01:12]               │ debg Find.findByCssSelector('[data-test-subj="fooNavPageA"]') with timeout=10000
[00:01:12]               │ debg TestSubjects.exists(kbnLoadingMessage)
[00:01:12]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="kbnLoadingMessage"]') with timeout=2500
[00:01:14]               │ debg --- retry.tryForTime error: [data-test-subj="kbnLoadingMessage"] is not displayed
[00:01:15]               │ debg TestSubjects.exists(fooAppPageA)
[00:01:15]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="fooAppPageA"]') with timeout=120000
[00:01:15]               │ debg TestSubjects.click(fooNavHome)
[00:01:15]               │ debg Find.clickByCssSelector('[data-test-subj="fooNavHome"]') with timeout=10000
[00:01:15]               │ debg Find.findByCssSelector('[data-test-subj="fooNavHome"]') with timeout=10000
[00:01:15]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/core plugins ui applications navigates to its own pages.png"
[00:01:15]               │ info Current URL is: http://localhost:6121/app/foo
[00:01:15]               │ info Saving page source to: /dev/shm/workspace/kibana/test/plugin_functional/failure_debug/html/core plugins ui applications navigates to its own pages.html
[00:01:15]               └- ✖ fail: "core plugins ui applications navigates to its own pages"
[00:01:15]               │

Stack Trace

{ Error: expected 'http://localhost:6121/app/foo' to sort of equal 'http://localhost:6121/app/foo/'
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (packages/kbn-expect/expect.js:244:8)
    at Context.it (test/plugin_functional/test_suites/core_plugins/applications.ts:69:48)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  actual: 'http://localhost:6121/app/foo',
  expected: 'http://localhost:6121/app/foo/',
  showDiff: true }
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup app tsvb integration create rollup tsvb

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/56816

[00:00:00]       │
[00:28:07]         └-: rollup app
[00:28:07]           └-> "before all" hook
[00:29:26]           └-: tsvb integration
[00:29:26]             └-> "before all" hook
[00:29:26]             └-> "before all" hook
[00:29:26]               │ info [visualize/default] Loading "mappings.json"
[00:29:26]               │ info [visualize/default] Loading "data.json"
[00:29:26]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_1/14c6gMaASMu1edVZRJ5dHg] deleting index
[00:29:26]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_2/cjgdkIfCRcySqnCCbRlYzQ] deleting index
[00:29:26]               │ info [visualize/default] Deleted existing index [".kibana_2",".kibana_1"]
[00:29:26]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:29:26]               │ info [visualize/default] Created index ".kibana"
[00:29:26]               │ debg [visualize/default] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:29:26]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [metricbeat-7] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:29:26]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [metricbeat-7/qAm3XYmKTn-fooppv_5VLA] create_mapping
[00:29:26]               │ info [visualize/default] Indexed 8 docs into ".kibana"
[00:29:26]               │ info [visualize/default] Indexed 1 docs into "metricbeat-7"
[00:29:27]               │ info Creating index .kibana_2.
[00:29:27]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:29:27]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] updating number_of_replicas to [0] for indices [.kibana_2]
[00:29:27]               │ info Reindexing .kibana to .kibana_1
[00:29:27]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:29:27]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] updating number_of_replicas to [0] for indices [.kibana_1]
[00:29:27]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] 71261 finished with response BulkByScrollResponse[took=90.2ms,timed_out=false,sliceId=null,updated=0,created=8,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:29:27]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana/WYLtT_LRR9eNlOZZ2qy0sw] deleting index
[00:29:27]               │ info Migrating .kibana_1 saved objects to .kibana_2
[00:29:28]               │ debg Migrating saved objects space:default, index-pattern:metricbeat-*, custom-space:index-pattern:metricbeat-*, index-pattern:logstash-*, custom_space:index-pattern:logstash-*, visualization:i-exist, custom_space:visualization:i-exist, query:okjpgs
[00:29:28]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_2/Csm6WqlWQeaFdxe2eBxaeA] update_mapping [_doc]
[00:29:28]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_2/Csm6WqlWQeaFdxe2eBxaeA] update_mapping [_doc]
[00:29:28]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_2/Csm6WqlWQeaFdxe2eBxaeA] update_mapping [_doc]
[00:29:28]               │ info Pointing alias .kibana to .kibana_2.
[00:29:28]               │ info Finished in 690ms.
[00:29:28]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:29:28]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_2/Csm6WqlWQeaFdxe2eBxaeA] update_mapping [_doc]
[00:29:29]             └-> create rollup tsvb
[00:29:29]               └-> "before each" hook: global before each
[00:29:29]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [rollup-source-data] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:29:29]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [rollup-source-data/7lfWw-I2QUaCTiGx6ly5SQ] create_mapping
[00:29:29]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [rollup-target-data] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:29:29]               │ debg navigating to visualize url: http://localhost:6121/app/kibana#/visualize
[00:29:29]               │ debg Navigate to: http://localhost:6121/app/kibana#/visualize
[00:29:29]               │ info [o.e.x.r.j.RollupJobTask] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] Rollup job [tsvb-test-rollup-job-1581031812683] created.
[00:29:29]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [rollup-target-data/E_a88-nHTz2FY27WSduSlQ] update_mapping [_doc]
[00:29:29]               │ debg ... sleep(700) start
[00:29:29]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1581033584645#/visualize 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:29:29]               │
[00:29:29]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:29:30]               │ debg ... sleep(700) end
[00:29:30]               │ debg returned from get, calling refresh
[00:29:30]               │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1581033584645#/visualize 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:29:30]               │
[00:29:30]               │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:29:30]               │ debg currentUrl = http://localhost:6121/app/kibana#/visualize
[00:29:30]               │          appUrl = http://localhost:6121/app/kibana#/visualize
[00:29:30]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:29:35]               │ debg TestSubjects.find(kibanaChrome)
[00:29:35]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:29:35]               │ debg browser[INFO] http://localhost:6121/built_assets/dlls/vendors_2.bundle.dll.js 92:138197 "INFO: 2020-02-06T23:59:48Z
[00:29:35]               │        Adding connection to http://localhost:6121/elasticsearch
[00:29:35]               │
[00:29:35]               │      "
[00:29:35]               │ debg ... sleep(501) start
[00:29:35]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.kibana_2/Csm6WqlWQeaFdxe2eBxaeA] update_mapping [_doc]
[00:29:35]               │ debg ... sleep(501) end
[00:29:35]               │ debg in navigateTo url = http://localhost:6121/app/kibana#/visualize?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:29:35]               │ debg TestSubjects.exists(statusPageContainer)
[00:29:35]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:29:38]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:29:38]               │ debg TestSubjects.exists(newItemButton)
[00:29:38]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="newItemButton"]') with timeout=2500
[00:29:39]               │ debg TestSubjects.click(newItemButton)
[00:29:39]               │ debg Find.clickByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:29:39]               │ debg Find.findByCssSelector('[data-test-subj="newItemButton"]') with timeout=10000
[00:29:39]               │ debg TestSubjects.find(visNewDialogTypes)
[00:29:39]               │ debg Find.findByCssSelector('[data-test-subj="visNewDialogTypes"]') with timeout=10000
[00:29:39]               │ debg TestSubjects.click(visType-metrics)
[00:29:39]               │ debg Find.clickByCssSelector('[data-test-subj="visType-metrics"]') with timeout=10000
[00:29:39]               │ debg Find.findByCssSelector('[data-test-subj="visType-metrics"]') with timeout=10000
[00:29:39]               │ debg isGlobalLoadingIndicatorVisible
[00:29:39]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:29:39]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:29:41]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:29:41]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:29:41]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:29:41]               │ debg TestSubjects.exists(tvbVisEditor)
[00:29:41]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="tvbVisEditor"]') with timeout=10000
[00:29:41]               │ debg openQuickSelectTimeMenu
[00:29:41]               │ debg TestSubjects.exists(superDatePickerQuickMenu)
[00:29:41]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerQuickMenu"]') with timeout=2500
[00:29:44]               │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerQuickMenu"] is not displayed
[00:29:44]               │ debg opening quick select menu
[00:29:44]               │ debg TestSubjects.click(superDatePickerToggleQuickMenuButton)
[00:29:44]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:29:44]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=10000
[00:29:45]               │ debg TestSubjects.click(superDatePickerCommonlyUsed_Last_24 hours)
[00:29:45]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_Last_24 hours"]') with timeout=10000
[00:29:45]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerCommonlyUsed_Last_24 hours"]') with timeout=10000
[00:29:45]               │ debg TestSubjects.find(metricTsvbTypeBtn)
[00:29:45]               │ debg Find.findByCssSelector('[data-test-subj="metricTsvbTypeBtn"]') with timeout=10000
[00:29:45]               │ debg TestSubjects.exists(tsvbMetricValue)
[00:29:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="tsvbMetricValue"]') with timeout=10000
[00:29:46]               │ debg TestSubjects.click(metricEditorPanelOptionsBtn)
[00:29:46]               │ debg Find.clickByCssSelector('[data-test-subj="metricEditorPanelOptionsBtn"]') with timeout=10000
[00:29:46]               │ debg Find.findByCssSelector('[data-test-subj="metricEditorPanelOptionsBtn"]') with timeout=10000
[00:29:46]               │ debg isGlobalLoadingIndicatorVisible
[00:29:46]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:29:46]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:29:47]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:29:48]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:29:48]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:29:48]               │ debg TestSubjects.find(metricsIndexPatternInput)
[00:29:48]               │ debg Find.findByCssSelector('[data-test-subj="metricsIndexPatternInput"]') with timeout=10000
[00:29:48]               │ debg isGlobalLoadingIndicatorVisible
[00:29:48]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:29:48]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:29:50]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:29:50]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:29:50]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:29:50]               │ debg TestSubjects.find(metricsIndexPatternInterval)
[00:29:50]               │ debg Find.findByCssSelector('[data-test-subj="metricsIndexPatternInterval"]') with timeout=10000
[00:29:50]               │ debg isGlobalLoadingIndicatorVisible
[00:29:50]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:29:50]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:29:52]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:29:53]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:29:53]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:29:53]               │ debg TestSubjects.find(metricsDropLastBucket-no)
[00:29:53]               │ debg Find.findByCssSelector('[data-test-subj="metricsDropLastBucket-no"]') with timeout=10000
[00:29:53]               │ debg isGlobalLoadingIndicatorVisible
[00:29:53]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:29:53]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:29:54]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.watcher-history-10-2020.02.07] creating index, cause [auto(bulk api)], templates [.watch-history-10], shards [1]/[0], mappings [_doc]
[00:29:54]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] moving index [.watcher-history-10-2020.02.07] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [watch-history-ilm-policy]
[00:29:54]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.watcher-history-10-2020.02.07/fYeaquAPS2uOPhvn0TUxiQ] update_mapping [_doc]
[00:29:54]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581030055627057089] [.watcher-history-10-2020.02.07/fYeaquAPS2uOPhvn0TUxiQ] update_mapping [_doc]
[00:29:54]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:29:55]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:29:55]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:29:55]               │ debg ... sleep(3000) start
[00:29:58]               │ debg ... sleep(3000) end
[00:29:58]               │ debg Waiting up to 20000ms for rendering count to stabilize...
[00:29:58]               │ debg TestSubjects.find(visualizationLoader)
[00:29:58]               │ debg Find.findByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:29:58]               │ debg -- firstCount=7
[00:29:58]               │ debg ... sleep(1000) start
[00:29:59]               │ debg ... sleep(1000) end
[00:29:59]               │ debg TestSubjects.find(visualizationLoader)
[00:29:59]               │ debg Find.findByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:29:59]               │ debg -- secondCount=7
[00:29:59]               │ debg Find.findByCssSelector('.tvbVisMetric__value--primary') with timeout=10000
[00:29:59]               │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/rollup app tsvb integration create rollup tsvb.png"
[00:29:59]               │ info Current URL is: http://localhost:6121/app/kibana#/visualize/create?type=metrics&_g=(refreshInterval:(pause:!t,value:0),time:(from:now-24h,to:now))&_a=(filters:!(),linked:!f,query:(language:kuery,query:%27%27),uiState:(),vis:(aggs:!(),params:(axis_formatter:number,axis_position:left,axis_scale:normal,background_color_rules:!((id:c8b82c40-493c-11ea-8271-9d74bb896267)),default_index_pattern:%27metricbeat-*%27,default_timefield:%27@timestamp%27,drop_last_bucket:0,id:%2761ca57f0-469d-11e7-af02-69e470af7417%27,index_pattern:rollup-target-data,interval:%271d%27,isModelInvalid:!f,series:!((axis_position:right,chart_type:line,color:%2368BC00,fill:0.5,formatter:number,id:%2761ca57f1-469d-11e7-af02-69e470af7417%27,line_width:1,metrics:!((id:%2761ca57f2-469d-11e7-af02-69e470af7417%27,type:count)),point_size:1,separate_axis:0,split_mode:everything,stacked:none)),show_grid:1,show_legend:1,time_field:%27%27,type:metric),title:%27%27,type:metrics))
[00:29:59]               │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/rollup app tsvb integration create rollup tsvb.html
[00:29:59]               └- ✖ fail: "rollup app tsvb integration create rollup tsvb"
[00:29:59]               │

Stack Trace

{ Error: expected '0' to sort of equal '3'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/functional/apps/rollup_job/tsvb.js:90:27)
    at process._tickCallback (internal/process/next_tick.js:68:7) actual: '0', expected: '3', showDiff: true }
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces·ts.endpoint feature controls spaces space with no features disabled endpoint app shows 'Hello World'

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:28:19]         └-: endpoint
[00:28:19]           └-> "before all" hook
[00:28:19]           └-: feature controls
[00:28:19]             └-> "before all" hook
[00:28:19]             └-: spaces
[00:28:19]               └-> "before all" hook
[00:28:19]               └-: space with no features disabled
[00:28:19]                 └-> "before all" hook
[00:28:19]                 └-> "before all" hook
[00:28:19]                   │ debg creating space
[00:28:20]                   │ debg created space
[00:28:20]                 └-> shows endpoint navlink
[00:28:20]                   └-> "before each" hook: global before each
[00:28:20]                   │ debg navigating to home url: http://localhost:6181/s/custom_space/app/kibana#/home
[00:28:20]                   │ debg Navigate to: http://localhost:6181/s/custom_space/app/kibana#/home
[00:28:21]                   │ debg ... sleep(700) start
[00:28:21]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1581033664614#/home 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:28:21]                   │
[00:28:21]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:28:21]                   │ debg ... sleep(700) end
[00:28:21]                   │ debg returned from get, calling refresh
[00:28:22]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1581033664614#/home 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:28:22]                   │
[00:28:22]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:28:22]                   │ debg currentUrl = http://localhost:6181/s/custom_space/app/kibana#/home
[00:28:22]                   │          appUrl = http://localhost:6181/s/custom_space/app/kibana#/home
[00:28:22]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:28:26]                   │ debg TestSubjects.find(kibanaChrome)
[00:28:26]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:28:26]                   │ debg browser[INFO] http://localhost:6181/built_assets/dlls/vendors_2.bundle.dll.js 92:138197 "INFO: 2020-02-07T00:01:09Z
[00:28:26]                   │        Adding connection to http://localhost:6181/s/custom_space/elasticsearch
[00:28:26]                   │
[00:28:26]                   │      "
[00:28:27]                   │ debg ... sleep(501) start
[00:28:27]                   │ debg ... sleep(501) end
[00:28:27]                   │ debg in navigateTo url = http://localhost:6181/s/custom_space/app/kibana#/home
[00:28:27]                   │ debg TestSubjects.exists(statusPageContainer)
[00:28:27]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:28:30]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:28:30]                   │ debg TestSubjects.find(navDrawer)
[00:28:30]                   │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:28:30]                   └- ✓ pass  (10.5s) "endpoint feature controls spaces space with no features disabled shows endpoint navlink"
[00:28:30]                 └-> endpoint app shows 'Hello World'
[00:28:30]                   └-> "before each" hook: global before each
[00:28:30]                   │ debg navigating to endpoint url: http://localhost:6181/s/custom_space/app/endpoint
[00:28:30]                   │ debg Navigate to: http://localhost:6181/s/custom_space/app/endpoint
[00:28:30]                   │ debg ... sleep(700) start
[00:28:30]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/endpoint?_t=1581033675145 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:28:30]                   │
[00:28:30]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/core/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:28:31]                   │ debg ... sleep(700) end
[00:28:31]                   │ debg returned from get, calling refresh
[00:28:31]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/endpoint?_t=1581033675145 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:28:31]                   │
[00:28:31]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/core/bootstrap.js 8:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:28:31]                   │ debg currentUrl = http://localhost:6181/s/custom_space/app/endpoint
[00:28:31]                   │          appUrl = http://localhost:6181/s/custom_space/app/endpoint
[00:28:31]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:28:33]                   │ debg browser[INFO] http://localhost:6181/built_assets/dlls/vendors_2.bundle.dll.js 92:138197 "INFO: 2020-02-07T00:01:17Z
[00:28:33]                   │        Adding connection to http://localhost:6181/s/custom_space/elasticsearch
[00:28:33]                   │
[00:28:33]                   │      "
[00:28:33]                   │ debg browser[INFO] http://localhost:6181/bundles/commons.bundle.js 2:4868544 "Detected an unhandled Promise rejection.
[00:28:33]                   │      Error: Browser location [/s/custom_space/app/endpoint] is not currently at expected basePath [/s/custom_space/app/endpoint]"
[00:28:33]                   │ERROR browser[SEVERE] http://localhost:6181/bundles/commons.bundle.js 2:4802965 Uncaught Error: Browser location [/s/custom_space/app/endpoint] is… expected basePath [/s/custom_space/app/endpoint]
[00:28:33]                   │ debg ... sleep(501) start
[00:28:34]                   │ debg ... sleep(501) end
[00:28:34]                   │ debg in navigateTo url = http://localhost:6181/s/custom_space/app/endpoint
[00:28:34]                   │ debg TestSubjects.exists(statusPageContainer)
[00:28:34]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:28:36]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:28:37]                   │ debg TestSubjects.exists(welcomeTitle)
[00:28:37]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="welcomeTitle"]') with timeout=120000
[00:28:39]                   │ debg --- retry.tryForTime error: [data-test-subj="welcomeTitle"] is not displayed
[00:28:42]                   │ debg --- retry.tryForTime failed again with the same message...
[00:28:45]                   │ debg --- retry.tryForTime failed again with the same message...
[00:28:48]                   │ debg --- retry.tryForTime failed again with the same message...
[00:28:51]                   │ debg --- retry.tryForTime failed again with the same message...
[00:28:54]                   │ debg --- retry.tryForTime failed again with the same message...
[00:28:57]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:00]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:03]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:06]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:09]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:12]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:15]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:18]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:22]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:25]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:28]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:31]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:34]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:37]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:40]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:43]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:46]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:49]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:52]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:55]                   │ debg --- retry.tryForTime failed again with the same message...
[00:29:58]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:01]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:04]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:07]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:10]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:13]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:16]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:19]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:22]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:25]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:29]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:32]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:35]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:38]                   │ debg --- retry.tryForTime failed again with the same message...
[00:30:38]                   │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/endpoint feature controls spaces space with no features disabled endpoint app shows _Hello World_.png"
[00:30:38]                   │ info Current URL is: http://localhost:6181/s/custom_space/app/endpoint
[00:30:38]                   │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/endpoint feature controls spaces space with no features disabled endpoint app shows _Hello World_.html
[00:30:38]                   └- ✖ fail: "endpoint feature controls spaces space with no features disabled endpoint app shows 'Hello World'"
[00:30:38]                   │

Stack Trace

Error: expected testSubject(welcomeTitle) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)

History

  • 💔 Build #24470 failed 0798810bcbc532cfc637a71b023daf0cc048896a
  • 💔 Build #24192 failed aa4df96ba378dbd05e00381570a404dc9c2fc8db

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 7, 2020
@Kerry350 Kerry350 mentioned this pull request Feb 11, 2020
Merged
@joshdover joshdover force-pushed the np/history-wrapper branch 7 times, most recently from 4a9179a to c828156 Compare February 14, 2020 17:11
@joshdover joshdover mentioned this pull request Feb 14, 2020
Merged
joshdover
joshdover commented Feb 18, 2020
View reviewed changes
test/plugin_functional/test_suites/core_plugins/legacy_plugins.ts
@@ -45,7 +45,7 @@ export default function({ getService, getPageObjects }: PluginFunctionalProvider

describe('application service compatibility layer', () => {
it('can render legacy apps', async () => {
await PageObjects.common.navigateToApp('core_plugin_legacy');
await PageObjects.common.navigateToApp('core_legacy_compat');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed due to bug fix in #57542

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@joshdover
Copy link
Contributor Author

I cannot currently test this on IE since master is currently broken for IE (#58108)

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@joshdover
Copy link
Contributor Author

Was hoping to test IE11 before merging this, but it is still broken on master (and I haven't had time to dig into it yet).

I don't suspect any breakages since this is mostly a thin wrapper on top of the existing history implementation and it does not directly interact with any browser APIs.

Therefore, I'm going to merge this once CI passes and make a note to test on IE once it is fixed in master.

walterra
walterra approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_and_spaces.x-pack/test/saved_object_api_integration/security_and_spaces/apis/find·ts.saved objects security and spaces enabled find rbac user with all at other space within the default space "before all" hook for "finding a hiddentype should return 403 with forbidden find hiddentype message"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: saved objects security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_space_1_all_user]
[00:00:02]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [not_a_kibana_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_legacy_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_dual_privileges_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_dashboard_only_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_default_space_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_default_space_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_space_1_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_space_1_read_user]
[00:05:09]               └-> "after all" hook
[00:04:35]           └-: find
[00:04:35]             └-> "before all" hook
[00:05:09]                 └-> "after all" hook
[00:04:59]             └-: rbac user with all at other space within the default space
[00:04:59]               └-> "before all" hook
[00:04:59]               └-> "before all" hook
[00:04:59]                 │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:59]                 │ info [saved_objects/spaces] Loading "data.json"
[00:04:59]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana_2/B83515OSQ7eaBF37aj61hg] deleting index
[00:04:59]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana_1/syF6z1i3SbidtSTz338Lbg] deleting index
[00:04:59]                 │ info [saved_objects/spaces] Deleted existing index [".kibana_2",".kibana_1"]
[00:04:59]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:04:59]                 │ info [r.suppressed] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] path: /.kibana/_doc/telemetry%3Atelemetry, params: {index=.kibana, id=telemetry:telemetry}
[00:04:59]                 │      org.elasticsearch.action.NoShardAvailableActionException: No shard available for [get [.kibana][telemetry:telemetry]: routing [null]]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.perform(TransportSingleShardAction.java:224) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.onFailure(TransportSingleShardAction.java:210) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction$2.handleException(TransportSingleShardAction.java:266) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1067) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.processException(TransportService.java:1176) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.sendResponse(TransportService.java:1150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TaskTransportChannel.sendResponse(TaskTransportChannel.java:60) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.ChannelActionListener.onFailure(ChannelActionListener.java:56) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.onFailure(ActionRunnable.java:88) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.onFailure(ThreadContext.java:676) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:39) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:04:59]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:04:59]                 │      Caused by: org.elasticsearch.transport.RemoteTransportException: [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890][127.0.0.1:6153][indices:data/read/get[s]]
[00:04:59]                 │      Caused by: org.elasticsearch.index.shard.IllegalIndexShardStateException: CurrentState[RECOVERING] operations only allowed when shard state is one of [POST_RECOVERY, STARTED]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.readAllowed(IndexShard.java:1685) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.get(IndexShard.java:905) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.innerGet(ShardGetService.java:174) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:104) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:95) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:106) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:45) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:58) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:73) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:688) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	... 3 more
[00:04:59]                 │ proc [kibana] internal/process/warning.js:153
[00:04:59]                 │ proc [kibana]         throw warning;
[00:04:59]                 │ proc [kibana]         ^
[00:04:59]                 │ proc [kibana] 
[00:04:59]                 │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:04:59]                 │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:04:59]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:04:59]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:04:59]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:04:59]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:04:59]                 │ info [saved_objects/spaces] Created index ".kibana"
[00:04:59]                 │ debg [saved_objects/spaces] ".kibana" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:59]                 └- ✖ fail: "saved objects security and spaces enabled find rbac user with all at other space within the default space "before all" hook"
[00:04:59]                 │
[00:04:59]                 └-> "after all" hook
[00:04:59]                   │ info [saved_objects/spaces] Indexed 16 docs into ".kibana"
[00:04:59]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=1/5)
[00:04:59]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana/RYBvt7_-SqW2fFO3tnLkzg] update_mapping [_doc]
[00:04:59]                   │ debg Migrating saved objects
[00:04:59]                   │ERROR [migrate saved objects] request failed (attempt=1/5)
[00:05:00]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=2/5)
[00:05:00]                   │ERROR [migrate saved objects] request failed (attempt=2/5)
[00:05:02]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=3/5)
[00:05:02]                   │ERROR [migrate saved objects] request failed (attempt=3/5)
[00:05:05]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=4/5)
[00:05:05]                   │ERROR [migrate saved objects] request failed (attempt=4/5)
[00:05:09]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=5/5)
[00:05:09]                   └- ✖ fail: "saved objects security and spaces enabled find rbac user with all at other space within the default space "after all" hook for "finding a hiddentype should return 403 with forbidden find hiddentype message""
[00:05:09]                   │

Stack Trace

{ DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    at emitDeprecationWarning (internal/process/promises.js:111:13)
    at emitWarning (internal/process/promises.js:104:3)
    at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
    at process._tickCallback (internal/process/next_tick.js:69:34)
  name: 'DeprecationWarning',
  code: 'DEP0018',
  uncaught: true,
  multiple:
   [ Error: [migrate saved objects] request failed (attempt=5/5) -- and ran out of retries
         at KbnClientRequester.request (/dev/shm/workspace/kibana/packages/kbn-dev-utils/target/kbn_client/kbn_client_requester.js:99:23)
         at process._tickCallback (internal/process/next_tick.js:68:7) ] }
Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_and_spaces.x-pack/test/saved_object_api_integration/security_and_spaces/apis/find·ts.saved objects security and spaces enabled find rbac user with all at other space within the default space "after all" hook for "finding a hiddentype should return 403 with forbidden find hiddentype message"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: saved objects security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_space_1_all_user]
[00:00:02]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [not_a_kibana_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_legacy_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_dual_privileges_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_dashboard_only_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_default_space_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_default_space_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_space_1_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_space_1_read_user]
[00:04:35]           └-: find
[00:04:35]             └-> "before all" hook
[00:04:59]             └-: rbac user with all at other space within the default space
[00:04:59]               └-> "before all" hook
[00:04:59]               └-> "before all" hook
[00:04:59]                 │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:59]                 │ info [saved_objects/spaces] Loading "data.json"
[00:04:59]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana_2/B83515OSQ7eaBF37aj61hg] deleting index
[00:04:59]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana_1/syF6z1i3SbidtSTz338Lbg] deleting index
[00:04:59]                 │ info [saved_objects/spaces] Deleted existing index [".kibana_2",".kibana_1"]
[00:04:59]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:04:59]                 │ info [r.suppressed] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] path: /.kibana/_doc/telemetry%3Atelemetry, params: {index=.kibana, id=telemetry:telemetry}
[00:04:59]                 │      org.elasticsearch.action.NoShardAvailableActionException: No shard available for [get [.kibana][telemetry:telemetry]: routing [null]]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.perform(TransportSingleShardAction.java:224) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.onFailure(TransportSingleShardAction.java:210) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction$2.handleException(TransportSingleShardAction.java:266) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1067) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.processException(TransportService.java:1176) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.sendResponse(TransportService.java:1150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TaskTransportChannel.sendResponse(TaskTransportChannel.java:60) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.ChannelActionListener.onFailure(ChannelActionListener.java:56) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.onFailure(ActionRunnable.java:88) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.onFailure(ThreadContext.java:676) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:39) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:04:59]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:04:59]                 │      Caused by: org.elasticsearch.transport.RemoteTransportException: [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890][127.0.0.1:6153][indices:data/read/get[s]]
[00:04:59]                 │      Caused by: org.elasticsearch.index.shard.IllegalIndexShardStateException: CurrentState[RECOVERING] operations only allowed when shard state is one of [POST_RECOVERY, STARTED]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.readAllowed(IndexShard.java:1685) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.get(IndexShard.java:905) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.innerGet(ShardGetService.java:174) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:104) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:95) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:106) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:45) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:58) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:73) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:688) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	... 3 more
[00:04:59]                 │ proc [kibana] internal/process/warning.js:153
[00:04:59]                 │ proc [kibana]         throw warning;
[00:04:59]                 │ proc [kibana]         ^
[00:04:59]                 │ proc [kibana] 
[00:04:59]                 │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:04:59]                 │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:04:59]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:04:59]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:04:59]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:04:59]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:04:59]                 │ info [saved_objects/spaces] Created index ".kibana"
[00:04:59]                 │ debg [saved_objects/spaces] ".kibana" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:59]                 └- ✖ fail: "saved objects security and spaces enabled find rbac user with all at other space within the default space "before all" hook"
[00:04:59]                 │
[00:04:59]                 └-> "after all" hook
[00:04:59]                   │ info [saved_objects/spaces] Indexed 16 docs into ".kibana"
[00:04:59]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=1/5)
[00:04:59]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana/RYBvt7_-SqW2fFO3tnLkzg] update_mapping [_doc]
[00:04:59]                   │ debg Migrating saved objects
[00:04:59]                   │ERROR [migrate saved objects] request failed (attempt=1/5)
[00:05:00]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=2/5)
[00:05:00]                   │ERROR [migrate saved objects] request failed (attempt=2/5)
[00:05:02]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=3/5)
[00:05:02]                   │ERROR [migrate saved objects] request failed (attempt=3/5)
[00:05:05]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=4/5)
[00:05:05]                   │ERROR [migrate saved objects] request failed (attempt=4/5)
[00:05:09]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=5/5)
[00:05:09]                   └- ✖ fail: "saved objects security and spaces enabled find rbac user with all at other space within the default space "after all" hook for "finding a hiddentype should return 403 with forbidden find hiddentype message""
[00:05:09]                   │

Stack Trace

Error: [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=5/5) -- and ran out of retries
    at KbnClientRequester.request (/dev/shm/workspace/kibana/packages/kbn-dev-utils/target/kbn_client/kbn_client_requester.js:99:23)
    at process._tickCallback (internal/process/next_tick.js:68:7)
Kibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_and_spaces.x-pack/test/saved_object_api_integration/security_and_spaces/apis/find·ts.saved objects security and spaces enabled find rbac user with all at other space within the default space "before all" hook for "finding a hiddentype should return 403 with forbidden find hiddentype message"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: saved objects security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_legacy_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_dual_privileges_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_dual_privileges_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_dashboard_only_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_default_space_all_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_default_space_read_user]
[00:00:01]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_space_1_all_user]
[00:00:02]             │ info [o.e.x.s.a.r.TransportPutRoleAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added role [kibana_rbac_space_1_read_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [not_a_kibana_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_legacy_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_dual_privileges_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_dual_privileges_dashboard_only_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_user]
[00:00:02]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_dashboard_only_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_default_space_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_default_space_read_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_space_1_all_user]
[00:00:03]             │ info [o.e.x.s.a.u.TransportPutUserAction] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] added user [a_kibana_rbac_space_1_read_user]
[00:05:09]               └-> "after all" hook
[00:04:35]           └-: find
[00:04:35]             └-> "before all" hook
[00:05:09]                 └-> "after all" hook
[00:04:59]             └-: rbac user with all at other space within the default space
[00:04:59]               └-> "before all" hook
[00:04:59]               └-> "before all" hook
[00:04:59]                 │ info [saved_objects/spaces] Loading "mappings.json"
[00:04:59]                 │ info [saved_objects/spaces] Loading "data.json"
[00:04:59]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana_2/B83515OSQ7eaBF37aj61hg] deleting index
[00:04:59]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana_1/syF6z1i3SbidtSTz338Lbg] deleting index
[00:04:59]                 │ info [saved_objects/spaces] Deleted existing index [".kibana_2",".kibana_1"]
[00:04:59]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:04:59]                 │ info [r.suppressed] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] path: /.kibana/_doc/telemetry%3Atelemetry, params: {index=.kibana, id=telemetry:telemetry}
[00:04:59]                 │      org.elasticsearch.action.NoShardAvailableActionException: No shard available for [get [.kibana][telemetry:telemetry]: routing [null]]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.perform(TransportSingleShardAction.java:224) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction.onFailure(TransportSingleShardAction.java:210) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction$AsyncSingleAction$2.handleException(TransportSingleShardAction.java:266) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1067) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.processException(TransportService.java:1176) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.sendResponse(TransportService.java:1150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.transport.TaskTransportChannel.sendResponse(TaskTransportChannel.java:60) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.ChannelActionListener.onFailure(ChannelActionListener.java:56) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.onFailure(ActionRunnable.java:88) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.onFailure(ThreadContext.java:676) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:39) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:04:59]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:04:59]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:04:59]                 │      Caused by: org.elasticsearch.transport.RemoteTransportException: [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890][127.0.0.1:6153][indices:data/read/get[s]]
[00:04:59]                 │      Caused by: org.elasticsearch.index.shard.IllegalIndexShardStateException: CurrentState[RECOVERING] operations only allowed when shard state is one of [POST_RECOVERY, STARTED]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.readAllowed(IndexShard.java:1685) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.shard.IndexShard.get(IndexShard.java:905) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.innerGet(ShardGetService.java:174) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:104) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.index.get.ShardGetService.get(ShardGetService.java:95) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:106) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.get.TransportGetAction.shardOperation(TransportGetAction.java:45) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.support.single.shard.TransportSingleShardAction.lambda$asyncShardOperation$0(TransportSingleShardAction.java:110) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:58) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.action.ActionRunnable$2.doRun(ActionRunnable.java:73) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:688) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:37) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:04:59]                 │      	... 3 more
[00:04:59]                 │ proc [kibana] internal/process/warning.js:153
[00:04:59]                 │ proc [kibana]         throw warning;
[00:04:59]                 │ proc [kibana]         ^
[00:04:59]                 │ proc [kibana] 
[00:04:59]                 │ proc [kibana] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[00:04:59]                 │ proc [kibana]     at emitDeprecationWarning (internal/process/promises.js:111:13)
[00:04:59]                 │ proc [kibana]     at emitWarning (internal/process/promises.js:104:3)
[00:04:59]                 │ proc [kibana]     at emitPromiseRejectionWarnings (internal/process/promises.js:143:7)
[00:04:59]                 │ proc [kibana]     at process._tickCallback (internal/process/next_tick.js:69:34)
[00:04:59]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:04:59]                 │ info [saved_objects/spaces] Created index ".kibana"
[00:04:59]                 │ debg [saved_objects/spaces] ".kibana" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:04:59]                 └- ✖ fail: "saved objects security and spaces enabled find rbac user with all at other space within the default space "before all" hook"
[00:04:59]                 │
[00:04:59]                 └-> "after all" hook
[00:04:59]                   │ info [saved_objects/spaces] Indexed 16 docs into ".kibana"
[00:04:59]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=1/5)
[00:04:59]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1582737631067913890] [.kibana/RYBvt7_-SqW2fFO3tnLkzg] update_mapping [_doc]
[00:04:59]                   │ debg Migrating saved objects
[00:04:59]                   │ERROR [migrate saved objects] request failed (attempt=1/5)
[00:05:00]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=2/5)
[00:05:00]                   │ERROR [migrate saved objects] request failed (attempt=2/5)
[00:05:02]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=3/5)
[00:05:02]                   │ERROR [migrate saved objects] request failed (attempt=3/5)
[00:05:05]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=4/5)
[00:05:05]                   │ERROR [migrate saved objects] request failed (attempt=4/5)
[00:05:09]                   │ERROR [GET http://elastic:changeme@localhost:6151/api/status] request failed (attempt=5/5)
[00:05:09]                   └- ✖ fail: "saved objects security and spaces enabled find rbac user with all at other space within the default space "after all" hook for "finding a hiddentype should return 403 with forbidden find hiddentype message""
[00:05:09]                   │

Stack Trace

Error: [migrate saved objects] request failed (attempt=5/5) -- and ran out of retries
    at KbnClientRequester.request (/dev/shm/workspace/kibana/packages/kbn-dev-utils/target/kbn_client/kbn_client_requester.js:99:23)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 4cb9bc4 into elastic:master Feb 26, 2020
@joshdover joshdover deleted the np/history-wrapper branch February 26, 2020 19:43
joshdover added a commit to joshdover/kibana that referenced this pull request Feb 26, 2020
@joshdover
Add ScopedHistory to AppMountParams (elastic#56705)
95bacb3
@joshdover joshdover mentioned this pull request Feb 26, 2020
Merged
joshdover added a commit that referenced this pull request Feb 26, 2020
@joshdover
[7.x] Add ScopedHistory to AppMountParams (#56705) (#58639)
cbb96a7
@joshdover joshdover mentioned this pull request Feb 27, 2020
Merged
7 tasks
@mattkime mattkime mentioned this pull request Mar 5, 2020
Closed
@joshdover joshdover mentioned this pull request Mar 19, 2020
Closed
@paul-tavares paul-tavares mentioned this pull request Mar 20, 2020
Merged
3 tasks
paul-tavares added a commit to paul-tavares/kibana that referenced this pull request Mar 20, 2020
@paul-tavares
Remove use of appBasePath and use history for initializing router
f90253c 
- For details - see elastic#56705
@paul-tavares paul-tavares mentioned this pull request Mar 20, 2020
Merged
2 tasks
paul-tavares added a commit that referenced this pull request Mar 26, 2020
@paul-tavares
[Endpoint] Common PageView and LinkToApp components (#60819)
af316c5 
* a common PageView component
* Policy List cleanup + improvements to PageView
* Policy details refactored to use PageView layout
* Fix bug: header nav - ensure section sub-routes set nav to `isSelected`
* Added useNavigateToAppEventHandler hook
* Remove use of `appBasePath` and use `history` for initializing router
  - For details - see #56705
* Removed `hello-world` API
* Added `LinkToApp` component + refactor policy list to use it
* Add icon to plugin registration
paul-tavares added a commit that referenced this pull request Mar 27, 2020
@paul-tavares
[Endpoint] Common PageView and LinkToApp components (#60819) (#61555)
600d85c 
* a common PageView component
* Policy List cleanup + improvements to PageView
* Policy details refactored to use PageView layout
* Fix bug: header nav - ensure section sub-routes set nav to `isSelected`
* Added useNavigateToAppEventHandler hook
* Remove use of `appBasePath` and use `history` for initializing router
  - For details - see #56705
* Removed `hello-world` API
* Added `LinkToApp` component + refactor policy list to use it
* Add icon to plugin registration
@tsullivan tsullivan mentioned this pull request Jul 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant left review comments

@mshustov mshustov mshustov approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@flash1293 flash1293 flash1293 approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Possible bugs due to different instances of history in NP apps
8 participants
@joshdover @elasticmachine @Dosant @pgayvallet @kibanamachine @walterra @flash1293 @mshustov