Implement/better error reading #5611
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ define(function (require) { | |||
| }); | |||
|
|
|||
| if (!myHandlers.length) { | |||
| notify.fatal(new Error('unhandled error ' + (error.stack || error.message))); | |||
| notify.fatal(new Error(`unhandled courier request error: ${ notify.describeError(error) }`)); | |||
There was a problem hiding this comment.
Technically this changes the behavior of this particular handler, since the previous behavior was to use error.stack if it did exist, whereas describeError will use error.message regardless. That's probably not a big deal though since this only used in fatal exceptions, so nothing would programmatically be relying on the contents of the string.
There was a problem hiding this comment.
Right, that was intentional. The stack trace to this location is always the same. There isn't any value in the non-async stack trace
|
Might want to merge master back into this now that the notifier stuff is merged, but this LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #5610
This implements a simple
describeErrormethod that will inspect an error object and try to read it in an optimal way. This allows generic error handlers, like this one in the courier, to be smart about how the error is presented to the user.In this new method the only change to functionality pertains to the way that errors from HTTP requests are displayed. Now, if the error has a
.body.messageproperty it is assumed to be a message sent from boom via the server and is used in place of theerror.message, which simply described the error type with a generic HTTP term (like "Forbidden", or "Not Found")