Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin installer] removed github support #5592

Merged

Conversation

BigFunger
Copy link
Contributor

Fixes #5591

  • Removed default github url support. (functionality still supported by using the --url argument)
  • Renamed all files using snake-case

@epixa
Copy link
Contributor

epixa commented Dec 8, 2015

Not a huge deal, but in the future would you mind doing a changeset like this in two commits: one for the removal of github support and the other for renames. It's easier to review each of those changes individually, and commits are a logical way to handle that.

@BigFunger BigFunger force-pushed the plugin-installer-remove-github-support branch from 8cf59e3 to 8842535 Compare December 8, 2015 18:34
@rashidkpc
Copy link
Contributor

This LGTM from a code standpoint, but can you update the docs: https://github.com/elastic/kibana/blob/master/docs/plugins.asciidoc

@epixa
Copy link
Contributor

epixa commented Dec 18, 2015

This needs master to be merged into it

@rashidkpc
Copy link
Contributor

Needs master merge, and still need docs

@rashidkpc rashidkpc assigned BigFunger and unassigned panda01 Dec 21, 2015
@palecur palecur assigned palecur and unassigned BigFunger Dec 21, 2015
@palecur
Copy link

palecur commented Dec 21, 2015

PR #5745 with the doc update is up.

@BigFunger
Copy link
Contributor Author

jenkins, test it

BigFunger added a commit that referenced this pull request Dec 22, 2015
…b-support

[plugin installer] removed github support
@BigFunger BigFunger merged commit 499b0c1 into elastic:master Dec 22, 2015
@epixa epixa removed the v4.4.0 label Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants