Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable skipped tests for unmuting an alert #55861

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Re-enable skipped tests for unmuting an alert #55861

merged 2 commits into from
Jan 27, 2020

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Jan 24, 2020 •
edited
Loading

Resolves #54125

In this PR, I'm re-enabling the test for unmuting an alert. It was previously skipped here #54125 (comment) but realized after the actual issue was in 7.6 where #55095 was not backported to. I have now backported the fix in 7.6 and this test should no longer be flaky.

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 24, 2020
@mikecote mikecote self-assigned this Jan 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor Author

42x run: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/143/

@mikecote
Copy link
Contributor Author

@elasticmachine merge upstream

@mikecote mikecote requested a review from a team January 27, 2020 13:11
pmuellr
pmuellr approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; 🤞

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit 72a8da2 into elastic:master Jan 27, 2020
mikecote added a commit to mikecote/kibana that referenced this pull request Jan 27, 2020
@mikecote @elasticmachine
Re-enable skipped tests for unmuting an alert (elastic#55861)
f3ecb20 
Co-authored-by: Elastic Machine <[email protected]>
@mikecote mikecote mentioned this pull request Jan 27, 2020
Merged
mikecote added a commit that referenced this pull request Jan 27, 2020
@mikecote @elasticmachine
Re-enable skipped tests for unmuting an alert (#55861) (#56009)
a20ace3 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

Assignees

@mikecote mikecote

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@mikecote @elasticmachine @kibanamachine @pmuellr