Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CANVAS] Update Canvas usage of Storage from kibana-utils #55595

Merged
merged 3 commits into from
Feb 14, 2020
Merged

[CANVAS] Update Canvas usage of Storage from kibana-utils #55595

merged 3 commits into from
Feb 14, 2020

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Jan 22, 2020

Summary

Storage class was being pulled in as part of our plugin setup, but it's just a static import thing, and should be imported as such.

So this PR removes Storage from all the plugin definition stuff and just imports it directly in clipboard. Also moves clipboard and it's test to TS.

@crob611 crob611 added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v7.7.0 labels Jan 22, 2020
@crob611 crob611 requested a review from a team as a code owner January 22, 2020 18:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

poffdeluxe
poffdeluxe approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crob611
Copy link
Contributor Author

crob611 commented Feb 13, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@crob611
Copy link
Contributor Author

crob611 commented Feb 14, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit 98564f8 into elastic:master Feb 14, 2020
crob611 pushed a commit to crob611/kibana that referenced this pull request Feb 21, 2020
@elasticmachine
Update Canvas usage of Storage from kibana-utils (elastic#55595)
d2328b2 
Co-authored-by: Elastic Machine <[email protected]>
@crob611 crob611 mentioned this pull request Feb 21, 2020
Merged
crob611 pushed a commit that referenced this pull request Mar 9, 2020
@elasticmachine
Update Canvas usage of Storage from kibana-utils (#55595) (#58278)
1ba3f89 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crob611 @elasticmachine @kibanamachine @poffdeluxe