Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency @elastic/charts to v17 #55376

Merged
merged 7 commits into from
Feb 6, 2020
Merged

Update dependency @elastic/charts to v17 #55376

merged 7 commits into from
Feb 6, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 21, 2020 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
@elastic/charts devDependencies major ^16.1.0 -> ^17.0.0
@elastic/charts dependencies major ^16.1.0 -> ^17.0.0

Release Notes

elastic/elastic-charts

v17.0.0

Compare Source

Bug Fixes
Features
BREAKING CHANGES
  • listeners: the onElementOver and the onElementClick are now called with
    Array<[GeometryValue, SeriesIdentifier]> instead of Array<GeometryValue>
  • renames in Partition charts— Layers: fillLabel.formatter->fillLabel.valueFormatter; type FillLabel-> FillLabelConfig

Non-breaking changes:

  • feat: the values in linked labels are rendered, just like they have been in the sectors (formerly, the value could optionally be put in the link label accessor itself)

  • feat: font styling is possible separately for values: valueFormatter configs

  • test: opacity decrease example; coloring examples

  • feat: hierarchical data (parent, sortIndex) is made available to accessors (see stories, helpful with eg. coloring)

  • refactor: tighter types; other code improvements

16.2.1 (2020-01-23)

Bug Fixes

v16.2.1

Compare Source

Bug Fixes
Features
BREAKING CHANGES
  • listeners: the onElementOver and the onElementClick are now called with
    Array<[GeometryValue, SeriesIdentifier]> instead of Array<GeometryValue>
  • renames in Partition charts— Layers: fillLabel.formatter->fillLabel.valueFormatter; type FillLabel-> FillLabelConfig

Non-breaking changes:

  • feat: the values in linked labels are rendered, just like they have been in the sectors (formerly, the value could optionally be put in the link label accessor itself)

  • feat: font styling is possible separately for values: valueFormatter configs

  • test: opacity decrease example; coloring examples

  • feat: hierarchical data (parent, sortIndex) is made available to accessors (see stories, helpful with eg. coloring)

  • refactor: tighter types; other code improvements

16.2.1 (2020-01-23)

Bug Fixes

v16.2.0

Compare Source

Features
  • implement treemap, sunburst, pie and donut charts (#​493) (e4de627)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you tick the rebase/retry checkbox below.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 21, 2020 12:10
@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:Operations Team label for Operations Team v7.6.0 v8.0.0 labels Jan 21, 2020
@renovate renovate bot requested a review from markov00 January 21, 2020 12:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@LeeDr
Copy link

LeeDr commented Jan 22, 2020

I'm not sure this renovate bot should be usingi the v7.6.0 label after we've passed Feature Freeze for the release. Only should be merged if it's fixing identified bugs at this point.

@LeeDr LeeDr added v7.7.0 and removed v7.6.0 labels Jan 22, 2020
@renovate renovate bot force-pushed the renovate/@elasticcharts branch from 9b729da to 4ebab0a Compare January 23, 2020 19:55
@renovate renovate bot changed the title Update dependency @elastic/charts to ^16.2.0 Update dependency @elastic/charts to ^16.2.1 Jan 23, 2020
wylieconlon
wylieconlon approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was working on a change that needed 16.2.1, this upgrade is doing the same thing

@renovate renovate bot force-pushed the renovate/@elasticcharts branch from 4ebab0a to e8aa25a Compare January 30, 2020 20:26
@renovate renovate bot changed the title Update dependency @elastic/charts to ^16.2.1 Update dependency @elastic/charts to v17 Jan 30, 2020
@renovate
Copy link
Contributor Author

renovate bot commented Jan 30, 2020

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻️ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you check the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
error An unexpected error occurred: "Cannot use 'in' operator to search for '@babel/core' in ../yarn.lock".

@renovate
Copy link
Contributor Author

renovate bot commented Feb 5, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@renovate renovate bot requested a review from a team February 5, 2020 01:11
@nickofthyme
Copy link
Contributor

nickofthyme commented Feb 5, 2020 •
edited
Loading

@elastic/kibana-operations Could you explain this new kbn-ui-shared-deps package seems to be a replacement for @elastic/charts in the root package.json but they are all devDependencies. Thanks

@mistic
Copy link
Member

mistic commented Feb 5, 2020

@nickofthyme this new kbn-ui-shared-deps is a new package to compile together special ui dependencies that should only exist once in the bundles (ex: react, moment..). There is a small explanation here https://github.com/elastic/kibana/blob/master/packages/kbn-ui-shared-deps/README.md and here #54079 (comment)

@nickofthyme
Copy link
Contributor

@mistic thanks for the links. So for updating one of these dependencies I need to update package.json and packages/kbn-ui-shared-deps/package.json?

wylieconlon
wylieconlon approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did not test

@mistic
Copy link
Member

mistic commented Feb 5, 2020

@nickofthyme yeah exactly and finally also export the key here https://github.com/elastic/kibana/blob/master/packages/kbn-ui-shared-deps/index.js

@nickofthyme
Copy link
Contributor

@mistic cool, so the ops team wants to be code owner for all changes to packages/kbn-ui-shared-deps/package.json? If that's the case, could you approve this pr?

@renovate renovate bot force-pushed the renovate/@elasticcharts branch from 24dcea4 to a256aa8 Compare February 5, 2020 16:32
@nickofthyme nickofthyme force-pushed the renovate/@elasticcharts branch from a256aa8 to 4d41a2f Compare February 5, 2020 19:20
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit ce95f12 into master Feb 6, 2020
@nickofthyme nickofthyme deleted the renovate/@elasticcharts branch February 6, 2020 15:46
nickofthyme added a commit to nickofthyme/kibana that referenced this pull request Feb 24, 2020
@renovate @renovate-bot @nickofthyme
Update dependency @elastic/charts to v17 (elastic#55376)
59ed813 
* Update dependency @elastic/charts to v17

* Update yarn.lock

* Fix type errors

* Update to latest version

Co-authored-by: WhiteSource Renovate <[email protected]>
Co-authored-by: Nick Partridge <[email protected]>
@nickofthyme nickofthyme mentioned this pull request Feb 24, 2020
Merged
nickofthyme added a commit that referenced this pull request Feb 24, 2020
@nickofthyme
Update dependency @elastic/charts to v17 (#55376) (#58382)
b2d703c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

@markov00 markov00 Awaiting requested review from markov00

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:Operations Team label for Operations Team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@elasticmachine @LeeDr @nickofthyme @mistic @kibanamachine @wylieconlon @renovate-bot