New Advanced settings test #5526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 25, 2015 14:36
…nced settings. This allows functional UI automation to find the row and child form fields (not used by any automation yet).
…o advancedSettings
…le test automation. Add a test for Advanced Settings.
…lection. Adding 1 second sleep to see if it's timing.
| }, | ||
|
|
||
| findTestSubject: function findTestSubject(selector) { | ||
| console.log('in findTestSubject: ' + selector); |
…e sure I had clean output.
|
@spalger Travis tests haven't finished yet but we're not running these tests on Travis anyway. |
| bdd.before(function () { | ||
| common = new Common(this.remote); | ||
| settingsPage = new SettingsPage(this.remote); | ||
| remote = this.remote; |
There was a problem hiding this comment.
var remote doesn't look like it's used anywhere
|
Made some small comments, LGTM otherwise! |
|
@jbudz You might want to take another quick look at this since I changed case in a few places. It all passes. |
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
…le test automation. Add a test for Advanced Settings. Fixes #5526
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
…lection. Adding 1 second sleep to see if it's timing. Fixes #5526
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
…e sure I had clean output. Fixes #5526
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
…nced settings. This allows functional UI automation to find the row and child form fields (not used by any automation yet). Fixes #5526
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
…le test automation. Add a test for Advanced Settings. Fixes #5526
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
…lection. Adding 1 second sleep to see if it's timing. Fixes #5526
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
…e sure I had clean output. Fixes #5526
LeeDr
pushed a commit
that referenced
this pull request
Dec 8, 2015
This was referenced Dec 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to set timezone to UTC to make visualize tests pass both locally and on Travis and Jenkins. We found a way to set it when we load a test kibana index, but the investigation still led to some test-ability improvements and a test case for Advanced Settings.