Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NA): recursive delete function on watch cache directory #54758

Merged
merged 1 commit into from
Jan 14, 2020
Merged

fix(NA): recursive delete function on watch cache directory #54758

merged 1 commit into from
Jan 14, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 14, 2020

That fixes a problem introduced by #54457

Currently, on master, trying to yarn start after yarn kbn clean outputs the following error:

{ [Error: ENOENT: no such file or directory, scandir 'kibana/built_assets/.cache/ui_bundles']
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path:
   'kibana/built_assets/.cache/ui_bundles' }

 FATAL  Error: ENOENT: no such file or directory, scandir 'kibana/built_assets/.cache/ui_bundles'

That happens because readdirAsync throws an unhandled exception.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 14, 2020
@mistic mistic requested a review from tylersmalley January 14, 2020 16:38
@mistic mistic requested a review from a team as a code owner January 14, 2020 16:38
@mistic mistic self-assigned this Jan 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

tylersmalley
tylersmalley approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also tested with what was described in #54457

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 5738855 into elastic:master Jan 14, 2020
mistic added a commit to mistic/kibana that referenced this pull request Jan 14, 2020
@mistic
fix(NA): recursive delete function on watch cache directory (elastic#…
4dada34 
…54758)
@mistic mistic mentioned this pull request Jan 14, 2020
Merged
@mistic
Copy link
Member Author

mistic commented Jan 14, 2020 •
edited
Loading

7.x: 81d9c40

mistic added a commit that referenced this pull request Jan 14, 2020
@mistic
fix(NA): recursive delete function on watch cache directory (#54758) (#…
81d9c40 
…54802)
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@mistic @jkelastic
fix(NA): recursive delete function on watch cache directory (elastic#…
d9d0845 
…54758)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees

@mistic mistic

Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistic @elasticmachine @kibanamachine @tylersmalley