Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #34666 #54612

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Backport #34666 #54612

merged 2 commits into from
Jan 13, 2020

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Jan 13, 2020

It looks like this PR #34666 was never backported. Most of the changes were backported through other PRs (mostly i18n work) but this gets the rest of the changes.

@crob611 crob611 added backport release_note:skip Skip the PR/issue when compiling release notes labels Jan 13, 2020
ryankeairns
ryankeairns approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches original commit.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit 58f5a45 into elastic:7.x Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
backport release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crob611 @kibanamachine @ryankeairns