Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default NodeJS max heap limit to 250MB. Override by setting NODE_OPTIONS #5451

Closed
wants to merge 2 commits into from
Closed

Default NodeJS max heap limit to 250MB. Override by setting NODE_OPTIONS #5451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50fc3a0
Default NodeJS max heap limit to 250M. Override by setting NODE_OPTIONS
Nov 20, 2015
37d0aeb
Default NodeJS max heap limit to 250M. Override by setting NODE_OPTIO…
mrdavidlaing Nov 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/kibana
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ if [ ! -x "$NODE" ]; then
exit 1
fi

exec "${NODE}" "${DIR}/src/cli" ${@}
NODE_OPTIONS="${NODE_OPTIONS:=--max-old-space-size=250}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line, we decided not to set a default.

exec "${NODE}" $NODE_OPTIONS "${DIR}/src/cli" ${@}

6 changes: 5 additions & 1 deletion bin/kibana.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,12 @@ If Not Exist "%NODE%" (
)
)

if "%NODE_OPTIONS%" == "" (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the defaults, we've decided not to set a default.

set NODE_OPTIONS=--max-old-space-size=250
)

TITLE Kibana Server
"%NODE%" "%DIR%\src\cli" %*
"%NODE%" %NODE_OPTIONS% "%DIR%\src\cli" %*

:finally

Expand Down