Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Update schemas boolean, byteSize, and duration to coerce strings (#54177) #54299

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Jan 8, 2020

Backports the following commits to 7.x:

…stic#54177)

* Update Duration to coerce number strings to numbers (in millis)

* Coerce in a way that's consistent with kbn-config-schema

* Update ByteSizeValue to coerce strings to numbers

* Update Boolean to coerce strings to boolean values

* Fix Jest test

* Address PR review feedback

* Whoops

* Whoops 2

* Whoops 3
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit f2f47eb into elastic:7.x Jan 8, 2020
@jportner jportner deleted the backport/7.x/pr-54177 branch January 8, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants