Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix broken Duration chart on Monitor Page #54251

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

justinkambic
Copy link
Contributor

Summary

Fixes #54110.

For some reason the code was organized in such a way that we could be trying to leverage content that was not present (trying to render the chart when there was no data supplied).

I've simply nested the entire chart in an existing boolean check, rather than only the line series we were skipping previously.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience release_note:fix v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.6.0 labels Jan 8, 2020
@justinkambic justinkambic requested a review from shahzad31 January 8, 2020 13:28
@justinkambic justinkambic self-assigned this Jan 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit a93c23c into elastic:master Jan 8, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 8, 2020
* master:
  Reorganize structure of component render to avoid errors. (elastic#54251)
  [DOCS] consolidate telemetry settings to core (elastic#52634)
  Add file upload to telemetry integration tests (elastic#53539)
  filters are back (elastic#54218)
  Add explanation of path.data to contribution guide (elastic#54235)
  fix ecommerce percentages in sample data (elastic#54200)
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jan 9, 2020
justinkambic added a commit that referenced this pull request Jan 10, 2020
…54367)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@justinkambic
Copy link
Contributor Author

Backported to:
7.x/7.6.0 1006139
#54367

@justinkambic justinkambic deleted the uptime_fix-duration-chart branch January 10, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Duration chart breaking monitor detail page on empty data
4 participants