Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][Detection Engine] Silence 409 errors on signal creation #53859

Merged
merged 5 commits into from
Jan 2, 2020
Merged

[SIEM][Detection Engine] Silence 409 errors on signal creation #53859

merged 5 commits into from
Jan 2, 2020

Commits on Dec 30, 2019

  1. Remove punctuation from translation 

    We already had a colon on both uses of this key, resulting in '::' on
the page.
    @rylnd
    rylnd committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    31deb25 View commit details
    Browse the repository at this point in the history

  2. Ignore 409 errors from our signal creation 

    In my experience these are always due to a rule being run multiple times
on the same document, generating a duplicate signal with a (correctly)
duplicate id. Only if we encounter non-409 errors do we log a message to
the user.
    @rylnd
    rylnd committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    3b9c26e View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Merge branch 'master' into silence_duplicate_signal_errors

    @elasticmachine
    elasticmachine authored Jan 2, 2020
    Configuration menu
    Copy the full SHA
    40dd650 View commit details
    Browse the repository at this point in the history

  2. Hide 409 errors during signal creation 

    These are expected and potentially confusing to the user. Instead, we
only show unexpected errors.
    @rylnd
    rylnd committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    1bcf978 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into silence_duplicate_signal_errors

    @elasticmachine
    elasticmachine authored Jan 2, 2020
    Configuration menu
    Copy the full SHA
    41a300d View commit details
    Browse the repository at this point in the history