Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Support capitalized date formats in snapshot names #53751

Merged
merged 23 commits into from
Jan 13, 2020
Merged

[SR] Support capitalized date formats in snapshot names #53751

Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
0fa149b
Removed toLowerCase() from step_logistics.tsx line 350
jkelastic Dec 22, 2019
3ec83c0
Merge branch 'master' into bugfix/Snapshot_restore
elasticmachine Dec 27, 2019
27092fe
Adding Scheme field to Webhook
jkelastic Dec 23, 2019
d602d4d
Remove debugger breakpoint
jkelastic Dec 23, 2019
f3652ac
Remove debugger tag
jkelastic Dec 23, 2019
8601dd6
Fix undefined path variable and moved scheme field in front of host f…
jkelastic Dec 30, 2019
2b0a12b
Fixed Elint error
jkelastic Dec 30, 2019
62647d8
Merge branch 'master' into bugfix/Snapshot_restore
elasticmachine Dec 30, 2019
722b74f
Merge branch 'master' into bugfix/watcher
elasticmachine Jan 2, 2020
2e4f540
Merge branch 'master' into bugfix/Snapshot_restore
elasticmachine Jan 2, 2020
3c5ffaa
Merge branch 'bugfix/watcher' of https://github.com/jkelastic/kibana …
jkelastic Jan 2, 2020
46b2358
Merge branch 'master' into bugfix/Snapshot_restore
elasticmachine Jan 7, 2020
9adccdd
Merge branch 'bugfix/Snapshot_restore' of https://github.com/jkelasti…
jkelastic Jan 8, 2020
af481e9
Add lower casing check to Snapshot Name L69 in validate_policy.ts
jkelastic Jan 10, 2020
f1df9ec
Correct condition to ignore casing for date format and error out othe…
jkelastic Jan 10, 2020
5a01e5f
Removed jest case I've introduce but was unnecessary
jkelastic Jan 10, 2020
58d763a
Merge branch 'master' into bugfix/Snapshot_restore
elasticmachine Jan 10, 2020
6a6e92d
Rename to isSnapshotNameNotLowerCase and updated if condition to chec…
jkelastic Jan 10, 2020
0ed7f41
Merge branch 'bugfix/Snapshot_restore' of https://github.com/jkelasti…
jkelastic Jan 10, 2020
ef626bc
Merge branch 'master' into bugfix/Snapshot_restore
jkelastic Jan 10, 2020
d6a2102
Merge branch 'master' into bugfix/Snapshot_restore
elasticmachine Jan 10, 2020
6839756
Fix eslint errors.
cjcenizal Jan 10, 2020
41e5358
Merge branch 'master' into bugfix/Snapshot_restore
elasticmachine Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...egacy/plugins/snapshot_restore/public/app/components/policy_form/steps/step_logistics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export const PolicyStepLogistics: React.FunctionComponent<StepProps> = ({
onChange={e => {
updatePolicy(
{
snapshotName: e.target.value.toLowerCase(),
snapshotName: e.target.value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkelastic I think we are on the right track with the proposed changes, I would just like to know what the reason was that we .toLowerCase()ed originally? Did we just never need to take this extra step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jloleysens yes, we never need to take this step as .toLowerCase() on date format will negate MM to mm. The uppercase matters as MM is month and mm is minutes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkelastic see @alisonelizabeth 's comment below, it looks like we need to keep the names lowercase :)

},
{
managedRepository,
Expand Down