NP Migration: Move doc views registry and existing doc views into discover plugin #53465

flash1293 · 2019-12-18T10:56:01Z

Moves the doc views registry into the setup contract of the discover plugin. Default doc views (json view and table) are also moved into the shimmed discover plugin.

Dev docs

The ui/registry/doc_views registry is removed in favor of the same functionality exposed through the setup contract of the discover plugin in core_plugins/kibana.

Old way of registering a doc view:

import { addDocView } from 'ui/registry/doc_views';

addDocView({
  title: '',
  order: 10,
  component: MyComponent,
});

New way of registering a doc view:

import { setup } from '../src/legacy/core_plugins/kibana/public/discover';

setup.addDocView({
  title: '',
  order: 10,
  component: MyComponent,
});

flash1293 · 2019-12-18T11:01:11Z

src/legacy/core_plugins/kibana/public/discover/components/doc/use_es_doc_search.test.tsx

@@ -43,7 +43,7 @@ describe('Test of <Doc /> helper / hook', () => {
    `);
  });

-  test('useEsDocSearch', () => {
+  test('useEsDocSearch', async () => {


This is just a small cleanup getting rid of the async state update outside of act(...) warnings.
The latest react update made it possible to wait for the async updates by using asynchronous act. In the case of this test the assertions assumed no async functions would be called, so the mocks had to be slightly adjusted.

flash1293 · 2019-12-18T11:01:27Z

src/legacy/core_plugins/kibana/public/discover/components/doc/doc.test.tsx

@@ -67,7 +67,7 @@ async function mountDoc(search: () => void, update = false, indexPatternGetter:
    indexPatternService,
  } as DocProps;
  let comp!: ReactWrapper;
-  act(() => {
+  await act(async () => {


Some here - getting rid of react warnings during test run

flash1293 · 2019-12-18T11:02:00Z

src/legacy/core_plugins/kibana/public/discover/components/doc/doc.test.tsx

@@ -25,7 +25,7 @@ import { findTestSubject } from '@elastic/eui/lib/test';
 import { Doc, DocProps } from './doc';

 jest.mock('../doc_viewer/doc_viewer', () => ({
-  DocViewer: 'test',
+  DocViewer: () => null,


If the doc viewer is actually rendered (which happens now because of async act), test throws another warning because it's not a valid react component

mshustov · 2019-12-19T09:53:25Z

src/core/MIGRATION.md

@@ -1173,6 +1173,7 @@ import { setup, start } from '../core_plugins/visualizations/public/legacy';
 | `ui/registry/field_formats`                       | `data.fieldFormats`                                          |                                                                                                                                      |
 | `ui/registry/feature_catalogue`                   | `home.featureCatalogue.register`                             | Must add `home` as a dependency in your kibana.json.                                                                                 |
 | `ui/registry/vis_types`                           | `visualizations.types`                                       | --                                                                                                                                   |
+| `ui/registry/doc_views`                           | `discover.addDocView`                                        | Currently shimmed in the old platform - use `import { setup } from '../kibana/public/discover'; setup.addDocView(...)`                    |


is it ready to be consumed by new platform plugins? it means no webpack imports, no global angular

No, it's still in the legacy world for now, good point. I will remove it.

kertal · 2019-12-19T13:43:17Z

@elasticmachine merge upstream

kertal

Started to test, and have a question, I've added the following code in discover/index.ts, to test if Angular rendering works (it does 👍 )


setup.addDocView({
  title: 'JSON-2',
  order: 30,
  directive: {
    template: '<pre>{{hitJson}}</pre>',
    scope: {
      hit: '=',
    },
    controller: ($scope: any) => {
      $scope.hitJson = JSON.stringify($scope.hit, null, 2);
    },
  },
});

but typescript complains, it might be a Promise, which could be the case, but it isn't here?

That removes the warning, but is it wise? many thx

export const setup = pluginInstance.setup(npSetup.core, {
  ...npSetup.plugins,
  __LEGACY: {
    chrome,
  },
}) as DiscoverSetup;

…gistry

… into shim-doc-views-registry

flash1293 · 2019-12-20T13:29:21Z

Good point @kertal, I improved the types by changing the definition of plugin to:

export const plugin = (context: PluginInitializerContext) => {
  return new DiscoverPlugin();
};

Now .setup will refer to the actual return value of the setup method which is not async. This would also have been resolved by the planned changes to make all lifecycle methods synchronous.

kertal

Code LGTM, didn't test again, but it worked yesterday, also with a legacy angular component.

…gistry

kibanamachine · 2019-12-30T15:50:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: bf25c02

History

💚 Build #16901 succeeded f70388b
💚 Build #16692 succeeded 505f772
💚 Build #16377 succeeded e817686

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-30T17:48:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0b553d7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…gistry

kibanamachine · 2020-01-07T09:57:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 88634c5

History

💚 Build #17493 succeeded d56a8d8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…cover plugin (elastic#53465)

…le-saved-objects * 'master' of github.com:elastic/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ... # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/contexts/services_context.tsx # src/legacy/core_plugins/console/public/np_ready/application/index.tsx

…/kibana into feature/console-saved-objects * 'feature/console-saved-objects' of github.com:jloleysens/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ...

…cover plugin (#53465) (#54137)

flash1293 added 2 commits December 18, 2019 11:33

move doc views registry and existing doc views into discover plugin

f112668

inject chrome properly

e817686

flash1293 added Feature:Discover Discover Application release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 Feature:NP Migration v7.6.0 labels Dec 18, 2019

flash1293 requested a review from a team as a code owner December 18, 2019 10:56

flash1293 commented Dec 18, 2019

View reviewed changes

flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 18, 2019

flash1293 requested a review from kertal December 18, 2019 13:20

mshustov reviewed Dec 19, 2019

View reviewed changes

Merge branch 'master' into shim-doc-views-registry

505f772

kertal reviewed Dec 19, 2019

View reviewed changes

flash1293 added 3 commits December 20, 2019 14:19

Merge remote-tracking branch 'upstream/master' into shim-doc-views-re…

30c4be7

…gistry

remove wrong migration docs and improve types

52faac2

Merge branch 'shim-doc-views-registry' of github.com:flash1293/kibana…

f70388b

… into shim-doc-views-registry

kertal self-requested a review December 20, 2019 16:51

kertal approved these changes Dec 20, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into shim-doc-views-re…

bf25c02

…gistry

flash1293 requested a review from a team December 30, 2019 15:18

elastic deleted a comment from elasticmachine Dec 30, 2019

fix imports

0b553d7

Merge remote-tracking branch 'upstream/master' into shim-doc-views-re…

e7774ed

…gistry

flash1293 added 2 commits December 31, 2019 15:08

fix unit test

d56a8d8

Merge remote-tracking branch 'upstream/master' into shim-doc-views-re…

88634c5

…gistry

flash1293 merged commit c02531a into elastic:master Jan 7, 2020

flash1293 deleted the shim-doc-views-registry branch January 7, 2020 15:53

flash1293 mentioned this pull request Jan 7, 2020

[7.x] NP Migration: Move doc views registry and existing doc views into discover plugin (#53465) #54137

Merged

flash1293 added a commit to flash1293/kibana that referenced this pull request Jan 7, 2020

NP Migration: Move doc views registry and existing doc views into dis…

2e98452

…cover plugin (elastic#53465)

flash1293 added a commit that referenced this pull request Jan 8, 2020

NP Migration: Move doc views registry and existing doc views into dis…

570aec8

…cover plugin (#53465) (#54137)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NP Migration: Move doc views registry and existing doc views into discover plugin #53465

NP Migration: Move doc views registry and existing doc views into discover plugin #53465

flash1293 commented Dec 18, 2019 •

edited

Loading

flash1293 Dec 18, 2019

flash1293 Dec 18, 2019

flash1293 Dec 18, 2019 •

edited

Loading

mshustov Dec 19, 2019

flash1293 Dec 20, 2019

kertal commented Dec 19, 2019

kertal left a comment •

edited

Loading

flash1293 commented Dec 20, 2019

kertal left a comment

kibanamachine commented Dec 30, 2019

kibanamachine commented Dec 30, 2019

kibanamachine commented Jan 7, 2020

NP Migration: Move doc views registry and existing doc views into discover plugin #53465

NP Migration: Move doc views registry and existing doc views into discover plugin #53465

Conversation

flash1293 commented Dec 18, 2019 • edited Loading

Dev docs

flash1293 Dec 18, 2019

Choose a reason for hiding this comment

flash1293 Dec 18, 2019

Choose a reason for hiding this comment

flash1293 Dec 18, 2019 • edited Loading

Choose a reason for hiding this comment

mshustov Dec 19, 2019

Choose a reason for hiding this comment

flash1293 Dec 20, 2019

Choose a reason for hiding this comment

kertal commented Dec 19, 2019

kertal left a comment • edited Loading

Choose a reason for hiding this comment

flash1293 commented Dec 20, 2019

kertal left a comment

Choose a reason for hiding this comment

kibanamachine commented Dec 30, 2019

💔 Build Failed

History

kibanamachine commented Dec 30, 2019

💔 Build Failed

kibanamachine commented Jan 7, 2020

💚 Build Succeeded

History

flash1293 commented Dec 18, 2019 •

edited

Loading

flash1293 Dec 18, 2019 •

edited

Loading

kertal left a comment •

edited

Loading