Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Added safeguard for some EUI components #53318

Merged
merged 6 commits into from
Dec 23, 2019

Conversation

igoristic
Copy link
Contributor

Resolves #52697

This resolves some error/warnings when click on initial no data Metricbeat setup

This was either introduced by https://github.com/elastic/kibana/pull/51100/files#diff-2b7cce7f9c72c72b15f65c30b0aeb499 or EuiToolTip making content prop required

@igoristic igoristic added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Monitoring Stack Monitoring team v8.0.0 v7.6.0 7.5.2 labels Dec 17, 2019
@igoristic igoristic requested a review from a team December 17, 2019 18:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@chrisronline
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from elasticmachine Dec 23, 2019
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@igoristic igoristic merged commit 21d6202 into elastic:master Dec 23, 2019
@igoristic igoristic deleted the mb_setup_fix_2 branch December 23, 2019 16:35
igoristic added a commit that referenced this pull request Dec 23, 2019
* merged master

* addressed feedback

* Addressed feedback

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@igoristic
Copy link
Contributor Author

Backport:
7.x: 73cf5d7

jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 30, 2019
…le-saved-objects

* 'master' of github.com:elastic/kibana: (250 commits)
  Allow chromeless applications to render via non-/app routes (elastic#51527)
  Add server rendering service to enable standalone route rendering (elastic#52161)
  Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220)
  Update maps telemetry mappings to account for recent updates (elastic#53803)
  [Maps] Only show legend when layer is visible (elastic#53781)
  remove use of experimental fs.promises api (elastic#53346)
  [APM] Add log statements for flaky test (elastic#53775)
  [APM] Transaction page throws unhandled exception if transactions doesn't have  `http.request` (elastic#53760)
  Licensing plugin functional tests (elastic#53580)
  [Lens] Disable saving visualization until there are no changes to the document (elastic#52982)
  [Monitoring] Added safeguard for some EUI components (elastic#53318)
  [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605)
  Display changed field formats without requiring hard page refresh. (elastic#53746)
  Upgrade EUI to v17.3.1 (elastic#53655)
  [APM] Fix missing apm indicies (elastic#53541)
  Disable inspector for timelion (elastic#53747)
  Clean up search servie (elastic#53701)
  [Dashboard] Grid: removing double handler (elastic#53707)
  Remove SavedObjectRegistryProvider from codebase (elastic#53455)
  Move ui/courier into data shim plugin (elastic#52359)
  ...
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
* merged master

* addressed feedback

* Addressed feedback

Co-authored-by: Elastic Machine <[email protected]>
@timroes timroes added v7.5.2 and removed 7.5.2 labels Jan 10, 2020
@timroes
Copy link
Contributor

timroes commented Jan 10, 2020

@igoristic @chrisronline Hi, this PR either needs a backport to 7.5, or the 7.5.2 label removed, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported bug Fixes for quality problems that affect the customer experience release_note:fix Team:Monitoring Stack Monitoring team v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring] Initial setup mode with metricbeat migration is broken
5 participants