-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Added safeguard for some EUI components #53318
Conversation
Pinging @elastic/stack-monitoring (Team:Monitoring) |
x-pack/legacy/plugins/monitoring/public/components/alerts/alerts.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/monitoring/public/components/cluster/overview/elasticsearch_panel.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/monitoring/public/components/table/eui_table_ssp.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
* merged master * addressed feedback * Addressed feedback Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Backport: |
…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...
* merged master * addressed feedback * Addressed feedback Co-authored-by: Elastic Machine <[email protected]>
@igoristic @chrisronline Hi, this PR either needs a backport to 7.5, or the 7.5.2 label removed, please. |
Resolves #52697
This resolves some error/warnings when click on initial no data Metricbeat setup
This was either introduced by https://github.com/elastic/kibana/pull/51100/files#diff-2b7cce7f9c72c72b15f65c30b0aeb499 or
EuiToolTip
makingcontent
prop required