Kibana 7.0.0 URL field formatter doesn't render relative hyperlinks properly

[alexwizp]

Closes: #35235

Summary

• HtmlContextTypeConvert, TextContextTypeConvert types were refactored and unified. Now both converters accept 2 arguments: value and options
• 2 new types were created:
  Options for HtmlContextTypeConvert:

/** @internal **/
export interface HtmlContextTypeOptions {
  field?: any;
  hit?: Record<string, any>;
}

Options for TextContextTypeConvert:

/** @internal **/
export type TextContextTypeOptions = Record<string, any>;

• parsedUrl was moved into meta params. Duplicate code was removed across all Kibana

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[alexwizp]

@elasticmachine merge upstream

[alexwizp]

@elasticmachine merge upstream

[alexwizp]

@elasticmachine merge upstream

[alexwizp]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[lukeelmers]

This LGTM! I think I prefer this approach above the others we have discussed so far.

The only thing I think we should add are some functional tests.

[gospodarsky]

Looks real efficiently!

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f16f234

History

• 💚 Build #16392 succeeded 14e9e1d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[lukeelmers]

This all LGTM, thanks for all of the iterations on this! I think we are in a good place.

I'll approve on my end now as I am going to be unavailable next week, but let's wait to merge until we add a functional test to this PR and an approval from @dmlemeshko

We should also open a PR with the "smaller" fix we discussed (the one-line change in pipeline_helpers/utilities where we use getConverterFor instead of convert), which can merge directly into 7.5 branch, so this can ship in 7.5.2. Ideally the functional test would be included in that PR as well as this one.

As for the functional test, the main use case I think we should capture is something like this:

1. Update an IP field in the index patterns so be of type URL
2. Navigate to Discover, assert that the correct HTML is rendered for the IP field
3. Navigate to Visualize, create table vis
4. Split rows with terms agg on IP field
5. Assert that correct HTML is rendered for the IP field

I don't think testing a dashboard is necessary as it should be using the same code which is used in visualize for rendering, but open to your suggestions on this.