[SIEM] [DETECTION ENGINE] Details and Edit view for a rule #53252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
...legacy/plugins/siem/server/lib/detection_engine/routes/schemas/query_signals_index_schema.ts
Show resolved
Hide resolved
spong
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/use_query.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
spong
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/index.tsx
Outdated
Show resolved
Hide resolved
spong
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/api.ts
Show resolved
Hide resolved
spong
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/translations.ts
Outdated
Show resolved
Hide resolved
spong
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/details/index.tsx
Outdated
Show resolved
Hide resolved
spong
reviewed
Dec 17, 2019
x-pack/legacy/plugins/siem/public/pages/detection_engine/translations.ts
Outdated
Show resolved
Hide resolved
add feature to not edit immutable rule
XavierM
force-pushed
the
siem-detection-engine-rule-detail
branch
from
1023188 to
7311d9a
Compare
XavierM
force-pushed
the
siem-detection-engine-rule-detail
branch
from
7311d9a to
0acda85
Compare
…n-engine-rule-detail
spong
reviewed
Dec 19, 2019
spong
reviewed
Dec 19, 2019
| export const RuleSchema = t.intersection([ | ||
| t.type({ | ||
| created_at: t.string, |
There was a problem hiding this comment.
No need to fix here/now as we're moving to API Import/Exporting, but wanted to comment that importing is now not functional as a result of these type changes.
spong
reviewed
Dec 19, 2019
x-pack/legacy/plugins/siem/public/containers/detection_engine/rules/api.ts
Show resolved
Hide resolved
spong
reviewed
Dec 19, 2019
x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/use_query.tsx
Show resolved
Hide resolved
spong
reviewed
Dec 19, 2019
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/details/index.tsx
Outdated
Show resolved
Hide resolved
spong
reviewed
Dec 19, 2019
x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals_info/index.tsx
Show resolved
Hide resolved
spong
reviewed
Dec 19, 2019
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/edit/index.tsx
Show resolved
Hide resolved
spong
reviewed
Dec 19, 2019
x-pack/legacy/plugins/siem/public/pages/detection_engine/translations.ts
Outdated
Show resolved
Hide resolved
spong
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Checked out/tested locally, and performed code review. Great stuff here @XavierM, and good job on the handling immutables and editing of rules. Really comes together and you can get a feel for the whole flow with this addition! LGTM! 👍 🚀 🕵 🚒
20 tasks
…n-engine-rule-detail
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Dec 20, 2019
…3252) * re-structure detection engine + change routing name * add editing/details feature for a rule add feature to not edit immutable rule * review I * review II * change constant * review III
XavierM
added a commit
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FYI: Reviewers, we still need to work on bringing back where the user was on the page. Instead, to do it manually, I mean we have the history so we should be able to that. I will create another PR for that.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately