-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Kibana Login Selector #53010
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f442437
Introduce Login Selector functionality.
azasypkin d89ab88
Merge branch 'master' into issue-xxx-cloud-sso
azasypkin 5253fc7
Merge branch 'master' into issue-xxx-cloud-sso
azasypkin d6d4c2d
Review#1: introduce `showInSelector` config value, properly handle de…
azasypkin a572c52
Review#2: new unit tests, return response headers from login_with if …
azasypkin 706748a
Merge branch 'master' into issue-xxx-cloud-sso
azasypkin 5b189c2
Review#3: move Login selector logic into `LoginForm` component.
azasypkin db2f4b3
Review#3: rename `BasicLoginForm` to `LoginForm` component.
azasypkin aae6867
Review#3: add initial set of Login Selector API integration tests.
azasypkin 1204619
Review#3: rely on serverBasePath provided by the core for the consist…
azasypkin 181c6db
Merge branch 'master' into issue-xxx-cloud-sso
azasypkin 37c6489
Review#4: remove wrong test comment, add more tests for the `LoginFor…
azasypkin f6b1d4f
Review#5: use `EuiSpacer` instead of CSS margin.
azasypkin c197b9c
Merge branch 'master' into issue-xxx-cloud-sso
azasypkin aed4521
Integrate latest upstream changes after master merge.
azasypkin ceba57b
Review#5: remove redundant user icon from login selector button.
azasypkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { LoginLayout } from './licensing'; | ||
|
||
export interface LoginSelector { | ||
enabled: boolean; | ||
providers: Array<{ type: string; name: string; description?: string }>; | ||
} | ||
|
||
export interface LoginState { | ||
layout: LoginLayout; | ||
allowLogin: boolean; | ||
showLoginForm: boolean; | ||
requiresSecureConnection: boolean; | ||
selector: LoginSelector; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 108 additions & 5 deletions
113
x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
95 changes: 0 additions & 95 deletions
95
...entication/login/components/basic_login_form/__snapshots__/basic_login_form.test.tsx.snap
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: I fixed this and added tests since it looks like a bug to me?