Prepare alerts and actions for feature controls #52956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
mikecote
force-pushed
the
alerting/save-consumer-producer
branch
from
ac2938c to
510bf70
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
cc @elastic/siem and @elastic/stack-monitoring about upcoming breaking change. New |
gmmorris
approved these changes
Dec 18, 2019
| @@ -174,6 +174,7 @@ export const getResult = (): RuleAlertType => ({ | |||
| name: 'Detect Root/Admin Users', | |||
| tags: [`${INTERNAL_RULE_ID_KEY}:rule-1`], | |||
| alertTypeId: 'siem.signals', | |||
| consumer: 'siem', | |||
FrankHassanabad
approved these changes
Dec 18, 2019
…/kibana into alerting/save-consumer-producer
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Dec 18, 2019
* Save consumer with alert * Make consumer mandatory
mikecote
added a commit
that referenced
this pull request
Dec 19, 2019
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #51120
In this PR, I'm adding to the alerts a
consumerfield that will represent the owning application of the alert. We will be able to use this to apply feature controls once it arrives.This seems to be the only extra piece of information we need at this time to satisfy feature controls down the line.