Shim input_control_vis for KP #52243

nickofthyme · 2019-12-05T03:07:29Z

Summary

Shim input_control_vis plugin for kibana platform
Convert plugin to typescript

Checklist

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

- Update Filter types with RangeField and PhaseFilter - Fix broken types in input_control_vis tests

- Missing control parents/ancestors - InputControlVis dirty checking not working

nickofthyme · 2019-12-17T18:25:13Z

@elasticmachine merge upstream

nickofthyme · 2019-12-18T00:40:02Z

@elasticmachine merge upstream

lizozom · 2019-12-18T16:44:39Z

src/legacy/core_plugins/input_control_vis/public/components/editor/list_control_editor.tsx

+  async getIndexPatternSelect() {
+    const [, { data }] = await this.props.deps.core.getStartServices();
+    this.setState({
+      IndexPatternSelect: data.ui.IndexPatternSelect,


lizozom · 2019-12-18T16:49:44Z

src/legacy/core_plugins/input_control_vis/public/control/filter_manager/filter_manager.ts

    return this.indexPattern;
  }

-  getField() {
+  getField(): any {


Why is this any?

lizozom · 2019-12-18T16:56:25Z

...y/core_plugins/input_control_vis/public/control/filter_manager/phrase_filter_manager.test.ts

      id: indexPatternId,
      fields: {
-        getByName: name => {
-          const fields = { field1: fieldMock };
+        getByName: (name: any) => {


flash1293

Just a small note, the rest LGTM. Tested and visualization still works

flash1293 · 2019-12-18T16:47:42Z

src/legacy/core_plugins/input_control_vis/public/components/editor/field_select.tsx

@@ -144,7 +158,7 @@ class FieldSelectUi extends Component {
        label={
          <FormattedMessage
            id="inputControl.editor.fieldSelect.fieldLabel"
-            defaultMessage="Field"
+            defaultMessage="IFieldType"


Seems like this happened accidentally.

Thanks Joe!

lizozom · 2019-12-18T16:57:13Z

...legacy/core_plugins/input_control_vis/public/control/filter_manager/phrase_filter_manager.ts

+  createFilter(phrases: any): esFilters.PhraseFilter {
+    let newFilter: esFilters.PhraseFilter;
+    // TODO: Fix type to be required
+    const value = this.indexPattern.fields.getByName(this.fieldName) as IFieldType;


I thing type is dynamically inferred here

Ya the method may return undefined and the js was not checking that. I added a check to throw if doesn't exist.

const value = this.indexPattern.fields.getByName(this.fieldName); if (!value) { throw new Error(`unable to find fieldName: ${this.fieldName} on indexPattern`); } if (phrases.length === 1) { newFilter = esFilters.buildPhraseFilter(value, phrases[0], this.indexPattern); } else { newFilter = esFilters.buildPhrasesFilter(value, phrases, this.indexPattern); }

lizozom · 2019-12-18T16:59:00Z

src/legacy/core_plugins/input_control_vis/public/vis_controller.tsx

+
+    controls: Array<RangeControl | ListControl>;
+    queryBarUpdateHandler: () => void;
+    filterManager: any;


Use type from data

Thanks I wasn't sure about this type.

lizozom · 2019-12-18T17:00:30Z

src/plugins/data/public/query/timefilter/get_time.ts

@@ -18,10 +18,10 @@
 */

 import dateMath from '@elastic/datemath';
-import { TimeRange } from '../../../common';
+import { IIndexPattern } from 'src/plugins/data/public';


The import is from within the plugin
I think you could do import { IIndexPattern } from '../..';

Thanks my auto import pulls from the aliases by default.

lizozom

in terms of @elastic/kibana-app-arch service usage LGTM
(didn't checkout after updates)

elasticmachine · 2019-12-18T21:34:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 863e713

History

💔 Build #16536 failed 8ff2f91
💚 Build #16521 succeeded b26c551
💚 Build #16340 succeeded 626027a
💔 Build #16317 failed 6d3df03
💔 Build #16296 failed 6d5470a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Shim input_control_vis * Convert input_control_vis src files to typescript * Add Required, Optional, Required and Class types to kbn-utility-types * Collect all ui/* imports into legacy imports file * Pass down plugin deps from top level * Add timeout and terminate_after options to SearchSourceFields

nickofthyme added 2 commits December 3, 2019 10:23

shim input control vis

80f435f

Convert input_control_vis src files to typescript and most tests

0a3d4c8

nickofthyme added Feature:New Platform v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Dec 5, 2019

nickofthyme requested review from kertal and flash1293 December 5, 2019 03:07

nickofthyme added 3 commits December 5, 2019 14:14

Add Required, Optional to kbn-utility-types

8d0d09c

Fix type issues and tests

29d05c8

- Update Filter types with RangeField and PhaseFilter - Fix broken types in input_control_vis tests

Merge branch 'master' into kpm/control-input-shim

740eb4b

elastic deleted a comment from elasticmachine Dec 5, 2019

nickofthyme added 11 commits December 5, 2019 18:59

revert default dynamicOptions multiselect conrtolParams

2ad02fd

fix params type in buildPhrasesFilter

123ced2

fix control test file

6ce4259

fix phrase build filter

89c2746

cleanup types and code

de8f10a

Merge branch 'master' into kpm/control-input-shim

1c1c5f2

cleanup more code

3f57ab3

Fix refactor issues

0cc1150

- Missing control parents/ancestors - InputControlVis dirty checking not working

Merge branch 'master' into kpm/control-input-shim

db35e43

fix type error

526f900

Merge branch 'master' into kpm/control-input-shim

f0bc6f1

elastic deleted a comment from elasticmachine Dec 10, 2019

nickofthyme added 3 commits December 10, 2019 17:31

Collect all ui/* imports into legacy imports file

43c2de2

Fix type error

a22ea72

Fix test mocks from ui/* imports

e415d34

elasticmachine and others added 3 commits December 17, 2019 10:25

Merge branch 'master' into kpm/control-input-shim

f88a14f

Fix range input editor function tests failures

414f2d5

Fix remaining type errors

6d5470a

elasticmachine and others added 4 commits December 17, 2019 16:40

Merge branch 'master' into kpm/control-input-shim

6d3df03

Fix functional test failures

5ee85ab

Fix type error and popularity func test

5a018cb

Merge branch 'master' into kpm/control-input-shim

626027a

lizozom reviewed Dec 18, 2019

View reviewed changes

flash1293 approved these changes Dec 18, 2019

View reviewed changes

lizozom reviewed Dec 18, 2019

View reviewed changes

lizozom approved these changes Dec 18, 2019

View reviewed changes

Merge branch 'master' into kpm/control-input-shim

d20fd22

lizozom mentioned this pull request Dec 18, 2019

Shim plugin for input control #53484

Closed

7 tasks

nickofthyme added 4 commits December 18, 2019 11:38

Address PR comments

59aa8a6

Fix missed comments

b26c551

Add timeout and terminate_after options to SearchSourceFields

8ff2f91

Update terminate_after to number

863e713

nickofthyme merged commit 72c5c5c into elastic:master Dec 18, 2019

nickofthyme deleted the kpm/control-input-shim branch December 18, 2019 22:25

nickofthyme mentioned this pull request Dec 19, 2019

[7.x] Shim input_control_vis for KP (#52243) #53547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shim input_control_vis for KP #52243

Shim input_control_vis for KP #52243

nickofthyme commented Dec 5, 2019 •

edited

Loading

nickofthyme commented Dec 17, 2019

nickofthyme commented Dec 18, 2019

lizozom Dec 18, 2019

lizozom Dec 18, 2019

nickofthyme Dec 18, 2019

lizozom Dec 18, 2019

nickofthyme Dec 18, 2019

flash1293 left a comment

flash1293 Dec 18, 2019

nickofthyme Dec 18, 2019

nickofthyme Dec 18, 2019

lizozom Dec 18, 2019

nickofthyme Dec 18, 2019

nickofthyme Dec 18, 2019

lizozom Dec 18, 2019

nickofthyme Dec 18, 2019

nickofthyme Dec 18, 2019

lizozom Dec 18, 2019

nickofthyme Dec 18, 2019

nickofthyme Dec 18, 2019

lizozom left a comment

elasticmachine commented Dec 18, 2019

Shim input_control_vis for KP #52243

Shim input_control_vis for KP #52243

Conversation

nickofthyme commented Dec 5, 2019 • edited Loading

Summary

Checklist

For maintainers

nickofthyme commented Dec 17, 2019

nickofthyme commented Dec 18, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lizozom left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 18, 2019

💚 Build Succeeded

History

nickofthyme commented Dec 5, 2019 •

edited

Loading