Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM][Detection Engine] Change security model to use SIEM permissions (#51791) #51848

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

FrankHassanabad
Copy link
Contributor

Backports the following commits to 7.x:

## Summary

* Changes incorrect `access:signals-all` to be the correct `access:siem`
* Adds a boom transformer to push back better error messages to the client in some cases

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@FrankHassanabad FrankHassanabad merged commit 7dc3f4a into elastic:7.x Nov 27, 2019
@FrankHassanabad FrankHassanabad deleted the backport/7.x/pr-51791 branch November 27, 2019 22:36
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 28, 2019
* upstream/7.x:
  Move saved queries service + language switcher ⇒ NP (elastic#51812) (elastic#51863)
  [Dependencies]: upgrade react to latest v16.12.0 (elastic#51145) (elastic#51868)
  Allow routes to define some payload config values (elastic#50783) (elastic#51864)
  [ML] Re-activate after method in transform test (elastic#51815) (elastic#51858)
  fixes pagination tests (elastic#51822) (elastic#51830)
  shim visualizations plugin (elastic#50624) (elastic#51801)
  [SIEM][Detection Engine] Change security model to use SIEM permissions (elastic#51848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants