Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fixes cypress pagination tests #51822

Merged
merged 1 commit into from
Nov 27, 2019
Merged

[SIEM] Fixes cypress pagination tests #51822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions x-pack/legacy/plugins/siem/cypress/integration/smoke_tests/pagination/pagination.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,19 @@ describe('Pagination', () => {
return logout();
});

it.skip('pagination updates results and page number', () => {
it('pagination updates results and page number', () => {
loginAndWaitForPage(HOSTS_PAGE_TAB_URLS.uncommonProcesses);
waitForTableLoad(UNCOMMON_PROCCESSES_TABLE);
cy.get(getPageButtonSelector(0)).should('have.class', 'euiPaginationButton-isActive');

cy.get(getDraggableField('user.name'))
cy.get(getDraggableField('process.name'))
.first()
.invoke('text')
.then(text1 => {
cy.get(getPageButtonSelector(2)).click({ force: true });
// wait for table to be done loading
waitForTableLoad(UNCOMMON_PROCCESSES_TABLE);
cy.get(getDraggableField('user.name'))
cy.get(getDraggableField('process.name'))
.first()
.invoke('text')
.should(text2 => {
Expand All @@ -55,7 +55,7 @@ describe('Pagination', () => {
// wait for table to be done loading
waitForTableLoad(UNCOMMON_PROCCESSES_TABLE);

cy.get(getDraggableField('user.name'))
cy.get(getDraggableField('process.name'))
.first()
.invoke('text')
.then(text2 => {
Expand All @@ -70,7 +70,7 @@ describe('Pagination', () => {
waitForTableLoad(UNCOMMON_PROCCESSES_TABLE);
// check uncommon processes table picks up at 3
cy.get(getPageButtonSelector(2)).should('have.class', 'euiPaginationButton-isActive');
cy.get(getDraggableField('user.name'))
cy.get(getDraggableField('process.name'))
.first()
.invoke('text')
.should(text1 => {
Expand All @@ -82,7 +82,7 @@ describe('Pagination', () => {
* We only want to comment this code/test for now because it can be nondeterministic
* when we figure out a way to really mock the data, we should come back to it
*/
it.skip('pagination resets results and page number to first page when refresh is clicked', () => {
it('pagination resets results and page number to first page when refresh is clicked', () => {
loginAndWaitForPage(HOSTS_PAGE_TAB_URLS.uncommonProcesses);
cy.get(NUMBERED_PAGINATION, { timeout: DEFAULT_TIMEOUT });
cy.get(getPageButtonSelector(0)).should('have.class', 'euiPaginationButton-isActive');
Expand All @@ -100,7 +100,7 @@ describe('Pagination', () => {
.last()
.click({ force: true });
waitForTableLoad(UNCOMMON_PROCCESSES_TABLE);
cy.get(getPageButtonSelector(0)).should('have.class', 'euiPaginationButton-isActive');
cy.get(getPageButtonSelector(2)).should('have.class', 'euiPaginationButton-isActive');
// cy.get(getDraggableField('user.name'))
// .first()
// .invoke('text')
Expand Down