enable darwin for the node installation in the CI #51705

v1v · 2019-11-26T11:59:45Z

Summary

Enable darwin OS support when using the scripts for the CI. Therefore, anyone could reproduce the same steps locally independently of the OS.

$ system_profiler SPSoftwareDataType
Software:

    System Software Overview:

      System Version: macOS 10.14.3 (18D42)
      Kernel Version: Darwin 18.2.0
      Boot Volume: Macintosh HD
      Boot Mode: Normal
      Computer Name: v1v-box
      User Name: Victor Edgar Martinez Rubio (vmartinez)
      Secure Virtual Memory: Enabled
      System Integrity Protection: Enabled
      Time since boot: 3:20

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.14.3
BuildVersion:	18D42

$ uname -a
Darwin Victors-MacBook-Pro.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64

$ uname
Darwin

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-11-26T13:27:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5a5c024

mistic

I like the idea, but It would be better to have the opinion of @brianseeders and @spalger here

elasticmachine · 2019-12-05T19:34:55Z

Pinging @elastic/kibana-operations (Team:Operations)

spalger · 2019-12-05T19:35:04Z

@elasticmachine merge upstream

spalger · 2019-12-05T19:37:00Z

I just want to say, I don't recommend running the CI script on your local machine, they're designed to run on single-purpose machines and don't take care to protect user data or be a "good citizen". Please be careful, continue at your own risk :)

elasticmachine · 2019-12-05T20:49:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fc48962

mdelapenya

Well, it's always a good option to have the CI been reproducible in local, otherwise developers won't be able to check if a failure on CI is real or it's something on their own.

If the build does something weird with data, then it must bee encapsulated at CI level, not on build scripts.

tylersmalley · 2019-12-09T07:43:47Z

src/dev/ci_setup/setup_env.sh

@@ -71,7 +73,7 @@ if [[ "$OS" == "win" ]]; then
  nodeUrl="https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/dist/v$nodeVersion/node-v$nodeVersion-win-x64.zip"
 else
  nodeBin="$nodeDir/bin"
-  nodeUrl="https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/dist/v$nodeVersion/node-v$nodeVersion-linux-x64.tar.gz"
+  nodeUrl="https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/dist/v$nodeVersion/node-v$nodeVersion-${OS}-x64.tar.gz"


Since the URL will also work with Windows, mind moving the nodeUrl outside the condition block so we only have a single place where nodeUrl is set?

See 003a361

tylersmalley · 2019-12-09T07:45:36Z

I also want to echo what Spencer mentioned - these setup scripts are for CI and should not be run on your machine. If you want to reproduce what CI is running, you can run the underlying commands on the repository which will build/test.

v1v · 2019-12-09T14:18:55Z

I agree to disagree, :)
Based on my experience, the more simple and agnostic the scripts can be the easier to debug independently of the CI system underneath. This particular PR was based on my very first contact with the Kibana CI.
I do understand that the privileges and so on might be something to double-check after using the CI scripts, but as a first-time contributor I'd say I don't know of what other implications might be involved, so bear with me :)

elasticmachine · 2019-12-09T15:23:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 003a361

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger · 2019-12-10T00:01:49Z

You're welcome to run whatever script you'd like on your computer, I just don't recommend it because we don't write them with the intention of being runnable on your own machine. So, run at your own risk I guess.

v1v · 2020-01-07T12:45:45Z

@elasticmachine merge upstream

…arwin-in-ci

…into feature/support-darwin-in-ci

v1v · 2020-02-03T12:43:02Z

Are there any concerns regarding this PR? Otherwise, when could it be merged? Thanks

jbudz · 2020-02-03T13:31:22Z

good to go - i'll merge once we go green

jbudz · 2020-02-03T13:34:36Z

@v1v do you need this back further than 7.7? dropping the 7.6 labels would help the inevitable feature freeze discussion. alternatively we could wait for 7.6.1

kibanamachine · 2020-02-03T14:01:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b5d8ea5

History

💔 Build #18364 failed d5ca114
💚 Build #14209 succeeded 003a361

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* enable darwin for the node installation in the CI * refactor: avoid hardcode strings and customise based on the OS flavour * fix classifier Co-authored-by: Elastic Machine <[email protected]>

jbudz · 2020-02-03T14:04:54Z

I pushed this to 7.7 for now. let me know if we need it further

v1v · 2020-02-04T11:27:05Z

No, I don't think we need any backport for previous versions. Thanks so much

* enable darwin for the node installation in the CI * refactor: avoid hardcode strings and customise based on the OS flavour * fix classifier Co-authored-by: Elastic Machine <[email protected]>

enable darwin for the node installation in the CI

5a5c024

v1v self-assigned this Nov 26, 2019

v1v added the automation label Nov 26, 2019

v1v requested review from ElWPenn, kuisathaverat and mdelapenya November 26, 2019 11:59

v1v marked this pull request as ready for review November 26, 2019 12:00

v1v requested a review from a team as a code owner November 26, 2019 12:00

mistic reviewed Nov 26, 2019

View reviewed changes

kuisathaverat approved these changes Nov 26, 2019

View reviewed changes

jbudz approved these changes Nov 26, 2019

View reviewed changes

spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v6.8.5 v7.3.2 v7.4.3 v7.5.1 v7.6.0 v8.0.0 labels Dec 5, 2019

Merge branch 'master' into feature/support-darwin-in-ci

fc48962

mdelapenya approved these changes Dec 9, 2019

View reviewed changes

tylersmalley suggested changes Dec 9, 2019

View reviewed changes

refactor: avoid hardcode strings and customise based on the OS flavour

003a361

tylersmalley approved these changes Dec 10, 2019

View reviewed changes

tylersmalley added v6.8.6 and removed v6.8.5 labels Dec 10, 2019

rashmivkulkarni removed v7.5.1 v6.8.6 labels Dec 13, 2019

elasticmachine and others added 4 commits January 7, 2020 04:45

Merge branch 'master' into feature/support-darwin-in-ci

d5ca114

Merge remote-tracking branch 'upstream/master' into feature/support-d…

a19ad3b

…arwin-in-ci

fix classifier

0763b9c

Merge branch 'feature/support-darwin-in-ci' of github.com:v1v/kibana …

b5d8ea5

…into feature/support-darwin-in-ci

jbudz added v7.5.2 v7.7.0 and removed v7.3.2 v7.4.3 labels Feb 3, 2020

jbudz merged commit c76519e into elastic:master Feb 3, 2020

jbudz removed v7.5.2 v7.6.0 labels Feb 3, 2020

v1v deleted the feature/support-darwin-in-ci branch February 4, 2020 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable darwin for the node installation in the CI #51705

enable darwin for the node installation in the CI #51705

v1v commented Nov 26, 2019 •

edited

Loading

elasticmachine commented Nov 26, 2019

mistic left a comment

elasticmachine commented Dec 5, 2019

spalger commented Dec 5, 2019

spalger commented Dec 5, 2019

elasticmachine commented Dec 5, 2019

mdelapenya left a comment

tylersmalley Dec 9, 2019

v1v Dec 9, 2019

tylersmalley commented Dec 9, 2019

v1v commented Dec 9, 2019

elasticmachine commented Dec 9, 2019

spalger commented Dec 10, 2019

v1v commented Jan 7, 2020

v1v commented Feb 3, 2020

jbudz commented Feb 3, 2020 •

edited

Loading

jbudz commented Feb 3, 2020

kibanamachine commented Feb 3, 2020

jbudz commented Feb 3, 2020

v1v commented Feb 4, 2020

enable darwin for the node installation in the CI #51705

enable darwin for the node installation in the CI #51705

Conversation

v1v commented Nov 26, 2019 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

mistic left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 5, 2019

spalger commented Dec 5, 2019

spalger commented Dec 5, 2019

elasticmachine commented Dec 5, 2019

💚 Build Succeeded

mdelapenya left a comment

Choose a reason for hiding this comment

tylersmalley Dec 9, 2019

Choose a reason for hiding this comment

v1v Dec 9, 2019

Choose a reason for hiding this comment

tylersmalley commented Dec 9, 2019

v1v commented Dec 9, 2019

elasticmachine commented Dec 9, 2019

💚 Build Succeeded

spalger commented Dec 10, 2019

v1v commented Jan 7, 2020

v1v commented Feb 3, 2020

jbudz commented Feb 3, 2020 • edited Loading

jbudz commented Feb 3, 2020

kibanamachine commented Feb 3, 2020

💚 Build Succeeded

History

jbudz commented Feb 3, 2020

v1v commented Feb 4, 2020

v1v commented Nov 26, 2019 •

edited

Loading

jbudz commented Feb 3, 2020 •

edited

Loading