Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SearchProfiler] Copy updates #51700

Merged
merged 3 commits into from
Nov 26, 2019
Merged

[SearchProfiler] Copy updates #51700

merged 3 commits into from
Nov 26, 2019

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Nov 26, 2019 •
edited
Loading

Summary

CC @miukimiu

Screenshots Screenshot 2019-11-26 at 11 19 39 Screenshot 2019-11-26 at 11 20 56

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@jloleysens jloleysens added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Search Profiler v7.6.0 labels Nov 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

alisonelizabeth
alisonelizabeth approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes LGTM. Tested changes in Chrome, FF, and Safari.

@jloleysens jloleysens merged commit ac0e3e1 into elastic:master Nov 26, 2019
@jloleysens jloleysens deleted the searchprofiler/copy-updates branch November 26, 2019 13:24
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 26, 2019
@jloleysens
[SearchProfiler] Copy updates (elastic#51700)
cb5e356 
* Update search profiler copy

* Fix pristine logic

* Update searchprofiler styles
@jloleysens jloleysens mentioned this pull request Nov 26, 2019
Merged
jloleysens added a commit that referenced this pull request Nov 26, 2019
@jloleysens
[SearchProfiler] Copy updates (#51700) (#51716)
31b20f4 
* Update search profiler copy

* Fix pristine logic

* Update searchprofiler styles
@alisonelizabeth alisonelizabeth mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@gchaps gchaps Awaiting requested review from gchaps

Assignees
No one assigned
Labels
Feature:Search Profiler release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jloleysens @elasticmachine @alisonelizabeth