Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase the timeout when checking for deprecation log #51505

Merged
merged 3 commits into from
Nov 25, 2019
Merged

increase the timeout when checking for deprecation log #51505

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
871873f
increase the timeout when checking for deprecation log
Nov 22, 2019
da6483b
re-enable the tests
Nov 22, 2019
b27eca5
Merge branch 'master' into fix/flaky-test-51479
elasticmachine Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/legacy/server/config/__tests__/deprecation_warnings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ const RUN_KBN_SERVER_STARTUP = require.resolve('./fixtures/run_kbn_server_startu
const SETUP_NODE_ENV = require.resolve('../../../../setup_node_env');
const SECOND = 1000;

// FLAKY: https://github.com/elastic/kibana/issues/51479
describe.skip('config/deprecation warnings', function () {
describe('config/deprecation warnings', function () {
this.timeout(15 * SECOND);

let stdio = '';
Expand All @@ -52,9 +51,9 @@ describe.skip('config/deprecation warnings', function () {
}
});

// Either time out in 10 seconds, or resolve once the line is in our buffer
// Either time out in 60 seconds, or resolve once the line is in our buffer
return Promise.race([
new Promise((resolve) => setTimeout(resolve, 10000)),
new Promise((resolve) => setTimeout(resolve, 60000)),
new Promise((resolve, reject) => {
proc.stdout.on('data', (chunk) => {
stdio += chunk.toString('utf8');
Expand Down