-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect statement about Lucene's default operator #50987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gchaps do you have any tricks to make backporting docs changes to a ton of branches less painful? 😅 |
💚 Build Succeeded |
gchaps
reviewed
Nov 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Use yarn backport-skip-ci
to make the backporting go faster.
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
This was referenced Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
This was referenced Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Bargs
added a commit
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #50048
Lucene uses
or
as its default operator, soresponse:200 extension:php
would becomeresponse:200 or extension:php
.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately