Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5] [Telemetry] Remove telemetry splash page and add conditional messaging (#50189) #50430

Merged
merged 10 commits into from
Nov 13, 2019
Merged

[7.5] [Telemetry] Remove telemetry splash page and add conditional messaging (#50189) #50430

merged 10 commits into from
Nov 13, 2019

Conversation

joelgriffith
Copy link
Contributor

Backports the following commits to 7.5:

#50189)

* Removing tel splash page in UI layer

* Removing more components

* New disclaimer text

* Removing telemetry i18n text

* More i18n text removals

* Snapshot updates

* Snapshot tests + quick links for tel opt-out when possible

* Fixing TS issues in test
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mikecote
Copy link
Contributor

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joelgriffith
Copy link
Contributor Author

Man I cannot make sense of this failure. Everything looks correct and it fires in the browser properly...

@mikecote
Copy link
Contributor

@joelgriffith I'm wondering if this is interfering with other telemetry work that's happening. I merged something else 32m ago (dc4700c). Might as well make CI retest with it.

@mikecote
Copy link
Contributor

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joelgriffith
Copy link
Contributor Author

hold together

@joelgriffith
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joelgriffith joelgriffith merged commit e9c34c4 into elastic:7.5 Nov 13, 2019
@joelgriffith
Copy link
Contributor Author

we're outta here kid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants