Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] Shim with local application service #49891

Merged
merged 180 commits into from
Dec 10, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
180 commits
Select commit Hold shift + click to select a range
62f3164
centralize dependencies
flash1293 Oct 18, 2019
0bf00ae
move more stuff into kibana_services
flash1293 Oct 18, 2019
e72e51a
fix tests and dependency
flash1293 Oct 18, 2019
b42f417
bootstrap home via local application service
flash1293 Oct 19, 2019
0d2521e
fix routing for home app
flash1293 Oct 19, 2019
12fb70b
Merge remote-tracking branch 'upstream/master' into centralize-home
flash1293 Oct 21, 2019
af3ad7f
switch to dependency getter instead of direct exports
flash1293 Oct 21, 2019
a455322
Merge branch 'centralize-home' into local-application-service
flash1293 Oct 21, 2019
a1295d3
clean up
flash1293 Oct 21, 2019
082748a
add redirect functionality to local application service
flash1293 Oct 21, 2019
2bf3bf6
return early from route change handlers on dummy wrapper route
flash1293 Oct 21, 2019
398299c
fix jest tests
flash1293 Oct 21, 2019
44bcd46
Start shimming dashboard
flash1293 Oct 21, 2019
822cdac
Merge remote-tracking branch 'upstream/master' into centralize-home
flash1293 Oct 22, 2019
4ea2e63
fix broken tests
flash1293 Oct 22, 2019
22c5588
Merge branch 'centralize-home' into local-application-service
flash1293 Oct 22, 2019
1bd6b3b
local application service
flash1293 Oct 22, 2019
ae8dd12
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Oct 22, 2019
afafe10
wip
flash1293 Oct 22, 2019
a7f2826
wip
flash1293 Oct 22, 2019
dbcf159
Merge branch 'local-application-service' into shim-dashboard
flash1293 Oct 22, 2019
c417060
fix mounting home several times
flash1293 Oct 22, 2019
0f2b23b
Merge branch 'local-application-service' into shim-dashboard
flash1293 Oct 22, 2019
03fd207
wip
flash1293 Oct 22, 2019
160fe52
Centralize dependencies for Visualize plugin
maryia-lapata Oct 23, 2019
eea7c62
move handlers from addSetupWork into legacy_compat
flash1293 Oct 24, 2019
4f0c5b2
pass dependencies into angular configurator
flash1293 Oct 24, 2019
f1ff388
centralize dependencies and clean up shim
flash1293 Oct 24, 2019
48ecdf7
Merge branch 'master' into flash1293/local-application-service
elasticmachine Oct 24, 2019
0b595a0
Centralizing dependencies in editor and embeddable
maryia-lapata Oct 25, 2019
192b88c
Merge remote-tracking branch 'kibana/master' into vis-centr
maryia-lapata Oct 25, 2019
46ba3db
Remove unused deps, move imports
maryia-lapata Oct 25, 2019
36ec4e1
Fix dangerouslyGetActiveInjector
maryia-lapata Oct 25, 2019
abfdc2a
Move loading directive to kibana_services.ts
maryia-lapata Oct 25, 2019
d1700d2
remove requireDefaultIndex and provide helper function
flash1293 Oct 25, 2019
0dd5d3a
rename function and improve documentation
flash1293 Oct 25, 2019
1dc18c7
Fix exceptions
maryia-lapata Oct 25, 2019
57a1115
Get rid of injectI18n; fix chrome method invocation
maryia-lapata Oct 25, 2019
72fd4ac
Update unit tests
maryia-lapata Oct 25, 2019
74fb184
Merge remote-tracking branch 'upstream/master' into flash1293/local-a…
flash1293 Oct 28, 2019
79a1a14
Merge branch 'flash1293/local-application-service' of github.com:flas…
flash1293 Oct 28, 2019
9bda285
Merge branch 'flash1293/local-application-service' into local-applica…
flash1293 Oct 28, 2019
50b1d97
Merge branch 'flash1293/local-application-service' into shim-dashboard
flash1293 Oct 28, 2019
105af0a
redirect unknown urls to default app
flash1293 Oct 28, 2019
7132b4a
Merge remote-tracking branch 'kibana/master' into vis-centr
maryia-lapata Oct 28, 2019
65ef3d0
Fix TS
maryia-lapata Oct 28, 2019
d66b1ad
Move data and Embeddable import
maryia-lapata Oct 29, 2019
39e64e3
Import VISUALIZE_EMBEDDABLE_TYPE directly
maryia-lapata Oct 29, 2019
c1bd95d
Merge remote-tracking branch 'kibana/master' into vis-centr
maryia-lapata Oct 29, 2019
8dd28f7
Fix deps
maryia-lapata Oct 29, 2019
cea2411
Merge branch 'vis-centr' into vis-shim
maryia-lapata Oct 29, 2019
677e502
Merge remote-tracking branch 'joe/local-application-service' into vis…
maryia-lapata Oct 29, 2019
f9b47f1
only wire up local angular once
flash1293 Oct 29, 2019
bd31c10
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Oct 30, 2019
a6149b5
Merge remote-tracking branch 'kibana/master' into vis-centr
maryia-lapata Oct 30, 2019
3a43d2b
Merge branch 'vis-centr' into vis-shim
maryia-lapata Oct 30, 2019
0777b47
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Oct 30, 2019
1246675
fix top nav and dashboard only mode
flash1293 Oct 30, 2019
a34dd9f
decouple frome home shim PR
flash1293 Oct 31, 2019
d1defcc
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Oct 31, 2019
e8c59f7
fix typing problems
flash1293 Oct 31, 2019
e238a5d
fix other bugs
flash1293 Oct 31, 2019
3ef6254
got rid of two other angular dependencies
flash1293 Oct 31, 2019
ce902cd
fix i18n issue
flash1293 Oct 31, 2019
8022d4d
fix various issues
flash1293 Oct 31, 2019
51d35b6
Shim visualize plugin
maryia-lapata Oct 31, 2019
936f09a
added some debug notes
flash1293 Oct 31, 2019
784a20e
fix vis filters
flash1293 Oct 31, 2019
b4b3bdf
Revert loading sidebar
maryia-lapata Nov 1, 2019
b5250cf
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 1, 2019
ba78539
improve
flash1293 Nov 1, 2019
9eb9d52
Revert
maryia-lapata Nov 1, 2019
05d3295
Refactoring
maryia-lapata Nov 1, 2019
ac462b5
fix hooks handling for local routes in legacy_compat
flash1293 Nov 3, 2019
72b52ae
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Nov 3, 2019
3c619d2
fix embedded visualize handler tests
flash1293 Nov 3, 2019
02caf27
fix test failures
flash1293 Nov 3, 2019
144699b
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Nov 3, 2019
78855e1
remove buggy test
flash1293 Nov 3, 2019
6600a45
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 4, 2019
b35161a
Update TS
maryia-lapata Nov 4, 2019
553c1a8
Refactor register factory
maryia-lapata Nov 4, 2019
97cf008
Move registering of CatalogueRegistryProvider to plugin.ts
maryia-lapata Nov 4, 2019
d94cdf5
Adjust TS
maryia-lapata Nov 4, 2019
af16306
Implement getUnhashableStates
maryia-lapata Nov 4, 2019
2b4a788
Fix TSVB
maryia-lapata Nov 4, 2019
99188d1
Allow set services multiple times
maryia-lapata Nov 4, 2019
1f56489
Move embeddableFactory registration to setup
maryia-lapata Nov 4, 2019
14d8fd4
different take on global state handling
flash1293 Nov 4, 2019
fa13e4b
fix detection of url state
flash1293 Nov 4, 2019
2a5c0fb
fix broken test
flash1293 Nov 4, 2019
9ef8a14
Use uiSettings instead of config
maryia-lapata Nov 5, 2019
b08b841
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 5, 2019
9c51937
Add npDataStart
maryia-lapata Nov 5, 2019
8d8f22b
Add Dashboard shim
maryia-lapata Nov 5, 2019
233a440
Register embeddableFactory in start
maryia-lapata Nov 5, 2019
39d94d9
Merge branch 'master' into vis-shim
maryia-lapata Nov 6, 2019
c095b53
Use feature_catalogue instead of FeatureCatalogueRegistryProvider
maryia-lapata Nov 6, 2019
38635f4
Use queryFilter as npDataStart.query.filterManager instead of Private…
maryia-lapata Nov 6, 2019
a65dd3f
Add type for angular
maryia-lapata Nov 6, 2019
45e875d
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Nov 7, 2019
5f9120b
never update state in dummy route mode
flash1293 Nov 7, 2019
296c174
clean up implementation
flash1293 Nov 7, 2019
8fb0fbd
fix type error
flash1293 Nov 7, 2019
f5ebcf7
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Nov 8, 2019
fad42dd
remove session storage global state handling for now
flash1293 Nov 8, 2019
d41bc2b
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 11, 2019
0618c53
move syncOnMount to a separate file
maryia-lapata Nov 11, 2019
ff832e0
Prevent reload on search
maryia-lapata Nov 11, 2019
ab288a6
Revert centralizing deps for embeddable
maryia-lapata Nov 11, 2019
ab1c4b7
Revert partially setting services
maryia-lapata Nov 11, 2019
00d6dc1
Revert changes in local_application_service
maryia-lapata Nov 11, 2019
f005b4e
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Nov 12, 2019
35b508a
Pass services to NewVisModal as props
maryia-lapata Nov 12, 2019
588c46a
Adjust unit tests
maryia-lapata Nov 12, 2019
dcb9a88
remove unused dependencies
flash1293 Nov 12, 2019
a21ba30
started centralizing and cleaning up imports
flash1293 Nov 12, 2019
4371ce5
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 12, 2019
14a0de3
Add missed changes
maryia-lapata Nov 12, 2019
055e601
Fix TS
maryia-lapata Nov 12, 2019
84f4f40
Add ts-ignore
maryia-lapata Nov 12, 2019
2b22082
Fix dataStart
maryia-lapata Nov 12, 2019
7ec261d
centralize external imports
flash1293 Nov 12, 2019
f7c81c3
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 13, 2019
23399ea
Rename render_app.ts to application.ts
maryia-lapata Nov 13, 2019
928f34f
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Nov 13, 2019
6fab153
Fix merge conflicts
maryia-lapata Nov 13, 2019
a0abd00
fix import bugs
flash1293 Nov 13, 2019
aaca94e
Fix merge conflict
maryia-lapata Nov 13, 2019
4ac0a91
Add dashboard updates
maryia-lapata Nov 13, 2019
9b747e0
Use I18nProvider instead of I18nContext
maryia-lapata Nov 13, 2019
d140691
remove unused dependencies
maryia-lapata Nov 13, 2019
ccb7a53
Centralizing and cleaning up legacy imports
maryia-lapata Nov 13, 2019
42db084
Merge remote-tracking branch 'upstream/master' into shim-dashboard
flash1293 Nov 13, 2019
cb920b8
Fix merge conflict
maryia-lapata Nov 13, 2019
8bdca65
fix merge bugs and rename main dynamic entrypoint
flash1293 Nov 13, 2019
613dcd8
Rename app to legacy_app
maryia-lapata Nov 13, 2019
3622f8e
Clear deps
maryia-lapata Nov 13, 2019
042f2e8
fix jest tests
flash1293 Nov 13, 2019
363a907
fix saved object finder bug
flash1293 Nov 13, 2019
f5dacfd
Fix unit tests
maryia-lapata Nov 13, 2019
11b8442
Ignore TS
maryia-lapata Nov 13, 2019
9296c4c
revert using stateless component for this PR
flash1293 Nov 13, 2019
8d41818
fix types
flash1293 Nov 13, 2019
b51a46c
Merge branch 'shim-dashboard' into vis-shim
maryia-lapata Nov 14, 2019
ca30093
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 26, 2019
1d8db9e
Fix merge conflicts
maryia-lapata Nov 26, 2019
f379887
Update deps
maryia-lapata Nov 26, 2019
17b6d9d
Revert filter bar export
maryia-lapata Nov 26, 2019
67f2739
Revert ts-ignore
maryia-lapata Nov 26, 2019
1b09e9c
Clean up
maryia-lapata Nov 26, 2019
e57c785
Refactoring
maryia-lapata Nov 26, 2019
910874b
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 27, 2019
4f3f13d
Fix test
maryia-lapata Nov 27, 2019
6f0a4c1
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 28, 2019
3d64613
Remove global_state_sync
maryia-lapata Nov 28, 2019
aacd83b
Refactoring
maryia-lapata Nov 28, 2019
ce9d39d
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 29, 2019
f37e188
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Nov 29, 2019
2856b48
Remove uiExports/embeddableFactories
maryia-lapata Nov 29, 2019
35c3358
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Dec 2, 2019
2a70e56
Trigger digest cycle in local angular when vis is changed.
maryia-lapata Dec 2, 2019
172165a
Fix TS
maryia-lapata Dec 2, 2019
e425e2c
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Dec 2, 2019
ca0b9ad
Revert back syncOnMount
maryia-lapata Dec 2, 2019
d616173
Add missed import
maryia-lapata Dec 2, 2019
ffbf8af
Revert import 'uiExports/embeddableFactories'
maryia-lapata Dec 2, 2019
f3b8039
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Dec 3, 2019
5b34d1c
Update app navigation func test
maryia-lapata Dec 3, 2019
26eb210
Update app navigation func test
maryia-lapata Dec 3, 2019
843fbe3
Update app navigation func test
maryia-lapata Dec 3, 2019
d58434b
Remove 'kibana-install-dir' arg in pluginFunctionalTestsRelease
maryia-lapata Dec 3, 2019
0bcb116
Merge branch 'master' into vis-shim
maryia-lapata Dec 6, 2019
5c82113
Fix review comments
maryia-lapata Dec 6, 2019
86306a3
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Dec 9, 2019
3bd47af
Fix code review comments
maryia-lapata Dec 9, 2019
b0c5243
Merge remote-tracking branch 'kibana/master' into vis-shim
maryia-lapata Dec 9, 2019
b09c332
Rename alias
maryia-lapata Dec 9, 2019
51e5691
Fix indexPatterns
maryia-lapata Dec 9, 2019
9016c3c
Use IndexPatternsContract interface
maryia-lapata Dec 10, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/legacy/core_plugins/kibana/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export default function (kibana) {
hacks: [
'plugins/kibana/discover',
'plugins/kibana/dev_tools',
'plugins/kibana/visualize',
],
savedObjectTypes: [
'plugins/kibana/visualize/saved_visualizations/saved_visualization_register',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
-->
<kbn-top-nav
ng-if="showFilterBar() && !isVisible"

app-name="'dashboard'"
show-search-bar="true"
show-filter-bar="true"
Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/kibana.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import { npSetup } from 'ui/new_platform';
import 'uiExports/home';
import 'uiExports/visTypes';

import 'uiExports/visEditorTypes';
import 'uiExports/visualize';
import 'uiExports/savedObjectTypes';
import 'uiExports/fieldFormatEditors';
Expand Down
193 changes: 193 additions & 0 deletions src/legacy/core_plugins/kibana/public/visualize/application.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,193 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import angular, { IModule } from 'angular';
import { EuiConfirmModal } from '@elastic/eui';
import { i18nDirective, i18nFilter, I18nProvider } from '@kbn/i18n/angular';

import { AppMountContext, LegacyCoreStart } from 'kibana/public';
import {
AppStateProvider,
AppState,
configureAppAngularModule,
confirmModalFactory,
createTopNavDirective,
createTopNavHelper,
EventsProvider,
GlobalStateProvider,
KbnUrlProvider,
RedirectWhenMissingProvider,
IPrivate,
PersistedState,
PrivateProvider,
PromiseServiceCreator,
StateManagementConfigProvider,
} from './legacy_imports';
import { NavigationStart } from '../../../navigation/public';

// @ts-ignore
import { initVisualizeApp } from './legacy_app';
import { VisualizeKibanaServices } from './kibana_services';

let angularModuleInstance: IModule | null = null;

export const renderApp = async (
element: HTMLElement,
appBasePath: string,
deps: VisualizeKibanaServices
) => {
if (!angularModuleInstance) {
angularModuleInstance = createLocalAngularModule(deps.core, deps.navigation);
// global routing stuff
configureAppAngularModule(angularModuleInstance, deps.core as LegacyCoreStart, true);
// custom routing stuff
initVisualizeApp(angularModuleInstance, deps);
}
const $injector = mountVisualizeApp(appBasePath, element);
return () => $injector.get('$rootScope').$destroy();
};

const mainTemplate = (basePath: string) => `<div style="height: 100%">
<base href="${basePath}" />
<div ng-view style="height: 100%;"></div>
</div>
`;

const moduleName = 'app/visualize';

const thirdPartyAngularDependencies = ['ngSanitize', 'ngRoute', 'react'];

function mountVisualizeApp(appBasePath: string, element: HTMLElement) {
const mountpoint = document.createElement('div');
mountpoint.setAttribute('style', 'height: 100%');
mountpoint.innerHTML = mainTemplate(appBasePath);
// bootstrap angular into detached element and attach it later to
// make angular-within-angular possible
const $injector = angular.bootstrap(mountpoint, [moduleName]);
// initialize global state handler
element.appendChild(mountpoint);
return $injector;
}

function createLocalAngularModule(core: AppMountContext['core'], navigation: NavigationStart) {
createLocalI18nModule();
createLocalPrivateModule();
createLocalPromiseModule();
createLocalConfigModule(core);
createLocalKbnUrlModule();
createLocalStateModule();
createLocalPersistedStateModule();
createLocalTopNavModule(navigation);
createLocalConfirmModalModule();

const visualizeAngularModule: IModule = angular.module(moduleName, [
...thirdPartyAngularDependencies,
'app/visualize/Config',
'app/visualize/I18n',
'app/visualize/Private',
'app/visualize/PersistedState',
'app/visualize/TopNav',
'app/visualize/State',
'app/visualize/ConfirmModal',
]);
return visualizeAngularModule;
}

function createLocalConfirmModalModule() {
angular
.module('app/visualize/ConfirmModal', ['react'])
.factory('confirmModal', confirmModalFactory)
.directive('confirmModal', reactDirective => reactDirective(EuiConfirmModal));
}

function createLocalStateModule() {
angular
.module('app/visualize/State', [
'app/visualize/Private',
'app/visualize/Config',
'app/visualize/KbnUrl',
'app/visualize/Promise',
'app/visualize/PersistedState',
])
.factory('AppState', function(Private: IPrivate) {
return Private(AppStateProvider);
})
.service('getAppState', function(Private: IPrivate) {
return Private<AppState>(AppStateProvider).getAppState;
})
.service('globalState', function(Private: IPrivate) {
return Private(GlobalStateProvider);
});
}

function createLocalPersistedStateModule() {
angular
.module('app/visualize/PersistedState', ['app/visualize/Private', 'app/visualize/Promise'])
.factory('PersistedState', (Private: IPrivate) => {
const Events = Private(EventsProvider);
return class AngularPersistedState extends PersistedState {
constructor(value: any, path: any) {
super(value, path, Events);
}
};
});
}

function createLocalKbnUrlModule() {
angular
.module('app/visualize/KbnUrl', ['app/visualize/Private', 'ngRoute'])
.service('kbnUrl', (Private: IPrivate) => Private(KbnUrlProvider))
.service('redirectWhenMissing', (Private: IPrivate) => Private(RedirectWhenMissingProvider));
}

function createLocalConfigModule(core: AppMountContext['core']) {
angular
.module('app/visualize/Config', ['app/visualize/Private'])
.provider('stateManagementConfig', StateManagementConfigProvider)
.provider('config', () => {
return {
$get: () => ({
get: core.uiSettings.get.bind(core.uiSettings),
}),
};
});
}

function createLocalPromiseModule() {
angular.module('app/visualize/Promise', []).service('Promise', PromiseServiceCreator);
}

function createLocalPrivateModule() {
angular.module('app/visualize/Private', []).provider('Private', PrivateProvider);
}

function createLocalTopNavModule(navigation: NavigationStart) {
angular
.module('app/visualize/TopNav', ['react'])
.directive('kbnTopNav', createTopNavDirective)
.directive('kbnTopNavHelper', createTopNavHelper(navigation.ui));
}

function createLocalI18nModule() {
angular
.module('app/visualize/I18n', [])
.provider('i18n', I18nProvider)
.filter('i18n', i18nFilter)
.directive('i18nId', i18nDirective);
}
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
show-search-bar="true"
show-query-bar="true"
show-query-input="showQueryInput()"
show-filter-bar="showFilterBar() && chrome.getVisible()"
show-filter-bar="showFilterBar() && isVisible"
show-date-picker="showQueryBarTimePicker()"
show-auto-refresh-only="!showQueryBarTimePicker()"
query="state.query"
Expand Down Expand Up @@ -67,7 +67,7 @@
-->
<kbn-top-nav
ng-if="showFilterBar() && !isVisible"

app-name="'visualize'"
show-search-bar="true"
show-filter-bar="true"
Expand All @@ -91,7 +91,7 @@
</div>

<visualization-embedded
ng-if="!chrome.getVisible()"
ng-if="!isVisible"
class="visualize"
saved-obj="savedVis"
ui-state="uiState"
Expand All @@ -110,7 +110,7 @@
>
</h1>
<visualization-editor
ng-if="chrome.getVisible()"
ng-if="isVisible"
saved-obj="savedVis"
ui-state="uiState"
time-range="timeRange"
Expand Down
Loading