Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3833 make Visualize sidebar collapsible #4946

Merged
merged 1 commit into from
Sep 16, 2015
+11 −4
Merged

Fixes #3833 make Visualize sidebar collapsible #4946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plugins/kibana/public/visualize/editor/editor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@

<div class="vis-editor-content">

<vis-editor-sidebar class="vis-editor-sidebar" ng-if="chrome.getVisible()"></vis-editor-sidebar>
<div class="collapsible-sidebar">
<vis-editor-sidebar class="vis-editor-sidebar" ng-if="chrome.getVisible()"></vis-editor-sidebar>
</div>

<div class="vis-editor-canvas" ng-class="{ embedded: !chrome.getVisible() }">
<div class="visualize-info" ng-if="savedVis.id">
Expand Down
1 change: 1 addition & 0 deletions src/plugins/kibana/public/visualize/editor/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ define(function (require) {

require('ui/visualize');
require('ui/clipboard');
require('ui/collapsible_sidebar');

require('ui/routes')
.when('/visualize/create', {
Expand Down
6 changes: 5 additions & 1 deletion src/plugins/kibana/public/visualize/editor/styles/_editor.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,12 @@
}
}

&-sidebar {
.collapsible-sidebar {
.flex-parent(0, 0, auto);
}

&-sidebar {
.flex-parent(1, 0, auto);

// overrided for tablet and desktop
@media (min-width: @screen-md-min) {
Expand Down
4 changes: 2 additions & 2 deletions src/ui/public/collapsible_sidebar/collapsible_sidebar.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@import (reference) "~ui/styles/variables";

.sidebar-container.collapsible-sidebar {
.collapsible-sidebar {
position: relative;
z-index: 1;

Expand Down Expand Up @@ -61,7 +61,7 @@
}

@media (max-width: 992px) {
.sidebar-container.collapsible-sidebar {
.collapsible-sidebar {
&.closed {
display: none;
}
Expand Down